- Oct 06, 2020
-
-
Guillaume Tucker authored
Fix undefined variable when not using the no_pty flag for raw_cpu_uart_pty. Fixes: eac48b5e ('servo: also skip raw_cpu_uart_pty if no_pty="true"') Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
-
- Sep 11, 2020
-
-
Guillaume Tucker authored
Switch to a native package See merge request !1
-
Sjoerd Simons authored
-
Guillaume Tucker authored
Add the debian directory without any patch files to build packages natively since this is not (yet) available in Debian upstream. Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
-
- Sep 10, 2020
-
-
Guillaume Tucker authored
Don't include bash_completion for now as it's breaking the build in OBS. Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
-
Guillaume Tucker authored
When disabling the pty console on raw_cpu_uart_pty, it's also needed to disable cpu_uart_pty in uart_common.xml. Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
-
Guillaume Tucker authored
Just like servo_micro.xml, disable the pty console on raw_cpu_uart_pty for Cr50 CCD devices to directly use the /dev/ttyUSB* one instead. Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
-
Guillaume Tucker authored
As the CPU console often gets stuck in a "flushing" state with some devices when using the Servo Micro board, disable the pty console and keep using the /dev/ttyUSB* device instead which appears to be working normally. Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
-
Guillaume Tucker authored
In the same way that cpu_hart_pty is skipped when the no_pty attribute is enabled in the XML configuration, also skip creating a pty console for the raw_cpu_uart_pty device. It's not entirely clear whether both need to be considered as cpu_uart_pty should depend on raw_cpu_uart_pty, or if all the consoles would need to look for the no_pty attribute to make this less hacky. This needs to be further investigated and consolidated. Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
-
Guillaume Tucker authored
In order to work around issues seen with the CPU pty consoles, add a work-around to leave the console as its original /dev/ttyUSB* device and not reconfigure it as a /dev/pty/* one. This only applies to cpu_uart_pty at the moment, and can be done by setting the no_pty="true" attribute in the XML params for that console. Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
-
Guillaume Tucker authored
When several stm32usb serial consoles are present, compare each USB device serial number with the micro servo to find the correct one rather than using the usb.util.get_string() method which appears to be doing something completely different and never returns a matching serial number. The Servo Micro uses such a console, so when connecting more than one to the same controller the issue occurs. This issue cannot be seen when only one servo board has a stm32usm serial device. Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
-
Guillaume Tucker authored
Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
-
Guillaume Tucker authored
Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
-
Guillaume Tucker authored
Tested on Debian Stretch with default configuration. Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
-
Add missing libusb to the list of libs to link to toad via LIBFTDI_LDLIBS. Signed-off-by: Daniel Stone <daniels@collabora.com> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
-
- Aug 20, 2020
-
-
Ruben Rodriguez Buchillon authored
This is now handled by whatever the test framework is (autotest). BUG=b:158616208 TEST=start servod PORT=9999 BOARD=kevin Change-Id: I4a617a331603752a74302ec879dede5805cc590c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/hdctools/+/2321281 Tested-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org> Reviewed-by: Garry Wang <xianuowang@chromium.org> Reviewed-by: Otabek Kasimov <otabek@google.com> Commit-Queue: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
-
- Aug 18, 2020
-
-
Matthew Blecker authored
BUG=chromium:571476 TEST=Started servod using Servo v4 MP + CR50 CCD + Atlas DUT. No errors, and servo_v4.xml continues to be used. Change-Id: I751505fd21ad68135059c4b3dd84dd5f5eaebbb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/hdctools/+/2360923 Tested-by: Matthew Blecker <matthewb@chromium.org> Reviewed-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org> Commit-Queue: Matthew Blecker <matthewb@chromium.org>
-
Andrew Luo authored
Change-Id: I0bd71c5a6a78ba1de639b12e84fc0fda2285b01e Bug=b:159628769 TEST=python2 -m pytest cr50_unittest.py; firmware_Cr50CCDServoCap Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/hdctools/+/2304344 Reviewed-by: Mary Ruthven <mruthven@chromium.org> Tested-by: Andrew Luo <aluo@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org>
-
Mary Ruthven authored
BUG=b:159943864 TEST=run ec_active_copy a lot make sure it doesn't change for i in {1..100} ; do dut-control ec_active_copy | grep RW || break; done Change-Id: I3a45a8d568b9985c7d19fa9d52afdc989d91e878 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/hdctools/+/2357392 Tested-by: Mary Ruthven <mruthven@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Commit-Queue: Mary Ruthven <mruthven@chromium.org>
-
- Aug 13, 2020
-
-
Mary Ruthven authored
Add name_prefix to the remap control_name. The kukui warm_reset control was getting remapped to cold_reset first and then to ccd_cr50.cold_reset when the ccd_cr50 config was added. The prefix should be used in the remap control name, so ccd_cr50 controls get mapped to ccd_cr50 controls and so the standard controls don't get remapped. BUG=b:159338538 TEST=manual dut-control -i shows ccd_cr50.warm_reset control_name is ccd_cr50.cold_reset. warm_reset control_name is cold_reset. Verify ccd_cr50.warm_reset controls ccd_cr50.cold_reset and warm_reset controls cold_reset. dut-control cold_reset ccd_cr50.cold_reset ccd_cr50.cold_reset:off cold_reset:off dut-control warm_reset:on dut-control cold_reset ccd_cr50.cold_reset ccd_cr50.cold_reset:off cold_reset:on dut-control warm_reset:off dut-control cold_reset ccd_cr50.cold_reset ccd_cr50.cold_reset:off cold_reset:off dut-control ccd_cr50.warm_reset:on dut-control cold_reset ccd_cr50.cold_reset ccd_cr50.cold_reset:on cold_reset:on dut-control ccd_cr50.warm_reset:off dut-control cold_reset ccd_cr50.cold_reset ccd_cr50.cold_reset:off cold_reset:off Change-Id: I2e507edc2557f4020fafe03307837cfc07ca6fea Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/hdctools/+/2347132 Tested-by: Mary Ruthven <mruthven@chromium.org> Reviewed-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org> Commit-Queue: Mary Ruthven <mruthven@chromium.org>
-
Sam Hurst authored
Google is working to change its source code to use more inclusive language. To that end, replace the term "dummy" with inclusive alternatives. BUG=b:162896016 TEST=`cd src/third_party/hdctools && grep -ir dummy *` No occurrences of dummy. Change-Id: If53654e6a0e8e04e5eca29e91b11b59f02832c1b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/hdctools/+/2339611 Tested-by: Sam Hurst <shurst@google.com> Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-by: Tom Hughes <tomhughes@chromium.org> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Sam Hurst <shurst@google.com>
-
Nicolas Norvez authored
The target has been moved to a different branch, update the link. BUG=None TEST=view in gitiles Change-Id: I2b72d89bf0ccedbe8bc2903942fe9eba9871f8f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/hdctools/+/2354677 Tested-by: Nicolas Norvez <norvez@chromium.org> Auto-Submit: Nicolas Norvez <norvez@chromium.org> Commit-Queue: Mary Ruthven <mruthven@chromium.org> Reviewed-by: Mary Ruthven <mruthven@chromium.org>
-
- Aug 12, 2020
-
-
yangzejin authored
Adding rev0 INA rail map for fennel BUG=b:162485232 TEST=sudo emerage hdctools Change-Id: I31c01e306ea43cf621cd20f69bf8a61b9eb22f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/hdctools/+/2341269 Reviewed-by: Hash.Hung <hongzhaoyou@huaqin.corp-partner.google.com> Reviewed-by: Zhuohao Lee <zhuohao@chromium.org> Tested-by: Zejin Yang <yangzejin@huaqin.corp-partner.google.com> Commit-Queue: Zejin Yang <yangzejin@huaqin.corp-partner.google.com> Commit-Queue: Li-jen Chen <lijen@google.com>
-
- Aug 11, 2020
-
-
yangzejin authored
Adding rev0 INA rail map for cerise and stern. BUG=b:162397491 TEST=sudo emerge hdctools Change-Id: I387b99148b7599c0286fdef39cfbed3d1e2fc486 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/hdctools/+/2327777 Reviewed-by: Hash.Hung <hongzhaoyou@huaqin.corp-partner.google.com> Reviewed-by: Zhuohao Lee <zhuohao@chromium.org> Tested-by: Zejin Yang <yangzejin@huaqin.corp-partner.google.com> Commit-Queue: Zejin Yang <yangzejin@huaqin.corp-partner.google.com> Commit-Queue: Li-jen Chen <lijen@google.com>
-
- Aug 07, 2020
-
-
Peichao Wang authored
BUG=b:153459677 TEST=run 'dut-power --ina-rate .1' on host Change-Id: Ie0322164e0a10c6bdac89b40d80dcb99569fac02 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/hdctools/+/2143078 Reviewed-by: Pranay Shoroff <pshoroff@google.com> Reviewed-by: Eric Peers <epeers@google.com> Tested-by: Eric Peers <epeers@google.com> Commit-Queue: Todd Broch <tbroch@chromium.org>
-
- Aug 05, 2020
-
-
Ruben Rodriguez Buchillon authored
This is the first draft of how the overlay has to look. It's just copied and then edited. A future revision will handle pulling out common things. BUG=b:154436412 TEST=sudo servod dut-control image_usbkey_pwr aux_usbkey_pwr aux_usbkey_pwr:on image_usbkey_pwr:on Change-Id: I0c6c4bff2f30517a44b18fc4db18e34da69e71cd Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/hdctools/+/2337443 Reviewed-by: Brian Nemec <bnemec@chromium.org> Commit-Queue: Ruben Rodriguez Buchillon <coconutruben@chromium.org> Tested-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
-
- Jul 31, 2020
-
-
Matthias Kaehlcke authored
The configuration is based on the trogdor r1 and includes some additional rails. BUG=none TEST=measure power on lazor r1 with sweetberry Change-Id: If672147c068b15a42646e1de66e21d9e859622f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/hdctools/+/2330790 Tested-by: Matthias Kaehlcke <mka@chromium.org> Reviewed-by: Matthias Kaehlcke <mka@chromium.org> Commit-Queue: Matthias Kaehlcke <mka@chromium.org>
-
- Jul 17, 2020
-
-
Matthias Kaehlcke authored
Add medusa configuration for trogdor rev1 BUG=b:157666809 TEST=use sweetberry to measure power on trogdor rev1 Change-Id: I2271aedd028b240c8d0662ba4d373b7ed36bd3f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/hdctools/+/2276750 Tested-by: Matthias Kaehlcke <mka@chromium.org> Reviewed-by: Matthias Kaehlcke <mka@chromium.org> Commit-Queue: Matthias Kaehlcke <mka@chromium.org>
-
- Jul 15, 2020
-
-
Ayo Wu authored
The strapping pin to trigger usb download mode is routed to servo header dev_mode pin. dut-control ap_download_mode:on followed by a cold_reset makes the AP discoverable by vendor's flash_tool with reworked usb path. BUG=none TEST=manual test on asurada proto reworked for usb path TEST=dut-control ap_download_mode:on TEST=dut-control cold_reset:on cold_reset:off // flash_tool works Change-Id: Icf95a9bda69ecf7b5a3b2e43c9ff74fa23ffcebb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/hdctools/+/2181853 Reviewed-by: Eric Yilun Lin <yllin@chromium.org> Tested-by: Ayo Wu <ayowu@google.com> Commit-Queue: Ayo Wu <ayowu@google.com>
-
Fei Shao authored
Referencing from CL:2230059. BUG=b:160764560 TEST=None Change-Id: I5ad6c2e05fa1c04c98a97174f696a0dd18cdd036 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/hdctools/+/2291584 Reviewed-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org> Tested-by: Fei Shao <fshao@chromium.org> Commit-Queue: Ayo Wu <ayowu@google.com>
-
- Jul 11, 2020
-
-
Mary Ruthven authored
BUG=none TEST=manual dut-control active_v4_device active_v4_device:servo_micro dut-control active_v4_device:ccd_cr50 active_v4_device active_v4_device:ccd_cr50 dut-control ec_board Problem with ['ec_board'] :: EC: No data was sent from the pty. dut-control ccd_cr50.ec_board ccd_cr50.ec_board:helios dut-control ec_uart_en:on active_v4_device active_v4_device:neither dut-control ccd_cr50.ec_board Problem with ['ccd_cr50.ec_board'] :: EC: No data was sent from the pty. dut-control active_v4_device:servo_micro active_v4_device active_v4_device:servo_micro dut-control ccd_cr50.ec_board Problem with ['ccd_cr50.ec_board'] :: EC: No data was sent from the pty. dut-control ec_board ec_board:helios Change-Id: Iea726712f7a56f97cde65289fa078a693b0d193b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/hdctools/+/2292749 Reviewed-by: Dana Goyette <dgoyette@chromium.org> Tested-by: Mary Ruthven <mruthven@chromium.org>
-
- Jul 01, 2020
-
-
Hung-Te Lin authored
Reference: CL:2044361 BUG=None TEST=sudo emerge hdctools Change-Id: I07e515db91d9b40c8cf00c2cf5a42dd3a27cb339 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/hdctools/+/2228929 Tested-by: Hung-Te Lin <hungte@chromium.org> Commit-Queue: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Auto-Submit: Hung-Te Lin <hungte@chromium.org>
-
- Jun 30, 2020
-
-
Mary Ruthven authored
Right now the active_v4_device check fails when the EC and AP are off. active_v4_device checks EC and AP uart to determine if ccd is active. However, cr50 will disable uart when the EC or AP are off. This means UARTAP and UARTEC won't be in the ccdstate output even though ccd is active. If you try to get active_v4_device in this state, it'll return 'neither'. EC-EFS2 systems only check APUART, so it'll fail whenever the AP is off. This change adds a SPI check to _using_ccd, becaus SPI is always active when ccd is open and connected. It is not dependent on the rest of the system state. BUG=b:158338993 TEST=dut-control active_v4_device Change-Id: I550175e9355e6f0a84188f4d3d89f7ea50446299 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/hdctools/+/2274059 Tested-by: Mary Ruthven <mruthven@chromium.org> Reviewed-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org> Commit-Queue: Mary Ruthven <mruthven@chromium.org>
-
- Jun 27, 2020
-
-
Ruben Rodriguez Buchillon authored
The tests and error messages we run inside device.py should suffice to report what's going on. This change removes the stderr output from uhubctl BUG=b:153029284 // on a hub without support TEST=servodtool device -s C1706311039 power-cycle hub 1-1.5.4 with port 4 unknown to uhubctl. Be sure the hub is a supported smart hub. Command '['sudo', 'uhubctl', '-l', '1-1.5.4', '-p', '4']' returned non-zero exit status 1 // on a hub with support TEST=servodtool device -s C1706310253 power-cycle Successfully power-cycled device with serial 'C1706310253'. (At least reasonably confident). // renaming the control to uhubctl2 so that checking its availability // fails TEST=servodtool device -s C1706310253 power-cycle uhubctl not available. Be sure to run as sudo. Command '['sudo', 'uhubctl2']' returned non-zero exit status 1 Change-Id: I2c1b5b7a94d4a5b746906ab02a89c3b13c4e8d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/hdctools/+/2203417 Reviewed-by: Garry Wang <xianuowang@chromium.org> Tested-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org> Commit-Queue: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
-
Ruben Rodriguez Buchillon authored
a method call for getting the usb stick's /dev path now raises an error if the ports on the internal hub where a usb stick can be found are not provided in the xml overlay. This change adds the proper documentation for that. BUG=None TEST=pylint Change-Id: I1d46ae3b3ff37bb1b941791635865e6ba9a41844 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/hdctools/+/2247231 Reviewed-by: Garry Wang <xianuowang@chromium.org> Tested-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org> Commit-Queue: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
-
Ruben Rodriguez Buchillon authored
A recent change removed a variable and not all its references. One error path still referenced the old variable. This addresses that issue. BUG=None TEST=pylint Change-Id: I3018e8a4faf1baa38bcbcdcde87afe0a4f9b91e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/hdctools/+/2247230 Reviewed-by: Garry Wang <xianuowang@chromium.org> Tested-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org> Commit-Queue: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
-
- Jun 25, 2020
-
-
Sam McNally authored
Borrow the custom cpu_fw_spi implementation from hatch. BUG=None TEST=dut-control cpu_fw_spi:on sets spi2_vref:pp3300 Change-Id: I63f55e744d762dc79bb34be6a6d36cea8a531fb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/hdctools/+/2265533 Commit-Queue: Sam McNally <sammc@chromium.org> Commit-Queue: Edward O'Callaghan <quasisec@chromium.org> Tested-by: Sam McNally <sammc@chromium.org> Auto-Submit: Sam McNally <sammc@chromium.org> Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
-
- Jun 24, 2020
-
-
Justin TerAvest authored
This renames the common dedede servo configuration so that "servo_dedede_overlay.xml" can be used in lab configurations to provide a default servo configuration for Dedede devices with an ITE EC. Dedede devices with NPCX ECs will require a separate xml file per-model so they may be looked up. BUG=b:157911908 TEST=sudo servod -b waddledoo Change-Id: I97af02230f44b0d496429f6043d954a89923c1d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/hdctools/+/2261126 Reviewed-by: Evan Green <evgreen@chromium.org> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Tested-by: Justin TerAvest <teravest@chromium.org>
-
Hung-Te Lin authored
zork devices need a special control 'servo_present' when flashing AP. Reference: CL:2044361 BUG=None TEST=sudo emerge hdctools Change-Id: Ic850ec839eb01954088e37f3cb5255841f9b2552 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/hdctools/+/2228927 Reviewed-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org> Commit-Queue: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Auto-Submit: Hung-Te Lin <hungte@chromium.org>
-
Hung-Te Lin authored
Reference: CL:2019569 BUG=None TEST=sudo emerge hdctools Change-Id: Ib6833ed3245d511f9fc6e62b9b18b68a903044f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/hdctools/+/2228930 Tested-by: Hung-Te Lin <hungte@chromium.org> Commit-Queue: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Auto-Submit: Hung-Te Lin <hungte@chromium.org>
-