Skip to content
Snippets Groups Projects
Commit e9ae4d4f authored by Dan Carpenter's avatar Dan Carpenter Committed by Mauro Carvalho Chehab
Browse files

[media] tlg2300: fix up check_firmware() return


The caller doesn't check the return value of check_firmware() but static
checkers complain.  It currently returns negative error codes, or zero
or greater on success but since the return type is boolean the values
are truncated to one or zero.  I've changed it to return an int,
negative on error and zero on success.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 0397e450
No related branches found
No related tags found
No related merge requests found
...@@ -374,7 +374,7 @@ static inline void set_map_flags(struct poseidon *pd, struct usb_device *udev) ...@@ -374,7 +374,7 @@ static inline void set_map_flags(struct poseidon *pd, struct usb_device *udev)
} }
#endif #endif
static bool check_firmware(struct usb_device *udev, int *down_firmware) static int check_firmware(struct usb_device *udev, int *down_firmware)
{ {
void *buf; void *buf;
int ret; int ret;
...@@ -398,7 +398,7 @@ static bool check_firmware(struct usb_device *udev, int *down_firmware) ...@@ -398,7 +398,7 @@ static bool check_firmware(struct usb_device *udev, int *down_firmware)
*down_firmware = 1; *down_firmware = 1;
return firmware_download(udev); return firmware_download(udev);
} }
return ret; return 0;
} }
static int poseidon_probe(struct usb_interface *interface, static int poseidon_probe(struct usb_interface *interface,
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment