Skip to content
Snippets Groups Projects
Commit bced7cce authored by Kumar Gala's avatar Kumar Gala Committed by Wolfgang Denk
Browse files

ppc: Fix roll over bug in flush_cache()


If we call flush_cache(0xfffff000, 0x1000) it would never
terminate the loop since end = 0xffffffff and we'd roll over
our counter from 0xfffffe0 to 0 (assuming a 32-byte cache line)

Signed-off-by: default avatarKumar Gala <galak@kernel.crashing.org>
parent 87c90639
No related branches found
No related tags found
No related merge requests found
...@@ -33,14 +33,16 @@ void flush_cache(ulong start_addr, ulong size) ...@@ -33,14 +33,16 @@ void flush_cache(ulong start_addr, ulong size)
start = start_addr & ~(CONFIG_SYS_CACHELINE_SIZE - 1); start = start_addr & ~(CONFIG_SYS_CACHELINE_SIZE - 1);
end = start_addr + size - 1; end = start_addr + size - 1;
for (addr = start; addr <= end; addr += CONFIG_SYS_CACHELINE_SIZE) { for (addr = start; (addr <= end) && (addr >= start);
addr += CONFIG_SYS_CACHELINE_SIZE) {
asm volatile("dcbst 0,%0" : : "r" (addr) : "memory"); asm volatile("dcbst 0,%0" : : "r" (addr) : "memory");
WATCHDOG_RESET(); WATCHDOG_RESET();
} }
/* wait for all dcbst to complete on bus */ /* wait for all dcbst to complete on bus */
asm volatile("sync" : : : "memory"); asm volatile("sync" : : : "memory");
for (addr = start; addr <= end; addr += CONFIG_SYS_CACHELINE_SIZE) { for (addr = start; (addr <= end) && (addr >= start);
addr += CONFIG_SYS_CACHELINE_SIZE) {
asm volatile("icbi 0,%0" : : "r" (addr) : "memory"); asm volatile("icbi 0,%0" : : "r" (addr) : "memory");
WATCHDOG_RESET(); WATCHDOG_RESET();
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment