Skip to content
Snippets Groups Projects
Commit c8876f1c authored by Holger Hans Peter Freyther's avatar Holger Hans Peter Freyther Committed by Tom Rini
Browse files

mac: Fix the condition check for setting the MAC from the EEPROM


The issue got introduced in a cleanup by Manjunath Hadli in commit
826e9913. The eth_getenv_enetaddr_by_index
method will validate the MAC addr and if none is set in the environment
0 will be returned. Set the MAC from the eeprom if no valid address
is found in environment.

Signed-off-by: default avatarHolger Hans Peter Freyther <holger@freyther.de>
parent 4f47aceb
No related branches found
No related tags found
No related merge requests found
......@@ -104,7 +104,7 @@ void davinci_sync_env_enetaddr(uint8_t *rom_enetaddr)
int ret;
ret = eth_getenv_enetaddr_by_index("eth", 0, env_enetaddr);
if (ret) {
if (!ret) {
/*
* There is no MAC address in the environment, so we
* initialize it from the value in the EEPROM.
......@@ -115,7 +115,7 @@ void davinci_sync_env_enetaddr(uint8_t *rom_enetaddr)
ret = !eth_setenv_enetaddr("ethaddr", rom_enetaddr);
}
if (!ret)
printf("Failed to set mac address from EEPROM\n");
printf("Failed to set mac address from EEPROM: %d\n", ret);
}
#endif /* CONFIG_DRIVER_TI_EMAC */
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment