Skip to content
  • Tim-Philipp Müller's avatar
    flacparse: set both pts and dts so baseparse doesn't make up wrong dts after a seek · 0d88f271
    Tim-Philipp Müller authored
    flac contains the sample offset in the frame header, so after a seek
    without index flacparse will know the exact position we landed on and
    timestamp buffers accordingly. It only set the pts though, which means
    the baseparse-set dts which was set to the seek position prevails, and
    since the seek was based on an estimate, there's likely a discrepancy
    between where we wanted to land and where we did land, so from here on
    that dts/pts difference will be maintained, with dts possibly multiple
    seconds ahead of pts, which is just wrong. The easiest way to fix this
    is to just set both pts and dts based on the sample offset, but perhaps
    parsed audio should just not have dts set at all.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=752106
    0d88f271