Skip to content
  • Paul Gortmaker's avatar
    x86/percpu: Remove unnecessary include of module.h, add asm/desc.h · 523d0fb4
    Paul Gortmaker authored
    This was originally a part of commit 186f4360
    
    :
    
        ("x86/kernel: Audit and remove any unnecessary uses of module.h")
    
    ...but without the asm/desc.h addition.  As such, Ingo reported a
    build failure on i386 allnoconfig with SMP=y during his pre-merge
    testing.   For expediency the chunk was just dropped at that time.
    
    The failure was as follows:
    
      arch/x86/kernel/setup_percpu.c: In function ‘setup_percpu_segment’:
      arch/x86/kernel/setup_percpu.c:159:2: error: implicit declaration of function ‘pack_descriptor’ [-Werror=implicit-function-declaration]
      arch/x86/kernel/setup_percpu.c:162:2: error: implicit declaration of function ‘write_gdt_entry’ [-Werror=implicit-function-declaration]
      arch/x86/kernel/setup_percpu.c:162:18: error: implicit declaration of function ‘get_cpu_gdt_table’ [-Werror=implicit-function-declaration]
    
    As pack_descriptor(), write_gdt_entry() and get_cpu_gdt_table() all
    live in the file arch/x86/include/asm/desc.h -- calling that header
    out explicitly should fix things.
    
    Reported-by: default avatarIngo Molnar <mingo@redhat.com>
    Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Link: http://lkml.kernel.org/r/20161114190443.10873-1-paul.gortmaker@windriver.com
    
    
    Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
    523d0fb4