Skip to content
  • Michael Ellerman's avatar
    powerpc/spufs: Fix coredump of SPU contexts · 99acc9be
    Michael Ellerman authored
    If a process dumps core while it has SPU contexts active then we have
    code to also dump information about the SPU contexts.
    
    Unfortunately it's been broken for 3 1/2 years, and we didn't notice. In
    commit 7b1f4020 ("spufs: get rid of dump_emit() wrappers") the nread
    variable was removed and rc used instead. That means when the loop exits
    successfully, rc has the number of bytes read, but it's then used as the
    return value for the function, which should return 0 on success.
    
    So fix it by setting rc = 0 before returning in the success case.
    
    Fixes: 7b1f4020
    
     ("spufs: get rid of dump_emit() wrappers")
    Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    Acked-by: default avatarJeremy Kerr <jk@ozlabs.org>
    Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    99acc9be