Skip to content
  • Josh Poimboeuf's avatar
    objtool: Improve rare switch jump table pattern detection · 3732710f
    Josh Poimboeuf authored
    
    
    GCC 6 added a new switch statement jump table optimization which makes
    objtool's life harder.  It looks like:
    
      mov [rodata addr],%reg1
      ... some instructions ...
      jmpq *(%reg1,%reg2,8)
    
    The optimization is quite rare, but objtool still needs to be able to
    identify the pattern so that it can follow all possible control flow
    paths related to the switch statement.
    
    In order to detect the pattern, objtool starts from the indirect jump
    and scans backwards through the function until it finds the first
    instruction in the pattern.  If it encounters an unconditional jump
    along the way, it stops and considers the pattern to be not found.
    
    As it turns out, unconditional jumps can happen, as long as they are
    small forward jumps within the range being scanned.
    
    This fixes the following warnings:
    
      drivers/infiniband/sw/rxe/rxe_comp.o: warning: objtool: rxe_completer()+0x2f4: sibling call from callable instruction with changed frame pointer
      drivers/infiniband/sw/rxe/rxe_resp.o: warning: objtool: rxe_responder()+0x10f: sibling call from callable instruction with changed frame pointer
    
    Reported-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarJosh Poimboeuf <jpoimboe@redhat.com>
    Cc: Andy Lutomirski <luto@kernel.org>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Brian Gerst <brgerst@gmail.com>
    Cc: Denys Vlasenko <dvlasenk@redhat.com>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Link: http://lkml.kernel.org/r/8a9ed68ae1780e8d3963e4ee13f2f257fe3a3c33.1476393584.git.jpoimboe@redhat.com
    
    
    Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
    3732710f