• Linus Torvalds's avatar
    vfs: clean up posix_acl_permission() logic aroudn MAY_NOT_BLOCK · 63d72b93
    Linus Torvalds authored
    posix_acl_permission() does not care about MAY_NOT_BLOCK, and in fact
    the permission logic internally must not check that bit (it's only for
    upper layers to decide whether they can block to do IO to look up the
    acl information or not).
    But the way the code was written, it _looked_ like it cared, since the
    function explicitly did not mask that bit off.
    But it has exactly two callers: one for when that bit is set, which
    first clears the bit before calling posix_acl_permission(), and the
    other call site when that bit was clear.
    So stop the silly games "saving" the MAY_NOT_BLOCK bit that must not be
    used for the actual permission test, and that currently is pointlessly
    cleared by the callers when the function itself should just not care.
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>