Skip to content
Snippets Groups Projects
Commit 821090a2 authored by Sebastian Reichel's avatar Sebastian Reichel Committed by Sebastian Reichel
Browse files

usb: typec: tcpm: Improve error printing during probe


It's currently quite hard to understand why a tcpm controller
probe might run into probe defer. Let's improve that by adding
some error messages.

Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
parent 089fc90f
No related branches found
No related tags found
No related merge requests found
Pipeline #134171 passed
......@@ -7769,23 +7769,29 @@ struct tcpm_port *tcpm_register_port(struct device *dev, struct tcpc_dev *tcpc)
port->role_sw = fwnode_usb_role_switch_get(tcpc->fwnode);
if (IS_ERR(port->role_sw)) {
err = PTR_ERR(port->role_sw);
dev_err_probe(dev, err, "Failed to get USB role switch\n");
goto out_destroy_wq;
}
err = devm_tcpm_psy_register(port);
if (err)
if (err) {
dev_err_probe(dev, err, "Failed to register power-supply device\n");
goto out_role_sw_put;
}
power_supply_changed(port->psy);
err = tcpm_port_register_pd(port);
if (err)
if (err) {
dev_err_probe(dev, err, "Failed to register power-delivery\n");
goto out_role_sw_put;
}
if (port->pds)
port->typec_caps.pd = port->pds[0];
port->typec_port = typec_register_port(port->dev, &port->typec_caps);
if (IS_ERR(port->typec_port)) {
dev_err_probe(dev, err, "Failed to register Type-C port\n");
err = PTR_ERR(port->typec_port);
goto out_unregister_pd;
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment