Skip to content
Snippets Groups Projects
  1. Jan 19, 2025
    • Matthieu Baerts (NGI0)'s avatar
      mptcp: sysctl: add syn_retrans_before_tcp_fallback · 5b4fd353
      Matthieu Baerts (NGI0) authored
      
      The number of SYN + MPC retransmissions before falling back to TCP was
      fixed to 2. This is certainly a good default value, but having a fixed
      number can be a problem in some environments.
      
      The current behaviour means that if all packets are dropped, there will
      be:
      
      - The initial SYN + MPC
      
      - 2 retransmissions with MPC
      
      - The next ones will be without MPTCP.
      
      So typically ~3 seconds before falling back to TCP. In some networks
      where some temporally blackholes are unfortunately frequent, or when a
      client tries to initiate connections while the network is not ready yet,
      this can cause new connections not to have MPTCP connections.
      
      In such environments, it is now possible to increase the number of SYN
      retransmissions with MPTCP options to make sure MPTCP is used.
      
      Interesting values are:
      
      - 0: the first retransmission will be done without MPTCP options: quite
           aggressive, but also a higher risk of detecting false-positive
           MPTCP blackholes.
      
      - >= 128: all SYN retransmissions will keep the MPTCP options: back to
                the < 6.12 behaviour.
      
      The default behaviour is not changed here.
      
      Reviewed-by: default avatarMat Martineau <martineau@kernel.org>
      Signed-off-by: default avatarMatthieu Baerts (NGI0) <matttbe@kernel.org>
      Link: https://patch.msgid.link/20250117-net-next-mptcp-syn_retrans_before_tcp_fallback-v1-1-ab4b187099b0@kernel.org
      
      
      Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      5b4fd353
  2. Jan 18, 2025
    • Vladimir Oltean's avatar
      net: ethtool: ts: add separate counter for unconfirmed one-step TX timestamps · 6a128cdf
      Vladimir Oltean authored
      
      For packets with two-step timestamp requests, the hardware timestamp
      comes back to the driver through a confirmation mechanism of sorts,
      which allows the driver to confidently bump the successful "pkts"
      counter.
      
      For one-step PTP, the NIC is supposed to autonomously insert its
      hardware TX timestamp in the packet headers while simultaneously
      transmitting it. There may be a confirmation that this was done
      successfully, or there may not.
      
      None of the current drivers which implement ethtool_ops :: get_ts_stats()
      also support HWTSTAMP_TX_ONESTEP_SYNC or HWTSTAMP_TX_ONESTEP_SYNC, so it
      is a bit unclear which model to follow. But there are NICs, such as DSA,
      where there is no transmit confirmation at all. Here, it would be wrong /
      misleading to increment the successful "pkts" counter, because one-step
      PTP packets can be dropped on TX just like any other packets.
      
      So introduce a special counter which signifies "yes, an attempt was made,
      but we don't know whether it also exited the port or not". I expect that
      for one-step PTP packets where a confirmation is available, the "pkts"
      counter would be bumped.
      
      Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
      Reviewed-by: default avatarJakub Kicinski <kuba@kernel.org>
      Link: https://patch.msgid.link/20250116104628.123555-2-vladimir.oltean@nxp.com
      
      
      Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      6a128cdf
  3. Jan 17, 2025
  4. Jan 16, 2025
  5. Jan 15, 2025
  6. Jan 14, 2025
  7. Jan 13, 2025
  8. Jan 11, 2025
  9. Jan 10, 2025
  10. Jan 09, 2025
Loading