- Apr 24, 2023
-
-
Add DT node to enable RTC support on RK3588 board. Signed-off-by:
Shreeya Patel <shreeya.patel@collabora.com>
-
Add rockchip,rk3588-wdt compatible string. Signed-off-by:
Shreeya Patel <shreeya.patel@collabora.com>
-
Add DT node for watchdog support in RK3588. Signed-off-by:
Shreeya Patel <shreeya.patel@collabora.com>
-
Signed-off-by:
Lucas Tanure <lucas.tanure@collabora.com> Change-Id: I669a1f4509dd4ac452bc64556b67b7de256fc5fb
-
Signed-off-by:
Lucas Tanure <lucas.tanure@collabora.com> Change-Id: Ic4711d33140dbb4bb7c6a67306dab1c12dc6802d
-
Enable PCIE2.0x1 @fe190000 for RTL8125 network controller in Rock 5B board. This is based on prior work from XiaoDong Huang and Peter Geis fixing this issue specifically for Rockchip 356x. Signed-off-by:
Lucas Tanure <lucas.tanure@collabora.com> Change-Id: Ib01a1a49234167932ea89c8ac5f830e4385ecf75
-
Add the necessary DT nodes for the Rock 5B board to enable the analog audio support provided by the Everest Semi ES8316 codec. Signed-off-by:
Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
-
In addition to the five I2S/PCM/TDM controllers and the two I2S/PCM controllers shared between the RK3588 and RK3588S SoCs, RK3588 contains another four I2S/PCM/TDM controllers. Add the DT nodes corresponding to the additional controllers. Signed-off-by:
Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
-
There are five I2S/PCM/TDM controllers and two I2S/PCM controllers embedded in the RK3588 and RK3588S SoCs. Add the DT nodes corresponding to the above mentioned Rockchip controllers. Also note RK3588 SoC contains four additional I2S/PCM/TDM controllers, which are handled via a separate patch. Signed-off-by:
Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
-
The Rockchip I2S driver supports the RK3588/RK3588S SoCs, hence add the corresponding compatible string. Signed-off-by:
Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
-
Add new compatible string for the Rockchip I2S/PCM controller found on RK3588 and RK3588S SoCs. Signed-off-by:
Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
-
The binding document is missing the power-domains property. Add it. Signed-off-by:
Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
-
Document the 'port' property to allow the Rockchip I2S TDM controller to be used in conjunction with the audio-graph-card. The property will be used to provide an endpoint for binding to the other side of the audio link. Signed-off-by:
Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
-
The Rockchip I2S controller is currently used in conjunction with audio-graph-card to provide an endpoint for binding with the other side of the audio link. This is achieved via the 'port' property, which is not allowed: rk3399-rockpro64.dtb: i2s@ff890000: Unevaluated properties are not allowed ('port' was unexpected) Fix the issue by documenting the missing property. Signed-off-by:
Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
-
The ES8316 codec is currently used in conjunction with audio-graph-card to provide an endpoint for binding with the other side of the audio link. This is achieved via the 'port' property, which is not allowed: rk3399-rockpro64.dtb: codec@11: Unevaluated properties are not allowed ('port' was unexpected) Fix the issue by documenting the missing property. Signed-off-by:
Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
-
Since commit df4fdd0d ("dt-bindings: firmware: arm,scmi: Restrict protocol child node properties") the following dtbs_check warning is shown: rk3588-rock-5b.dtb: scmi: protocol@14: Unevaluated properties are not allowed ('assigned-clock-rates', 'assigned-clocks' were unexpected) Add the missing properties. Signed-off-by:
Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
-
Commit 370f696e ("dt-bindings: serial: snps-dw-apb-uart: add dma & dma-names properties") documented dma-names property to handle Allwiner D1 dtbs_check warnings, but relies on a strict rx->tx ordering, which is the reverse of what a different board expects: rk3326-odroid-go2.dtb: serial@ff030000: dma-names:0: 'rx' was expected A quick and incomplete check shows the inconsistency is present in many other DT files: $ git grep -A10 snps,dw-apb-uart | grep dma-names | sort -u arch/arm64/boot/dts/rockchip/px30.dtsi- dma-names = "tx", "rx"; arch/arm64/boot/dts/rockchip/rk3328.dtsi- dma-names = "tx", "rx"; arch/arm64/boot/dts/rockchip/rk3588s.dtsi- dma-names = "tx", "rx"; arch/arm/boot/dts/rk3066a.dtsi- dma-names = "tx", "rx"; arch/arm/boot/dts/rk3128.dtsi- dma-names = "tx", "rx"; arch/arm/boot/dts/rk3288.dtsi- dma-names = "tx", "rx"; arch/arm/boot/dts/rv1126.dtsi- dma-names = "tx", "rx"; arch/arm/boot/dts/socfpga.dtsi- dma-names = "tx", "rx"; arch/arm/boot/dts/sun6i-a31.dtsi- dma-names = "rx", "tx"; arch/arm/boot/dts/sun8i-a23-a33.dtsi- dma-names = "rx", "tx"; arch/arm/boot/dts/sun8i-v3s.dtsi- dma-names = "rx", "tx"; arch/arm/boot/dts/sunxi-h3-h5.dtsi- dma-names = "rx", "tx"; arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi- dma-names = "rx", "tx"; Do not enforce the order of the dma-names items. Signed-off-by:
Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
-
Add sdmmc node and it's regulators for sd card support Signed-off-by:
Lucas Tanure <lucas.tanure@collabora.com> Signed-off-by:
Sebastian Reichel <sebastian.reichel@collabora.com>
-
Add sdmmc support for Rock Pi 5A board. Signed-off-by:
Lucas Tanure <lucas.tanure@collabora.com> Signed-off-by:
Sebastian Reichel <sebastian.reichel@collabora.com>
-
Add support for rk806 single configuration PMIC in Rock Pi 5A and 5B. Signed-off-by:
Lucas Tanure <lucas.tanure@collabora.com> Signed-off-by:
Sebastian Reichel <sebastian.reichel@collabora.com>
-
Add SD Card node for RK3588s and RK3588. Co-developed-by:
Shawn Lin <shawn.lin@rock-chips.com> Signed-off-by:
Shawn Lin <shawn.lin@rock-chips.com> Signed-off-by:
Lucas Tanure <lucas.tanure@collabora.com> Link: https://lore.kernel.org/r/20230228103610.25108-1-lucas.tanure@collabora.com Signed-off-by:
Heiko Stuebner <heiko@sntech.de> Signed-off-by:
Sebastian Reichel <sebastian.reichel@collabora.com>
-
The PCIe 2.0 controllers on RK3588 need one additional clock, one additional reset line and one for ranges entry. Signed-off-by:
Sebastian Reichel <sebastian.reichel@collabora.com>
-
Rockchip RK356x and RK3588 handle legacy interrupts via a ganged interrupts. The RK356x DT implements this via a sub-node named "legacy-interrupt-controller", just like a couple of other PCIe implementations. This adds proper documentation for this and updates the example to avoid regressions. Signed-off-by:
Sebastian Reichel <sebastian.reichel@collabora.com>
-
The RK356x (and RK3588) have 5 ganged interrupts. For example the "legacy" interrupt combines "inta/intb/intc/intd" with a register providing the details. Currently the binding is not specifying these interrupts resulting in a bunch of errors for all rk356x boards using PCIe. Fix this by specifying the interrupts and add them to the example to prevent regressions. Signed-off-by:
Sebastian Reichel <sebastian.reichel@collabora.com>
-
PCIe for RK3588 is the same as RK3568. Signed-off-by:
Lucas Tanure <lucas.tanure@collabora.com> Reviewed-by:
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://lore.kernel.org/r/20230314135555.44162-2-lucas.tanure@collabora.com Signed-off-by:
Vinod Koul <vkoul@kernel.org>
-
The RK3588 EVB1 has a second network card, which is connected via a PCIe2 block. This adds support for that. The patch also enables the first PCIe2 block. I did not test its functionality, but the board boots up properly. Signed-off-by:
Sebastian Reichel <sebastian.reichel@collabora.com>
-
Add all three PCIe2 IP blocks to the RK3588 DT. Note, that RK3588 also has two PCIe3 IP blocks, that will be handled separately. TODO: FIXME: this is not compliant with the DT binding. There is one additional clock ("pipe"), one additional reset line, the interrupt-names do not match Signed-off-by:
Kever Yang <kever.yang@rock-chips.com> Co-developed-by:
Kever Yang <kever.yang@rock-chips.com> Signed-off-by:
Sebastian Reichel <sebastian.reichel@collabora.com>
-
Add the two Interrupt Translation Service (ITS) IPs that are part of the GIC-600. They are mainly required for PCIe Message Signalled Interrupts (MSI). Co-developed-by:
Kever Yang <kever.yang@rock-chips.com> Signed-off-by:
Kever Yang <kever.yang@rock-chips.com> Signed-off-by:
Sebastian Reichel <sebastian.reichel@collabora.com>
-
Rockchip RK3588/RK3588s GIC600 integration does not support the sharability feature. Rockchip assigned Erratum ID #3588001 for this issue. Note, that the 0x0201743b ID is not Rockchip specific and thus there is an extra of_machine_is_compatible() check. The flags are named FORCE_NON_SHAREABLE to be vendor agnostic, since apparently similar integration design errors exist in other platforms and they can reuse the same flag. Co-developed-by:
XiaoDong Huang <derrick.huang@rock-chips.com> Signed-off-by:
XiaoDong Huang <derrick.huang@rock-chips.com> Co-developed-by:
Kever Yang <kever.yang@rock-chips.com> Signed-off-by:
Kever Yang <kever.yang@rock-chips.com> Co-developed-by:
Lucas Tanure <lucas.tanure@collabora.com> Signed-off-by:
Lucas Tanure <lucas.tanure@collabora.com> Reviewed-by:
AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Signed-off-by:
Sebastian Reichel <sebastian.reichel@collabora.com>
-
Add support for the SATA0_0 port found on the RK3588 EVB1. The second port (SATA0_1) does not work, which matches the downstream behaviour. Signed-off-by:
Sebastian Reichel <sebastian.reichel@collabora.com>
-
Add all three SATA IP blocks to the RK3588 DT. Signed-off-by:
Sebastian Reichel <sebastian.reichel@collabora.com>
-
Add all 3 combo PHYs that can be found in RK3588. They are used for SATA, PCIe or USB3. Signed-off-by:
Sebastian Reichel <sebastian.reichel@collabora.com>
-
The RK3588 has two reset lines for the combphy. One for the APB interface and one for the actual PHY. Signed-off-by:
Sebastian Reichel <sebastian.reichel@collabora.com>
-
Just like RK3568, the RK3588 has a DWC based AHCI controller. Signed-off-by:
Sebastian Reichel <sebastian.reichel@collabora.com>
-
The pipe-phy syscon is used by rockchip,rk3588-naneng-combphy, which in turn is the PHY for USB3, PCIe and SATA. Acked-by:
Rob Herring <robh@kernel.org> Signed-off-by:
Sebastian Reichel <sebastian.reichel@collabora.com>
-
Add support for RK3588 combo phy This is based on prior work from XiaoDong Huang and Peter Geis fixing this issue specifically for Rockchip 356x. Co-developed-by:
Andrew Powers-Holmes <aholmes@omnom.net> Signed-off-by:
Andrew Powers-Holmes <aholmes@omnom.net> Signed-off-by:
Lucas Tanure <lucas.tanure@collabora.com>
-
RK3568 Naneng Combo Phy driver can support RK3588 with the additional clocks and initial configuration, so add the compatible line. Signed-off-by:
Lucas Tanure <lucas.tanure@collabora.com> Acked-by:
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Change-Id: I90aef072ef11729c8b1346aa4d8cdf792894f498
-
Enable USB2 (EHCI and OCHI mode) support for the Radxa ROCK 5 Model B. This adds USB support on the M.2 Key E, both USB2 ports and USB2 mode for the upper USB3 port (the one further away from the PCB). The lower USB3 (closer to the PCB) and the USB-C ports use the RK3588 USB TypeC host controller, which is not yet supported upstream. Signed-off-by:
Sebastian Reichel <sebastian.reichel@collabora.com>
-
Enable USB2 (EHCI and OCHI mode) support for the Rockchip RK3588 EVB1. Signed-off-by:
Sebastian Reichel <sebastian.reichel@collabora.com>
-
This adds USB2 (EHCI & OHCI) ports including the related PHYs and GRF modules to the rk3588(s) device tree. Signed-off-by:
Sebastian Reichel <sebastian.reichel@collabora.com>
-