This part is a fix:

-               feature_val = seg_featured_enabled(seg, feature_id, segid) ? 1 : 0;
                feature_id = V4L2_VP9_SEGMENT_FEATURE_SKIP;
+               feature_val = seg_featured_enabled(seg, feature_id, segid) ? 1 : 0;
                hantro_reg_write(ctx->dev, &seg_regs[segid][feature_id], feature_val);

Because feature_val was obtained with the prevoius feature_id.
In order to prevent this issue, I have refactored the function a bit.

Note that the *skip* tests I was debugging are still not passing,
so not sure what else is still wrong. In any case, this looked wrong :)

Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>