Skip to content
Snippets Groups Projects
Select Git revision
  • a254d8f9a8a928772ef4608342125ccb35b79d5d
  • vme-testing default
  • ci-test
  • master
  • remoteproc
  • am625-sk-ov5640
  • pcal6534-upstreaming
  • lps22df-upstreaming
  • msc-upstreaming
  • imx8mp
  • iio/noa1305
  • vme-next
  • vme-next-4.14-rc4
  • v4.14-rc4
  • v4.14-rc3
  • v4.14-rc2
  • v4.14-rc1
  • v4.13
  • vme-next-4.13-rc7
  • v4.13-rc7
  • v4.13-rc6
  • v4.13-rc5
  • v4.13-rc4
  • v4.13-rc3
  • v4.13-rc2
  • v4.13-rc1
  • v4.12
  • v4.12-rc7
  • v4.12-rc6
  • v4.12-rc5
  • v4.12-rc4
  • v4.12-rc3
32 results

xenbus.c

Blame
    • Paul Durrant's avatar
      a254d8f9
      xen-netback: don't vfree() queues under spinlock · a254d8f9
      Paul Durrant authored
      
      This leads to a BUG of the following form:
      
      [  174.512861] switch: port 2(vif3.0) entered disabled state
      [  174.522735] BUG: sleeping function called from invalid context at
      /home/build/linux-linus/mm/vmalloc.c:1441
      [  174.523451] in_atomic(): 1, irqs_disabled(): 0, pid: 28, name: xenwatch
      [  174.524131] CPU: 1 PID: 28 Comm: xenwatch Tainted: G        W
      4.10.0upstream-11073-g4977ab6-dirty #1
      [  174.524819] Hardware name: MSI MS-7680/H61M-P23 (MS-7680), BIOS V17.0
      03/14/2011
      [  174.525517] Call Trace:
      [  174.526217]  show_stack+0x23/0x60
      [  174.526899]  dump_stack+0x5b/0x88
      [  174.527562]  ___might_sleep+0xde/0x130
      [  174.528208]  __might_sleep+0x35/0xa0
      [  174.528840]  ? _raw_spin_unlock_irqrestore+0x13/0x20
      [  174.529463]  ? __wake_up+0x40/0x50
      [  174.530089]  remove_vm_area+0x20/0x90
      [  174.530724]  __vunmap+0x1d/0xc0
      [  174.531346]  ? delete_object_full+0x13/0x20
      [  174.531973]  vfree+0x40/0x80
      [  174.532594]  set_backend_state+0x18a/0xa90
      [  174.533221]  ? dwc_scan_descriptors+0x24d/0x430
      [  174.533850]  ? kfree+0x5b/0xc0
      [  174.534476]  ? xenbus_read+0x3d/0x50
      [  174.535101]  ? xenbus_read+0x3d/0x50
      [  174.535718]  ? xenbus_gather+0x31/0x90
      [  174.536332]  ? ___might_sleep+0xf6/0x130
      [  174.536945]  frontend_changed+0x6b/0xd0
      [  174.537565]  xenbus_otherend_changed+0x7d/0x80
      [  174.538185]  frontend_changed+0x12/0x20
      [  174.538803]  xenwatch_thread+0x74/0x110
      [  174.539417]  ? woken_wake_function+0x20/0x20
      [  174.540049]  kthread+0xe5/0x120
      [  174.540663]  ? xenbus_printf+0x50/0x50
      [  174.541278]  ? __kthread_init_worker+0x40/0x40
      [  174.541898]  ret_from_fork+0x21/0x2c
      [  174.548635] switch: port 2(vif3.0) entered disabled state
      
      This patch defers the vfree() until after the spinlock is released.
      
      Reported-by: default avatarJuergen Gross <jgross@suse.com>
      Signed-off-by: default avatarPaul Durrant <paul.durrant@citrix.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      a254d8f9
      History
      xen-netback: don't vfree() queues under spinlock
      Paul Durrant authored
      
      This leads to a BUG of the following form:
      
      [  174.512861] switch: port 2(vif3.0) entered disabled state
      [  174.522735] BUG: sleeping function called from invalid context at
      /home/build/linux-linus/mm/vmalloc.c:1441
      [  174.523451] in_atomic(): 1, irqs_disabled(): 0, pid: 28, name: xenwatch
      [  174.524131] CPU: 1 PID: 28 Comm: xenwatch Tainted: G        W
      4.10.0upstream-11073-g4977ab6-dirty #1
      [  174.524819] Hardware name: MSI MS-7680/H61M-P23 (MS-7680), BIOS V17.0
      03/14/2011
      [  174.525517] Call Trace:
      [  174.526217]  show_stack+0x23/0x60
      [  174.526899]  dump_stack+0x5b/0x88
      [  174.527562]  ___might_sleep+0xde/0x130
      [  174.528208]  __might_sleep+0x35/0xa0
      [  174.528840]  ? _raw_spin_unlock_irqrestore+0x13/0x20
      [  174.529463]  ? __wake_up+0x40/0x50
      [  174.530089]  remove_vm_area+0x20/0x90
      [  174.530724]  __vunmap+0x1d/0xc0
      [  174.531346]  ? delete_object_full+0x13/0x20
      [  174.531973]  vfree+0x40/0x80
      [  174.532594]  set_backend_state+0x18a/0xa90
      [  174.533221]  ? dwc_scan_descriptors+0x24d/0x430
      [  174.533850]  ? kfree+0x5b/0xc0
      [  174.534476]  ? xenbus_read+0x3d/0x50
      [  174.535101]  ? xenbus_read+0x3d/0x50
      [  174.535718]  ? xenbus_gather+0x31/0x90
      [  174.536332]  ? ___might_sleep+0xf6/0x130
      [  174.536945]  frontend_changed+0x6b/0xd0
      [  174.537565]  xenbus_otherend_changed+0x7d/0x80
      [  174.538185]  frontend_changed+0x12/0x20
      [  174.538803]  xenwatch_thread+0x74/0x110
      [  174.539417]  ? woken_wake_function+0x20/0x20
      [  174.540049]  kthread+0xe5/0x120
      [  174.540663]  ? xenbus_printf+0x50/0x50
      [  174.541278]  ? __kthread_init_worker+0x40/0x40
      [  174.541898]  ret_from_fork+0x21/0x2c
      [  174.548635] switch: port 2(vif3.0) entered disabled state
      
      This patch defers the vfree() until after the spinlock is released.
      
      Reported-by: default avatarJuergen Gross <jgross@suse.com>
      Signed-off-by: default avatarPaul Durrant <paul.durrant@citrix.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    proc.c 3.48 KiB
    // SPDX-License-Identifier: GPL-2.0
    #include <linux/proc_fs.h>
    #include <linux/seq_file.h>
    #include <linux/export.h>
    #include <linux/suspend.h>
    #include <linux/bcd.h>
    #include <linux/acpi.h>
    #include <linux/uaccess.h>
    
    #include "sleep.h"
    #include "internal.h"
    
    #define _COMPONENT		ACPI_SYSTEM_COMPONENT
    
    /*
     * this file provides support for:
     * /proc/acpi/wakeup
     */
    
    ACPI_MODULE_NAME("sleep")
    
    static int
    acpi_system_wakeup_device_seq_show(struct seq_file *seq, void *offset)
    {
    	struct acpi_device *dev, *tmp;
    
    	seq_printf(seq, "Device\tS-state\t  Status   Sysfs node\n");
    
    	mutex_lock(&acpi_device_lock);
    	list_for_each_entry_safe(dev, tmp, &acpi_wakeup_device_list,
    				 wakeup_list) {
    		struct acpi_device_physical_node *entry;
    
    		if (!dev->wakeup.flags.valid)
    			continue;
    
    		seq_printf(seq, "%s\t  S%d\t",
    			   dev->pnp.bus_id,
    			   (u32) dev->wakeup.sleep_state);
    
    		mutex_lock(&dev->physical_node_lock);
    
    		if (!dev->physical_node_count) {
    			seq_printf(seq, "%c%-8s\n",
    				dev->wakeup.flags.valid ? '*' : ' ',
    				device_may_wakeup(&dev->dev) ?
    					"enabled" : "disabled");
    		} else {
    			struct device *ldev;
    			list_for_each_entry(entry, &dev->physical_node_list,
    					node) {
    				ldev = get_device(entry->dev);
    				if (!ldev)
    					continue;
    
    				if (&entry->node !=
    						dev->physical_node_list.next)
    					seq_printf(seq, "\t\t");
    
    				seq_printf(seq, "%c%-8s  %s:%s\n",
    					dev->wakeup.flags.valid ? '*' : ' ',
    					(device_may_wakeup(&dev->dev) ||
    					device_may_wakeup(ldev)) ?
    					"enabled" : "disabled",
    					ldev->bus ? ldev->bus->name :
    					"no-bus", dev_name(ldev));
    				put_device(ldev);
    			}
    		}
    
    		mutex_unlock(&dev->physical_node_lock);
    	}
    	mutex_unlock(&acpi_device_lock);
    	return 0;
    }
    
    static void physical_device_enable_wakeup(struct acpi_device *adev)
    {
    	struct acpi_device_physical_node *entry;
    
    	mutex_lock(&adev->physical_node_lock);
    
    	list_for_each_entry(entry,
    		&adev->physical_node_list, node)
    		if (entry->dev && device_can_wakeup(entry->dev)) {
    			bool enable = !device_may_wakeup(entry->dev);
    			device_set_wakeup_enable(entry->dev, enable);
    		}
    
    	mutex_unlock(&adev->physical_node_lock);
    }
    
    static ssize_t
    acpi_system_write_wakeup_device(struct file *file,
    				const char __user * buffer,
    				size_t count, loff_t * ppos)
    {
    	struct acpi_device *dev, *tmp;
    	char strbuf[5];
    	char str[5] = "";
    
    	if (count > 4)
    		count = 4;
    
    	if (copy_from_user(strbuf, buffer, count))
    		return -EFAULT;
    	strbuf[count] = '\0';
    	sscanf(strbuf, "%s", str);
    
    	mutex_lock(&acpi_device_lock);
    	list_for_each_entry_safe(dev, tmp, &acpi_wakeup_device_list,
    				 wakeup_list) {
    		if (!dev->wakeup.flags.valid)
    			continue;
    
    		if (!strncmp(dev->pnp.bus_id, str, 4)) {
    			if (device_can_wakeup(&dev->dev)) {
    				bool enable = !device_may_wakeup(&dev->dev);
    				device_set_wakeup_enable(&dev->dev, enable);
    			} else {
    				physical_device_enable_wakeup(dev);
    			}
    			break;
    		}
    	}
    	mutex_unlock(&acpi_device_lock);
    	return count;
    }
    
    static int
    acpi_system_wakeup_device_open_fs(struct inode *inode, struct file *file)
    {
    	return single_open(file, acpi_system_wakeup_device_seq_show,
    			   PDE_DATA(inode));
    }
    
    static const struct proc_ops acpi_system_wakeup_device_proc_ops = {
    	.proc_open	= acpi_system_wakeup_device_open_fs,
    	.proc_read	= seq_read,
    	.proc_write	= acpi_system_write_wakeup_device,
    	.proc_lseek	= seq_lseek,
    	.proc_release	= single_release,
    };
    
    void __init acpi_sleep_proc_init(void)
    {
    	/* 'wakeup device' [R/W] */
    	proc_create("wakeup", S_IFREG | S_IRUGO | S_IWUSR,
    		    acpi_root_dir, &acpi_system_wakeup_device_proc_ops);
    }