Skip to content
Snippets Groups Projects
Select Git revision
  • cac6653529eeac9b661fc8342c47d849c3adb085
  • vme-testing default
  • ci-test
  • master
  • remoteproc
  • am625-sk-ov5640
  • pcal6534-upstreaming
  • lps22df-upstreaming
  • msc-upstreaming
  • imx8mp
  • iio/noa1305
  • vme-next
  • vme-next-4.14-rc4
  • v4.14-rc4
  • v4.14-rc3
  • v4.14-rc2
  • v4.14-rc1
  • v4.13
  • vme-next-4.13-rc7
  • v4.13-rc7
  • v4.13-rc6
  • v4.13-rc5
  • v4.13-rc4
  • v4.13-rc3
  • v4.13-rc2
  • v4.13-rc1
  • v4.12
  • v4.12-rc7
  • v4.12-rc6
  • v4.12-rc5
  • v4.12-rc4
  • v4.12-rc3
32 results

symbol-elf.c

  • Ingo Molnar's avatar
    14951f22
    Revert "perf symbols: Demangle cloned functions" · 14951f22
    Ingo Molnar authored
    
    This reverts commit de95ab53.
    
    Markus Trippelsdorf reported that this commit broke 'perf top':
    
     > I just see a gray screen with no text at all. Sometimes the
     > following error messages are printed:
     >
     >  *** Error in `perf': invalid fastbin entry (free): 0x00000000029b18c0
     >  ***
     >  *** Error in `perf': malloc(): memory corruption (fast): 0x0000000000ee0b10 ***
    
    While this code is fixable, the commit itself fails on several levels:
    
     - it should have been a separate helper function
     - why the heck does it do strchr() twice
     - it casts a const char * over into char *
     - sloppy style
     - it's not even a regression fix!
    
    So lets revert it and re-try the patch in v3.13.
    
    Reported-by: default avatarMarkus Trippelsdorf <markus@trippelsdorf.de>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
    14951f22
    History
    Revert "perf symbols: Demangle cloned functions"
    Ingo Molnar authored
    
    This reverts commit de95ab53.
    
    Markus Trippelsdorf reported that this commit broke 'perf top':
    
     > I just see a gray screen with no text at all. Sometimes the
     > following error messages are printed:
     >
     >  *** Error in `perf': invalid fastbin entry (free): 0x00000000029b18c0
     >  ***
     >  *** Error in `perf': malloc(): memory corruption (fast): 0x0000000000ee0b10 ***
    
    While this code is fixable, the commit itself fails on several levels:
    
     - it should have been a separate helper function
     - why the heck does it do strchr() twice
     - it casts a const char * over into char *
     - sloppy style
     - it's not even a regression fix!
    
    So lets revert it and re-try the patch in v3.13.
    
    Reported-by: default avatarMarkus Trippelsdorf <markus@trippelsdorf.de>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>