Skip to content
Snippets Groups Projects
Commit 104cbd55 authored by Lai Jiangshan's avatar Lai Jiangshan Committed by Linus Torvalds
Browse files

cgroups: use task_lock() for access tsk->cgroups safe in cgroup_clone()


Use task_lock() protect tsk->cgroups and get_css_set(tsk->cgroups).

Signed-off-by: default avatarLai Jiangshan <laijs@cn.fujitsu.com>
Acked-by: default avatarPaul Menage <menage@google.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Pavel Emelyanov <xemul@openvz.org>
Cc: Balbir Singh <balbir@in.ibm.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent b2aa30f7
Branches
Tags
No related merge requests found
...@@ -2903,6 +2903,7 @@ int cgroup_clone(struct task_struct *tsk, struct cgroup_subsys *subsys, ...@@ -2903,6 +2903,7 @@ int cgroup_clone(struct task_struct *tsk, struct cgroup_subsys *subsys,
mutex_unlock(&cgroup_mutex); mutex_unlock(&cgroup_mutex);
return 0; return 0;
} }
task_lock(tsk);
cg = tsk->cgroups; cg = tsk->cgroups;
parent = task_cgroup(tsk, subsys->subsys_id); parent = task_cgroup(tsk, subsys->subsys_id);
...@@ -2915,6 +2916,7 @@ int cgroup_clone(struct task_struct *tsk, struct cgroup_subsys *subsys, ...@@ -2915,6 +2916,7 @@ int cgroup_clone(struct task_struct *tsk, struct cgroup_subsys *subsys,
/* Keep the cgroup alive */ /* Keep the cgroup alive */
get_css_set(cg); get_css_set(cg);
task_unlock(tsk);
mutex_unlock(&cgroup_mutex); mutex_unlock(&cgroup_mutex);
/* Now do the VFS work to create a cgroup */ /* Now do the VFS work to create a cgroup */
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment