-
- Downloads
drm/i915: Use b->irq_enable() as predicate for mock engine
Since commit d4ccceb0 ("drm/i915/icl: Ringbuffer interrupt handling") we have required a mechanism to avoid touching the interrupt hardware for breadcrumbs, superseding our mock interface for selftests. The residual problem (ideas welcome) is in probing the mock ring registers for ring_is_idle. Hmm, maybe we should just install mock handlers for i915->uncore.mmio__write and friends? Only problem being is that we would to truly mock some expected reads. :( References: d4ccceb0 ("drm/i915/icl: Ringbuffer interrupt handling") Signed-off-by:Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by:
Tvrtko Ursulin <tvrtko.ursulin@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190118112225.13780-1-chris@chris-wilson.co.uk
Showing
- drivers/gpu/drm/i915/intel_breadcrumbs.c 4 additions, 13 deletionsdrivers/gpu/drm/i915/intel_breadcrumbs.c
- drivers/gpu/drm/i915/intel_engine_cs.c 4 additions, 7 deletionsdrivers/gpu/drm/i915/intel_engine_cs.c
- drivers/gpu/drm/i915/intel_ringbuffer.h 0 additions, 1 deletiondrivers/gpu/drm/i915/intel_ringbuffer.h
- drivers/gpu/drm/i915/selftests/mock_engine.c 0 additions, 1 deletiondrivers/gpu/drm/i915/selftests/mock_engine.c
Loading
Please register or sign in to comment