mm: reference totalram_pages and managed_pages once per function
Patch series "mm: convert totalram_pages, totalhigh_pages and managed pages to atomic", v5. This series converts totalram_pages, totalhigh_pages and zone->managed_pages to atomic variables. totalram_pages, zone->managed_pages and totalhigh_pages updates are protected by managed_page_count_lock, but readers never care about it. Convert these variables to atomic to avoid readers potentially seeing a store tear. Main motivation was that managed_page_count_lock handling was complicating things. It was discussed in length here, https://lore.kernel.org/patchwork/patch/995739/#1181785 It seemes better to remove the lock and convert variables to atomic. With the change, preventing poteintial store-to-read tearing comes as a bonus. This patch (of 4): This is in preparation to a later patch which converts totalram_pages and zone->managed_pages to atomic variables. Please note that re-reading the value might lead to a different value and as such it could lead to unexpected behavior. There are no known bugs as a result of the current code but it is better to prevent from them in principle. Link: http://lkml.kernel.org/r/1542090790-21750-2-git-send-email-arunks@codeaurora.org Signed-off-by:Arun KS <arunks@codeaurora.org> Reviewed-by:
Konstantin Khlebnikov <khlebnikov@yandex-team.ru> Reviewed-by:
David Hildenbrand <david@redhat.com> Acked-by:
Michal Hocko <mhocko@suse.com> Acked-by:
Vlastimil Babka <vbabka@suse.cz> Reviewed-by:
Pavel Tatashin <pasha.tatashin@soleen.com> Signed-off-by:
Andrew Morton <akpm@linux-foundation.org> Signed-off-by:
Linus Torvalds <torvalds@linux-foundation.org>
Showing
- arch/um/kernel/mem.c 1 addition, 1 deletionarch/um/kernel/mem.c
- arch/x86/kernel/cpu/microcode/core.c 3 additions, 2 deletionsarch/x86/kernel/cpu/microcode/core.c
- drivers/hv/hv_balloon.c 10 additions, 9 deletionsdrivers/hv/hv_balloon.c
- fs/file_table.c 4 additions, 3 deletionsfs/file_table.c
- kernel/fork.c 3 additions, 2 deletionskernel/fork.c
- kernel/kexec_core.c 3 additions, 2 deletionskernel/kexec_core.c
- mm/page_alloc.c 3 additions, 2 deletionsmm/page_alloc.c
- mm/shmem.c 2 additions, 1 deletionmm/shmem.c
- net/dccp/proto.c 4 additions, 3 deletionsnet/dccp/proto.c
- net/netfilter/nf_conntrack_core.c 4 additions, 3 deletionsnet/netfilter/nf_conntrack_core.c
- net/netfilter/xt_hashlimit.c 3 additions, 2 deletionsnet/netfilter/xt_hashlimit.c
- net/sctp/protocol.c 4 additions, 3 deletionsnet/sctp/protocol.c
Loading
Please register or sign in to comment