[PATCH] mm: split page table lock
Christoph Lameter demonstrated very poor scalability on the SGI 512-way, with a many-threaded application which concurrently initializes different parts of a large anonymous area. This patch corrects that, by using a separate spinlock per page table page, to guard the page table entries in that page, instead of using the mm's single page_table_lock. (But even then, page_table_lock is still used to guard page table allocation, and anon_vma allocation.) In this implementation, the spinlock is tucked inside the struct page of the page table page: with a BUILD_BUG_ON in case it overflows - which it would in the case of 32-bit PA-RISC with spinlock debugging enabled. Splitting the lock is not quite for free: another cacheline access. Ideally, I suppose we would use split ptlock only for multi-threaded processes on multi-cpu machines; but deciding that dynamically would have its own costs. So for now enable it by config, at some number of cpus - since the Kconfig language doesn't support inequalities, let preprocessor compare that with NR_CPUS. But I don't think it's worth being user-configurable: for good testing of both split and unsplit configs, split now at 4 cpus, and perhaps change that to 8 later. There is a benefit even for singly threaded processes: kswapd can be attacking one part of the mm while another part is busy faulting. Signed-off-by:Hugh Dickins <hugh@veritas.com> Signed-off-by:
Andrew Morton <akpm@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
Showing
- arch/arm/mm/mm-armv.c 1 addition, 0 deletionsarch/arm/mm/mm-armv.c
- arch/frv/mm/pgalloc.c 2 additions, 2 deletionsarch/frv/mm/pgalloc.c
- arch/i386/mm/pgtable.c 4 additions, 4 deletionsarch/i386/mm/pgtable.c
- arch/um/kernel/skas/mmu.c 1 addition, 0 deletionsarch/um/kernel/skas/mmu.c
- fs/afs/file.c 2 additions, 2 deletionsfs/afs/file.c
- fs/buffer.c 1 addition, 1 deletionfs/buffer.c
- fs/jfs/jfs_metapage.c 6 additions, 6 deletionsfs/jfs/jfs_metapage.c
- fs/xfs/linux-2.6/xfs_buf.c 4 additions, 3 deletionsfs/xfs/linux-2.6/xfs_buf.c
- include/linux/buffer_head.h 3 additions, 3 deletionsinclude/linux/buffer_head.h
- include/linux/mm.h 38 additions, 8 deletionsinclude/linux/mm.h
- kernel/kexec.c 2 additions, 2 deletionskernel/kexec.c
- mm/Kconfig 13 additions, 0 deletionsmm/Kconfig
- mm/filemap.c 1 addition, 1 deletionmm/filemap.c
- mm/memory.c 14 additions, 10 deletionsmm/memory.c
- mm/mremap.c 10 additions, 1 deletionmm/mremap.c
- mm/page_alloc.c 8 additions, 8 deletionsmm/page_alloc.c
- mm/page_io.c 4 additions, 2 deletionsmm/page_io.c
- mm/rmap.c 2 additions, 2 deletionsmm/rmap.c
- mm/shmem.c 10 additions, 12 deletionsmm/shmem.c
- mm/swap.c 1 addition, 1 deletionmm/swap.c
Loading
Please register or sign in to comment