net: Compute protocol sequence numbers and fragment IDs using MD5.
Computers have become a lot faster since we compromised on the partial MD4 hash which we use currently for performance reasons. MD5 is a much safer choice, and is inline with both RFC1948 and other ISS generators (OpenBSD, Solaris, etc.) Furthermore, only having 24-bits of the sequence number be truly unpredictable is a very serious limitation. So the periodic regeneration and 8-bit counter have been removed. We compute and use a full 32-bit sequence number. For ipv6, DCCP was found to use a 32-bit truncated initial sequence number (it needs 43-bits) and that is fixed here as well. Reported-by:Dan Kaminsky <dan@doxpara.com> Tested-by:
Willy Tarreau <w@1wt.eu> Signed-off-by:
David S. Miller <davem@davemloft.net>
Showing
- drivers/char/random.c 8 additions, 341 deletionsdrivers/char/random.c
- include/linux/random.h 0 additions, 12 deletionsinclude/linux/random.h
- include/net/secure_seq.h 20 additions, 0 deletionsinclude/net/secure_seq.h
- net/core/Makefile 1 addition, 1 deletionnet/core/Makefile
- net/core/secure_seq.c 184 additions, 0 deletionsnet/core/secure_seq.c
- net/dccp/ipv4.c 1 addition, 0 deletionsnet/dccp/ipv4.c
- net/dccp/ipv6.c 2 additions, 7 deletionsnet/dccp/ipv6.c
- net/ipv4/inet_hashtables.c 1 addition, 0 deletionsnet/ipv4/inet_hashtables.c
- net/ipv4/inetpeer.c 1 addition, 0 deletionsnet/ipv4/inetpeer.c
- net/ipv4/netfilter/nf_nat_proto_common.c 1 addition, 0 deletionsnet/ipv4/netfilter/nf_nat_proto_common.c
- net/ipv4/route.c 1 addition, 0 deletionsnet/ipv4/route.c
- net/ipv4/tcp_ipv4.c 1 addition, 0 deletionsnet/ipv4/tcp_ipv4.c
- net/ipv6/inet6_hashtables.c 1 addition, 0 deletionsnet/ipv6/inet6_hashtables.c
- net/ipv6/tcp_ipv6.c 1 addition, 0 deletionsnet/ipv6/tcp_ipv6.c
Loading
Please register or sign in to comment