Skip to content
Snippets Groups Projects
Commit b09aaa3f authored by Barnabás Pőcze's avatar Barnabás Pőcze Committed by Hans de Goede
Browse files

platform/x86: ideapad-laptop: fix method name typo

"smbc" should be "sbmc". `eval_smbc()` incorrectly called
the SMBC ACPI method instead of SBMC. This resulted in
partial loss of functionality. Rectify that by calling
the correct ACPI method (SBMC), and also rename
methods and constants.

BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=212985


Fixes: 0b765671 ("platform/x86: ideapad-laptop: group and separate (un)related constants into enums")
Fixes: ff36b0d9 ("platform/x86: ideapad-laptop: rework and create new ACPI helpers")
Cc: stable@vger.kernel.org # 5.12
Signed-off-by: default avatarBarnabás Pőcze <pobrn@protonmail.com>
Link: https://lore.kernel.org/r/20210507235333.286505-1-pobrn@protonmail.com


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent ff67dbd5
No related branches found
No related tags found
No related merge requests found
...@@ -57,8 +57,8 @@ enum { ...@@ -57,8 +57,8 @@ enum {
}; };
enum { enum {
SMBC_CONSERVATION_ON = 3, SBMC_CONSERVATION_ON = 3,
SMBC_CONSERVATION_OFF = 5, SBMC_CONSERVATION_OFF = 5,
}; };
enum { enum {
...@@ -182,9 +182,9 @@ static int eval_gbmd(acpi_handle handle, unsigned long *res) ...@@ -182,9 +182,9 @@ static int eval_gbmd(acpi_handle handle, unsigned long *res)
return eval_int(handle, "GBMD", res); return eval_int(handle, "GBMD", res);
} }
static int exec_smbc(acpi_handle handle, unsigned long arg) static int exec_sbmc(acpi_handle handle, unsigned long arg)
{ {
return exec_simple_method(handle, "SMBC", arg); return exec_simple_method(handle, "SBMC", arg);
} }
static int eval_hals(acpi_handle handle, unsigned long *res) static int eval_hals(acpi_handle handle, unsigned long *res)
...@@ -477,7 +477,7 @@ static ssize_t conservation_mode_store(struct device *dev, ...@@ -477,7 +477,7 @@ static ssize_t conservation_mode_store(struct device *dev,
if (err) if (err)
return err; return err;
err = exec_smbc(priv->adev->handle, state ? SMBC_CONSERVATION_ON : SMBC_CONSERVATION_OFF); err = exec_sbmc(priv->adev->handle, state ? SBMC_CONSERVATION_ON : SBMC_CONSERVATION_OFF);
if (err) if (err)
return err; return err;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment