[PATCH] Kill PF_SYNCWRITE flag
A process flag to indicate whether we are doing sync io is incredibly
ugly. It also causes performance problems when one does a lot of async
io and then proceeds to sync it. Part of the io will go out as async,
and the other part as sync. This causes a disconnect between the
previously submitted io and the synced io. For io schedulers such as CFQ,
this will cause us lost merges and suboptimal behaviour in scheduling.
Remove PF_SYNCWRITE completely from the fsync/msync paths, and let
the O_DIRECT path just directly indicate that the writes are sync
by using WRITE_SYNC instead.
Signed-off-by:
Jens Axboe <axboe@suse.de>
Showing
- block/as-iosched.c 1 addition, 1 deletionblock/as-iosched.c
- block/cfq-iosched.c 1 addition, 3 deletionsblock/cfq-iosched.c
- block/ll_rw_blk.c 3 additions, 0 deletionsblock/ll_rw_blk.c
- drivers/usb/gadget/file_storage.c 0 additions, 2 deletionsdrivers/usb/gadget/file_storage.c
- fs/buffer.c 0 additions, 2 deletionsfs/buffer.c
- fs/direct-io.c 8 additions, 10 deletionsfs/direct-io.c
- fs/fs-writeback.c 0 additions, 2 deletionsfs/fs-writeback.c
- include/linux/blkdev.h 2 additions, 0 deletionsinclude/linux/blkdev.h
- include/linux/sched.h 5 additions, 6 deletionsinclude/linux/sched.h
- mm/msync.c 0 additions, 3 deletionsmm/msync.c
Loading
Please register or sign in to comment