-
- Downloads
[JFFS2] Tidy up fix for ACL/permissions problem.
[In commit 9ed437c5 we fixed a problem with standard permissions on newly-created inodes, when POSIX ACLs are enabled. This cleans it up...] The attached patch separate jffs2_init_acl() into two parts. The one is jffs2_init_acl_pre() called from jffs2_new_inode(). It compute ACL oriented inode->i_mode bits, and allocate in-memory ACL objects associated with the new inode just before when inode meta infomation is written to the medium. The other is jffs2_init_acl_post() called from jffs2_symlink(), jffs2_mkdir(), jffs2_mknod() and jffs2_do_create(). It actually writes in-memory ACL objects into the medium next to the success of writing meta-information. In the current implementation, we have to write a same inode meta infomation twice when inode->i_mode is updated by the default ACL. However, we can avoid the behavior by putting an updated i_mode before it is written at first, as jffs2_init_acl_pre() doing. Signed-off-by:KaiGai Kohei <kaigai@ak.jp.nec.com> Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
Showing
- fs/jffs2/acl.c 65 additions, 36 deletionsfs/jffs2/acl.c
- fs/jffs2/acl.h 7 additions, 5 deletionsfs/jffs2/acl.h
- fs/jffs2/dir.c 7 additions, 28 deletionsfs/jffs2/dir.c
- fs/jffs2/fs.c 6 additions, 15 deletionsfs/jffs2/fs.c
- fs/jffs2/os-linux.h 1 addition, 3 deletionsfs/jffs2/os-linux.h
- fs/jffs2/write.c 8 additions, 0 deletionsfs/jffs2/write.c
Loading
Please register or sign in to comment