Skip to content
Snippets Groups Projects
Commit d95cd480 authored by Michal Kuchta's avatar Michal Kuchta Committed by Jeff Kirsher
Browse files

i40e: Fix for blinking activity instead of link LEDs


This fix solves an issue occurring while calling i40e_led_set function
from the driver with "blink" parameter set as TRUE. This call resulted
in Activity LED blinking instead of Link LED, which may lead to errors
in physically identifying the port, since Activity LED may be blinking
for different reasons as well.

Signed-off-by: default avatarMichal Kuchta <michal.kuchta@intel.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 06aa040f
No related branches found
No related tags found
No related merge requests found
...@@ -1486,6 +1486,7 @@ u32 i40e_led_get(struct i40e_hw *hw) ...@@ -1486,6 +1486,7 @@ u32 i40e_led_get(struct i40e_hw *hw)
case I40E_COMBINED_ACTIVITY: case I40E_COMBINED_ACTIVITY:
case I40E_FILTER_ACTIVITY: case I40E_FILTER_ACTIVITY:
case I40E_MAC_ACTIVITY: case I40E_MAC_ACTIVITY:
case I40E_LINK_ACTIVITY:
continue; continue;
default: default:
break; break;
...@@ -1534,6 +1535,7 @@ void i40e_led_set(struct i40e_hw *hw, u32 mode, bool blink) ...@@ -1534,6 +1535,7 @@ void i40e_led_set(struct i40e_hw *hw, u32 mode, bool blink)
case I40E_COMBINED_ACTIVITY: case I40E_COMBINED_ACTIVITY:
case I40E_FILTER_ACTIVITY: case I40E_FILTER_ACTIVITY:
case I40E_MAC_ACTIVITY: case I40E_MAC_ACTIVITY:
case I40E_LINK_ACTIVITY:
continue; continue;
default: default:
break; break;
...@@ -1544,9 +1546,6 @@ void i40e_led_set(struct i40e_hw *hw, u32 mode, bool blink) ...@@ -1544,9 +1546,6 @@ void i40e_led_set(struct i40e_hw *hw, u32 mode, bool blink)
gpio_val |= ((mode << I40E_GLGEN_GPIO_CTL_LED_MODE_SHIFT) & gpio_val |= ((mode << I40E_GLGEN_GPIO_CTL_LED_MODE_SHIFT) &
I40E_GLGEN_GPIO_CTL_LED_MODE_MASK); I40E_GLGEN_GPIO_CTL_LED_MODE_MASK);
if (mode == I40E_LINK_ACTIVITY)
blink = false;
if (blink) if (blink)
gpio_val |= BIT(I40E_GLGEN_GPIO_CTL_LED_BLINK_SHIFT); gpio_val |= BIT(I40E_GLGEN_GPIO_CTL_LED_BLINK_SHIFT);
else else
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment