Skip to content
Snippets Groups Projects
Commit f151ba98 authored by Boris Ostrovsky's avatar Boris Ostrovsky Committed by Jens Axboe
Browse files

xen/blkfront: When purging persistent grants, keep them in the buffer


Commit a46b5367 ("xen/blkfront: cleanup stale persistent grants")
added support for purging persistent grants when they are not in use. As
part of the purge, the grants were removed from the grant buffer, This
eventually causes the buffer to become empty, with BUG_ON triggered in
get_free_grant(). This can be observed even on an idle system, within
20-30 minutes.

We should keep the grants in the buffer when purging, and only free the
grant ref.

Fixes: a46b5367 ("xen/blkfront: cleanup stale persistent grants")
Reviewed-by: default avatarJuergen Gross <jgross@suse.com>
Signed-off-by: default avatarBoris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 854f31cc
No related branches found
No related tags found
No related merge requests found
......@@ -2667,11 +2667,9 @@ static void purge_persistent_grants(struct blkfront_info *info)
gnttab_query_foreign_access(gnt_list_entry->gref))
continue;
list_del(&gnt_list_entry->node);
gnttab_end_foreign_access(gnt_list_entry->gref, 0, 0UL);
gnt_list_entry->gref = GRANT_INVALID_REF;
rinfo->persistent_gnts_c--;
__free_page(gnt_list_entry->page);
kfree(gnt_list_entry);
}
spin_unlock_irqrestore(&rinfo->ring_lock, flags);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment