Skip to content
Snippets Groups Projects
Commit fd217f4d authored by Arjan van de Ven's avatar Arjan van de Ven Committed by Al Viro
Browse files

[PATCH] fs: add a sanity check in d_free


Hi Al,

remember that debug session we did at KS? You suggested this patch back
then....

From 7751eaf30474b8cbfaea64795805a17eab05ac53 Mon Sep 17 00:00:00 2001
From: Arjan van de Ven <arjan@linux.intel.com>
Date: Tue, 16 Sep 2008 16:51:17 -0700
Subject: [PATCH] fs: add a sanity check in d_free

we're seeing some corruption in the dentry->d_alias list that
appears like a free of an entry still on the list; this patch
adds a WARN_ON() to catch this scenario, as suggested by Al Viro

Signed-off-by: default avatarArjan van de Ven <arjan@linux.intel.com>
parent 08b9fe6b
No related branches found
No related tags found
No related merge requests found
...@@ -69,6 +69,7 @@ struct dentry_stat_t dentry_stat = { ...@@ -69,6 +69,7 @@ struct dentry_stat_t dentry_stat = {
static void __d_free(struct dentry *dentry) static void __d_free(struct dentry *dentry)
{ {
WARN_ON(!list_empty(&dentry->d_alias));
if (dname_external(dentry)) if (dname_external(dentry))
kfree(dentry->d_name.name); kfree(dentry->d_name.name);
kmem_cache_free(dentry_cache, dentry); kmem_cache_free(dentry_cache, dentry);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment