Skip to content
Snippets Groups Projects
  1. Jun 15, 2019
  2. Jun 07, 2019
  3. Jun 05, 2019
  4. Jun 01, 2019
    • Randy Dunlap's avatar
      lib/sort.c: fix kernel-doc notation warnings · aa52619c
      Randy Dunlap authored
      Fix kernel-doc notation in lib/sort.c by using correct function parameter
      names.
      
        lib/sort.c:59: warning: Excess function parameter 'size' description in 'swap_words_32'
        lib/sort.c:83: warning: Excess function parameter 'size' description in 'swap_words_64'
        lib/sort.c:110: warning: Excess function parameter 'size' description in 'swap_bytes'
      
      Link: http://lkml.kernel.org/r/60e25d3d-68d1-bde2-3b39-e4baa0b14907@infradead.org
      
      
      Fixes: 37d0ec34 ("lib/sort: make swap functions more generic")
      Signed-off-by: default avatarRandy Dunlap <rdunlap@infradead.org>
      Cc: George Spelvin <lkml@sdf.org>
      Cc: Andrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      aa52619c
    • Masahiro Yamada's avatar
      treewide: fix typos of SPDX-License-Identifier · 8e82fe2a
      Masahiro Yamada authored
      
      Prior to the adoption of SPDX, it was difficult for tools to determine
      the correct license due to incomplete or badly formatted license text.
      The SPDX solves this issue, assuming people can correctly spell
      "SPDX-License-Identifier" although this assumption is broken in some
      places.
      
      Since scripts/spdxcheck.py parses only lines that exactly matches to
      the correct tag, it cannot (should not) detect this kind of error.
      
      If the correct tag is missing, scripts/checkpatch.pl warns like this:
      
       WARNING: Missing or malformed SPDX-License-Identifier tag in line *
      
      So, people should notice it before the patch submission, but in reality
      broken tags sometimes slip in. The checkpatch warning is not useful for
      checking the committed files globally since large number of files still
      have no SPDX tag.
      
      Also, I am not sure about the legal effect when the SPDX tag is broken.
      
      Anyway, these typos are absolutely worth fixing. It is pretty easy to
      find suspicious lines by grep.
      
        $ git grep --not -e SPDX-License-Identifier --and -e SPDX- -- \
          :^LICENSES :^scripts/spdxcheck.py :^*/license-rules.rst
        arch/arm/kernel/bugs.c:// SPDX-Identifier: GPL-2.0
        drivers/phy/st/phy-stm32-usbphyc.c:// SPDX-Licence-Identifier: GPL-2.0
        drivers/pinctrl/sh-pfc/pfc-r8a77980.c:// SPDX-Lincense-Identifier: GPL 2.0
        lib/test_stackinit.c:// SPDX-Licenses: GPLv2
        sound/soc/codecs/max9759.c:// SPDX-Licence-Identifier: GPL-2.0
      
      Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      8e82fe2a
  5. May 30, 2019
  6. May 24, 2019
  7. May 23, 2019
  8. May 21, 2019
  9. May 17, 2019
  10. May 16, 2019
  11. May 15, 2019
    • Eric Sandeen's avatar
      tools/testing/selftests/sysctl/sysctl.sh: add proc_do_large_bitmap() test case · 2ea622b8
      Eric Sandeen authored
      The kernel has only two users of proc_do_large_bitmap(), the kernel CPU
      watchdog, and the ip_local_reserved_ports.  Refer to watchdog_cpumask
      and ip_local_reserved_ports in Documentation for further details on
      these.  When you input a large buffer into these, when it is larger than
      PAGE_SIZE- 1, the input data gets misparsed, and the user get
      incorrectly informed that the desired input value was set.  This commit
      implements a test which mimics and exploits that use case, it uses a
      bitmap size, as in the watchdog case.  The bitmap is used to test the
      bitmap proc handler, proc_do_large_bitmap().
      
      The next commit fixes this issue.
      
      [akpm@linux-foundation.org: move proc_do_large_bitmap() export to EOF]
      [mcgrof@kernel.org: use new target description for backward compatibility]
      [mcgrof@kernel.org: augment test number to 50, ran into issues with bash string comparisons when testing up to 50 cases.]
      [mcgrof@kernel.org: introduce and use verify_diff_proc_file() to use diff]
      [mcgrof@kernel.org: use mktemp for tmp file]
      [mcgrof@kernel.org: merge shell test and C code]
      [mcgrof@kernel.org: commit log love]
      [mcgrof@kernel.org: export proc_do_large_bitmap() to allow for the test
      [mcgrof@kernel.org: check for the return value when writing to the proc file]
      Link: http://lkml.kernel.org/r/20190320222831.8243-6-mcgrof@kernel.org
      
      
      Signed-off-by: default avatarEric Sandeen <sandeen@redhat.com>
      Signed-off-by: default avatarLuis Chamberlain <mcgrof@kernel.org>
      Acked-by: default avatarKees Cook <keescook@chromium.org>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      2ea622b8
    • Sinan Kaya's avatar
      init: introduce DEBUG_MISC option · c66d7a27
      Sinan Kaya authored
      Patch series "init: Do not select DEBUG_KERNEL by default", v5.
      
      CONFIG_DEBUG_KERNEL has been designed to just enable Kconfig options.
      Kernel code generatoin should not depend on CONFIG_DEBUG_KERNEL.
      
      Proposed alternative plan: let's add a new symbol, something like
      DEBUG_MISC ("Miscellaneous debug code that should be under a more
      specific debug option but isn't"), make it depend on DEBUG_KERNEL and be
      "default DEBUG_KERNEL" but allow itself to be turned off, and then
      mechanically change the small handful of "#ifdef CONFIG_DEBUG_KERNEL" to
      "#ifdef CONFIG_DEBUG_MISC".
      
      This patch (of 5):
      
      Introduce DEBUG_MISC ("Miscellaneous debug code that should be under a
      more specific debug option but isn't"), make it depend on DEBUG_KERNEL
      and be "default DEBUG_KERNEL" but allow itself to be turned off, and
      then mechanically change the small handful of "#ifdef
      CONFIG_DEBUG_KERNEL" to "#ifdef CONFIG_DEBUG_MISC".
      
      Link: http://lkml.kernel.org/r/20190413224438.10802-2-okaya@kernel.org
      
      
      Signed-off-by: default avatarSinan Kaya <okaya@kernel.org>
      Reviewed-by: default avatarJosh Triplett <josh@joshtriplett.org>
      Reviewed-by: default avatarKees Cook <keescook@chromium.org>
      Cc: Anders Roxell <anders.roxell@linaro.org>
      Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
      Cc: Christophe Leroy <christophe.leroy@c-s.fr>
      Cc:  Chris Zankel <chris@zankel.net>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Florian Westphal <fw@strlen.de>
      Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
      Cc: James Hogan <jhogan@kernel.org>
      Cc: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
      Cc: Max Filippov <jcmvbkbc@gmail.com>
      Cc: Michael Ellerman <mpe@ellerman.id.au>
      Cc: Michal Hocko <mhocko@suse.com>
      Cc: Mike Rapoport <rppt@linux.ibm.com>
      Cc: Pablo Neira Ayuso <pablo@netfilter.org>
      Cc: Paul Burton <paul.burton@mips.com>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Ralf Baechle <ralf@linux-mips.org>
      Cc: Thomas Bogendoerfer <tbogendoerfer@suse.de>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      c66d7a27
Loading