Skip to content
Snippets Groups Projects
  1. Jun 05, 2019
  2. Jun 03, 2019
    • Xin Long's avatar
      selftests: set sysctl bc_forwarding properly in router_broadcast.sh · 67c0aaa1
      Xin Long authored
      
      sysctl setting bc_forwarding for $rp2 is needed when ping_test_from h2,
      otherwise the bc packets from $rp2 won't be forwarded. This patch is to
      add this setting for $rp2.
      
      Also, as ping_test_from does grep "$from" only, which could match some
      unexpected output, some test case doesn't really work, like:
      
        # ping_test_from $h2 198.51.200.255 198.51.200.2
          PING 198.51.200.255 from 198.51.100.2 veth3: 56(84) bytes of data.
          64 bytes from 198.51.100.1: icmp_seq=1 ttl=64 time=0.336 ms
      
      When doing grep $form (198.51.200.2), the output could still match.
      So change to grep "bytes from $from" instead.
      
      Fixes: 40f98b9a ("selftests: add a selftest for directed broadcast forwarding")
      Signed-off-by: default avatarXin Long <lucien.xin@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      67c0aaa1
  3. May 30, 2019
  4. May 29, 2019
    • Stefano Brivio's avatar
      selftests: pmtu: Fix encapsulating device in pmtu_vti6_link_change_mtu · 73f51d15
      Stefano Brivio authored
      
      In the pmtu_vti6_link_change_mtu test, both local and remote addresses
      for the vti6 tunnel are assigned to the same address given to the dummy
      interface that we use as encapsulating device with a known MTU.
      
      This works as long as the dummy interface is actually selected, via
      rt6_lookup(), as encapsulating device. But if the remote address of the
      tunnel is a local address too, the loopback interface could also be
      selected, and there's nothing wrong with it.
      
      This is what some older -stable kernels do (3.18.z, at least), and
      nothing prevents us from subtly changing FIB implementation to revert
      back to that behaviour in the future.
      
      Define an IPv6 prefix instead, and use two separate addresses as local
      and remote for vti6, so that the encapsulating device can't be a
      loopback interface.
      
      Reported-by: default avatarXiumei Mu <xmu@redhat.com>
      Fixes: 1fad59ea ("selftests: pmtu: Add pmtu_vti6_link_change_mtu test")
      Signed-off-by: default avatarStefano Brivio <sbrivio@redhat.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      73f51d15
Loading