Skip to content
Snippets Groups Projects
  1. Aug 07, 2011
    • Boaz Harrosh's avatar
      exofs: Add offset/length to exofs_get_io_state · e1042ba0
      Boaz Harrosh authored
      
      In future raid code we will need to know the IO offset/length
      and if it's a read or write to determine some of the array
      sizes we'll need.
      
      So add a new exofs_get_rw_state() API for use when
      writeing/reading. All other simple cases are left using the
      old way.
      
      The major change to this is that now we need to call
      exofs_get_io_state later at inode.c::read_exec and
      inode.c::write_exec when we actually know these things. So this
      patch is kept separate so I can test things apart from other
      changes.
      
      Signed-off-by: default avatarBoaz Harrosh <bharrosh@panasas.com>
      e1042ba0
  2. Aug 04, 2011
    • Boaz Harrosh's avatar
      exofs: Fix truncate for the raid-groups case · 16f75bb3
      Boaz Harrosh authored
      
      In the general raid-group case the truncate was wrong in that
      it did not also fix the object length of the neighboring groups.
      
      There are two bad cases in the old code:
      1. Space that should be freed was not.
      2. If a file That was big is truncated small, then made bigger
         again, the holes would not contain zeros but could expose old data.
         (If the growing of the file expands to more than a full
          groups cycle + group size (> S + T))
      
      Signed-off-by: default avatarBoaz Harrosh <bharrosh@panasas.com>
      16f75bb3
  3. Oct 25, 2010
  4. Aug 09, 2010
  5. Aug 07, 2010
    • Christoph Hellwig's avatar
      block: unify flags for struct bio and struct request · 7b6d91da
      Christoph Hellwig authored
      
      Remove the current bio flags and reuse the request flags for the bio, too.
      This allows to more easily trace the type of I/O from the filesystem
      down to the block driver.  There were two flags in the bio that were
      missing in the requests:  BIO_RW_UNPLUG and BIO_RW_AHEAD.  Also I've
      renamed two request flags that had a superflous RW in them.
      
      Note that the flags are in bio.h despite having the REQ_ name - as
      blkdev.h includes bio.h that is the only way to go for now.
      
      Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
      Signed-off-by: default avatarJens Axboe <jaxboe@fusionio.com>
      7b6d91da
  6. Aug 04, 2010
    • Boaz Harrosh's avatar
      exofs: Fix groups code when num_devices is not divisible by group_width · 5002dd18
      Boaz Harrosh authored
      
      There is a bug when num_devices is not divisible by group_width * mirrors.
      We would not return to the proper device and offset when looping on to the
      next group.
      
      The fix makes code simpler actually.
      
      Signed-off-by: default avatarBoaz Harrosh <bharrosh@panasas.com>
      5002dd18
    • Boaz Harrosh's avatar
      exofs: Remove useless optimization · 6e31609b
      Boaz Harrosh authored
      
      We used to compact all used devices in an IO to the beginning
      of the device array in an io_state. And keep a last device used
      so in later loops we don't iterate on all device slots. This
      does not prevent us from checking if slots are empty since in
      reads we only read from a single mirror and jump to the next
      mirror-set.
      
      This optimization is marginal, and needlessly complicates the
      code. Specially when we will later want to support raid/456
      with same abstract code. So remove the distinction between
      "dev" and "comp". Only "dev" is used both as the device used
      and as the index (component) in the device array.
      
      [Note that now the io_state->dev member is redundant but I
       keep it because I might want to optimize by only IOing a
       single group, though keeping a group_width*mirrors devices
       in io_state, we now keep num-devices in each io_state]
      
      Signed-off-by: default avatarBoaz Harrosh <bharrosh@panasas.com>
      6e31609b
  7. Mar 30, 2010
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Guess-its-ok-by: default avatarChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  8. Feb 28, 2010
    • Boaz Harrosh's avatar
      exofs: groups support · 50a76fd3
      Boaz Harrosh authored
      
      * _calc_stripe_info() changes to accommodate for grouping
        calculations. Returns additional information
      
      * old _prepare_pages() becomes _prepare_one_group()
        which stores pages belonging to one device group.
      
      * New _prepare_for_striping iterates on all groups calling
        _prepare_one_group().
      
      * Enable mounting of groups data_maps (group_width != 0)
      
      [QUESTION]
      what is faster A or B;
      A.	x += stride;
      	x = x % width + first_x;
      
      B	x += stride
      	if (x < last_x)
      		x = first_x;
      
      Signed-off-by: default avatarBoaz Harrosh <bharrosh@panasas.com>
      50a76fd3
    • Boaz Harrosh's avatar
      exofs: Prepare for groups · b367e78b
      Boaz Harrosh authored
      
      * Rename _offset_dev_unit_off() to _calc_stripe_info()
        and recieve a struct for the output params
      
      * In _prepare_for_striping we only need to call
        _calc_stripe_info() once. The other componets
        are easy to calculate from that. This code
        was inspired by what's done in truncate.
      
      * Some code shifts that make sense now but will make
        more sense when group support is added.
      
      Signed-off-by: default avatarBoaz Harrosh <bharrosh@panasas.com>
      b367e78b
    • Boaz Harrosh's avatar
      exofs: convert io_state to use pages array instead of bio at input · 86093aaf
      Boaz Harrosh authored
      
      * inode.c operations are full-pages based, and not actually
        true scatter-gather
      * Lets us use more pages at once upto 512 (from 249) in 64 bit
      * Brings us much much closer to be able to use exofs's io_state engine
        from objlayout driver. (Once I decide where to put the common code)
      
      After RAID0 patch the outer (input) bio was never used as a bio, but
      was simply a page carrier into the raid engine. Even in the simple
      mirror/single-dev arrangement pages info was copied into a second bio.
      It is now easer to just pass a pages array into the io_state and prepare
      bio(s) once.
      
      Signed-off-by: default avatarBoaz Harrosh <bharrosh@panasas.com>
      86093aaf
    • Boaz Harrosh's avatar
      exofs: RAID0 support · 5d952b83
      Boaz Harrosh authored
      
      We now support striping over mirror devices. Including variable sized
      stripe_unit.
      
      Some limits:
      * stripe_unit must be a multiple of PAGE_SIZE
      * stripe_unit * stripe_count is maximum upto 32-bit (4Gb)
      
      Tested RAID0 over mirrors, RAID0 only, mirrors only. All check.
      
      Design notes:
      * I'm not using a vectored raid-engine mechanism yet. Following the
        pnfs-objects-layout data-map structure, "Mirror" is just a private
        case of "group_width" == 1, and RAID0 is a private case of
        "Mirrors" == 1. The performance lose of the general case over the
        particular special case optimization is totally negligible, also
        considering the extra code size.
      
      * In general I added a prepare_stripes() stage that divides the
        to-be-io pages to the participating devices, the previous
        exofs_ios_write/read, now becomes _write/read_mirrors and a new
        write/read upper layer loops on all devices calling
        _write/read_mirrors. Effectively the prepare_stripes stage is the all
        secret.
        Also truncate need fixing to accommodate for striping.
      
      * In a RAID0 arrangement, in a regular usage scenario, if all inode
        layouts will start at the same device, the small files fill up the
        first device and the later devices stay empty, the farther the device
        the emptier it is.
      
        To fix that, each inode will start at a different stripe_unit,
        according to it's obj_id modulus number-of-stripe-units. And
        will then span all stripe-units in the same incrementing order
        wrapping back to the beginning of the device table. We call it
        a stripe-units moving window.
      
        Special consideration was taken to keep all devices in a mirror
        arrangement identical. So a broken osd-device could just be cloned
        from one of the mirrors and no FS scrubbing is needed. (We do that
        by rotating stripe-unit at a time and not a single device at a time.)
      
      TODO:
       We no longer verify object_length == inode->i_size in exofs_iget.
       (since i_size is stripped on multiple objects now).
       I should introduce a multiple-device attribute reading, and use
       it in exofs_iget.
      
      Signed-off-by: default avatarBoaz Harrosh <bharrosh@panasas.com>
      5d952b83
    • Boaz Harrosh's avatar
      exofs: Define on-disk per-inode optional layout attribute · d9c740d2
      Boaz Harrosh authored
      
      * Layouts describe the way a file is spread on multiple devices.
        The layout information is stored in the objects attribute introduced
        in this patch.
      
      * There can be multiple generating function for the layout.
        Currently defined:
          - No attribute present - use below moving-window on global
            device table, all devices.
            (This is the only one currently used in exofs)
          - an obj_id generated moving window - the obj_id is a randomizing
            factor in the otherwise global map layout.
          - An explicit layout stored, including a data_map and a device
            index list.
          - More might be defined in future ...
      
      * There are two attributes defined of the same structure:
        A-data-files-layout - This layout is used by data-files. If present
                              at a directory, all files of that directory will
                              be created with this layout.
        A-meta-data-layout - This layout is used by a directory and other
                             meta-data information. Also inherited at creation
                             of subdirectories.
      
      * At creation time inodes are created with the layout specified above.
        A usermode utility may change the creation layout on a give directory
        or file. Which in the case of directories, will also apply to newly
        created files/subdirectories, children of that directory.
        In the simple unaltered case of a newly created exofs, no layout
        attributes are present, and all layouts adhere to the layout specified
        at the device-table.
      
      * In case of a future file system loaded in an old exofs-driver.
        At iget(), the generating_function is inspected and if not supported
        will return an IO error to the application and the inode will not
        be loaded. So not to damage any data.
        Note: After this patch we do not yet support any type of layout
              only the RAID0 patch that enables striping at the super-block
              level will add support for RAID0 layouts above. This way we
              are past and future compatible and fully bisectable.
      
      * Access to the device table is done by an accessor since
        it will change according to above information.
      
      Signed-off-by: default avatarBoaz Harrosh <bharrosh@panasas.com>
      d9c740d2
    • Boaz Harrosh's avatar
      exofs: unindent exofs_sbi_read · 46f4d973
      Boaz Harrosh authored
      
      The original idea was that a mirror read can be sub-divided
      to multiple devices. But this has very little gain and only
      at very large IOes so it's not going to be implemented soon.
      
      Signed-off-by: default avatarBoaz Harrosh <bharrosh@panasas.com>
      46f4d973
    • Boaz Harrosh's avatar
      exofs: Move layout related members to a layout structure · 45d3abcb
      Boaz Harrosh authored
      
      * Abstract away those members in exofs_sb_info that are related/needed
        by a layout into a new exofs_layout structure. Embed it in exofs_sb_info.
      
      * At exofs_io_state receive/keep a pointer to an exofs_layout. No need for
        an exofs_sb_info pointer, all we need is at exofs_layout.
      
      * Change any usage of above exofs_sb_info members to their new name.
      
      Signed-off-by: default avatarBoaz Harrosh <bharrosh@panasas.com>
      45d3abcb
    • Boaz Harrosh's avatar
      exofs: Recover in the case of read-passed-end-of-file · 22ddc556
      Boaz Harrosh authored
      
      In check_io, implement the case of reading passed end of
      file, by clearing the pages and recover with no error. In
      a raid arrangement this can become a legitimate situation
      in case of holes in the file.
      
      Signed-off-by: default avatarBoaz Harrosh <bharrosh@panasas.com>
      22ddc556
    • Boaz Harrosh's avatar
      exofs: debug print even less · 34ce4e7c
      Boaz Harrosh authored
      
      * Last debug trimming left in some stupid print, remove them.
        Fixup some other prints
      * Shift printing from inode.c to ios.c
      * Add couple of prints when memory allocation fails.
      
      Signed-off-by: default avatarBoaz Harrosh <bharrosh@panasas.com>
      34ce4e7c
  9. Dec 10, 2009
    • Boaz Harrosh's avatar
      exofs: Multi-device mirror support · 04dc1e88
      Boaz Harrosh authored
      
      This patch changes on-disk format, it is accompanied with a parallel
      patch to mkfs.exofs that enables multi-device capabilities.
      
      After this patch, old exofs will refuse to mount a new formatted FS and
      new exofs will refuse an old format. This is done by moving the magic
      field offset inside the FSCB. A new FSCB *version* field was added. In
      the future, exofs will refuse to mount unmatched FSCB version. To
      up-grade or down-grade an exofs one must use mkfs.exofs --upgrade option
      before mounting.
      
      Introduced, a new object that contains a *device-table*. This object
      contains the default *data-map* and a linear array of devices
      information, which identifies the devices used in the filesystem. This
      object is only written to offline by mkfs.exofs. This is why it is kept
      separate from the FSCB, since the later is written to while mounted.
      
      Same partition number, same object number is used on all devices only
      the device varies.
      
      * define the new format, then load the device table on mount time make
        sure every thing is supported.
      
      * Change I/O engine to now support Mirror IO, .i.e write same data
        to multiple devices, read from a random device to spread the
        read-load from multiple clients (TODO: stripe read)
      
      Implementation notes:
       A few points introduced in previous patch should be mentioned here:
      
      * Special care was made so absolutlly all operation that have any chance
        of failing are done before any osd-request is executed. This is to
        minimize the need for a data consistency recovery, to only real IO
        errors.
      
      * Each IO state has a kref. It starts at 1, any osd-request executed
        will increment the kref, finally when all are executed the first ref
        is dropped. At IO-done, each request completion decrements the kref,
        the last one to return executes the internal _last_io() routine.
        _last_io() will call the registered io_state_done. On sync mode a
        caller does not supply a done method, indicating a synchronous
        request, the caller is put to sleep and a special io_state_done is
        registered that will awaken the caller. Though also in sync mode all
        operations are executed in parallel.
      
      Signed-off-by: default avatarBoaz Harrosh <bharrosh@panasas.com>
      04dc1e88
    • Boaz Harrosh's avatar
      exofs: Move all operations to an io_engine · 06886a5a
      Boaz Harrosh authored
      In anticipation for multi-device operations, we separate osd operations
      into an abstract I/O API. Currently only one device is used but later
      when adding more devices, we will drive all devices in parallel according
      to a "data_map" that describes how data is arranged on multiple devices.
      The file system level operates, like before, as if there is one object
      (inode-number) and an i_size. The io engine will split this to the same
      object-number but on multiple device.
      
      At first we introduce Mirror (raid 1) layout. But at the final outcome
      we intend to fully implement the pNFS-Objects data-map, including
      raid 0,4,5,6 over mirrored devices, over multiple device-groups. And
      more. See: http://tools.ietf.org/html/draft-ietf-nfsv4-pnfs-obj-12
      
      
      
      * Define an io_state based API for accessing osd storage devices
        in an abstract way.
        Usage:
      	First a caller allocates an io state with:
      		exofs_get_io_state(struct exofs_sb_info *sbi,
      				   struct exofs_io_state** ios);
      
      	Then calles one of:
      		exofs_sbi_create(struct exofs_io_state *ios);
      		exofs_sbi_remove(struct exofs_io_state *ios);
      		exofs_sbi_write(struct exofs_io_state *ios);
      		exofs_sbi_read(struct exofs_io_state *ios);
      		exofs_oi_truncate(struct exofs_i_info *oi, u64 new_len);
      
      	And when done
      		exofs_put_io_state(struct exofs_io_state *ios);
      
      * Convert all source files to use this new API
      * Convert from bio_alloc to bio_kmalloc
      * In io engine we make use of the now fixed osd_req_decode_sense
      
      There are no functional changes or on disk additions after this patch.
      
      Signed-off-by: default avatarBoaz Harrosh <bharrosh@panasas.com>
      06886a5a
    • Boaz Harrosh's avatar
      exofs: move osd.c to ios.c · 8ce9bdd1
      Boaz Harrosh authored
      
      If I do a "git mv" together with a massive code change
      and commit in one patch, git looses the rename and
      records a delete/new instead. This is bad because I want
      a rename recorded so later rebased/cherry-picked patches
      to the old name will work. Also the --follow is lost.
      
      Signed-off-by: default avatarBoaz Harrosh <bharrosh@panasas.com>
      8ce9bdd1
  10. Jun 21, 2009
  11. Jun 10, 2009
  12. May 11, 2009
    • Tejun Heo's avatar
      block: add rq->resid_len · c3a4d78c
      Tejun Heo authored
      
      rq->data_len served two purposes - the length of data buffer on issue
      and the residual count on completion.  This duality creates some
      headaches.
      
      First of all, block layer and low level drivers can't really determine
      what rq->data_len contains while a request is executing.  It could be
      the total request length or it coulde be anything else one of the
      lower layers is using to keep track of residual count.  This
      complicates things because blk_rq_bytes() and thus
      [__]blk_end_request_all() relies on rq->data_len for PC commands.
      Drivers which want to report residual count should first cache the
      total request length, update rq->data_len and then complete the
      request with the cached data length.
      
      Secondly, it makes requests default to reporting full residual count,
      ie. reporting that no data transfer occurred.  The residual count is
      an exception not the norm; however, the driver should clear
      rq->data_len to zero to signify the normal cases while leaving it
      alone means no data transfer occurred at all.  This reverse default
      behavior complicates code unnecessarily and renders block PC on some
      drivers (ide-tape/floppy) unuseable.
      
      This patch adds rq->resid_len which is used only for residual count.
      
      While at it, remove now unnecessasry blk_rq_bytes() caching in
      ide_pc_intr() as rq->data_len is not changed anymore.
      
      Boaz	: spotted missing conversion in osd
      Sergei	: spotted too early conversion to blk_rq_bytes() in ide-tape
      
      [ Impact: cleanup residual count handling, report 0 resid by default ]
      
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
      Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      Cc: Borislav Petkov <petkovbb@googlemail.com>
      Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
      Cc: Mike Miller <mike.miller@hp.com>
      Cc: Eric Moore <Eric.Moore@lsi.com>
      Cc: Alan Stern <stern@rowland.harvard.edu>
      Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
      Cc: Doug Gilbert <dgilbert@interlog.com>
      Cc: Mike Miller <mike.miller@hp.com>
      Cc: Eric Moore <Eric.Moore@lsi.com>
      Cc: Darrick J. Wong <djwong@us.ibm.com>
      Cc: Pete Zaitcev <zaitcev@redhat.com>
      Cc: Boaz Harrosh <bharrosh@panasas.com>
      Signed-off-by: default avatarJens Axboe <jens.axboe@oracle.com>
      c3a4d78c
  13. Mar 31, 2009
Loading