Skip to content
Snippets Groups Projects
Select Git revision
  • 1ca002adce955d9f0769e8830a62a50fb039d09d
  • vme-testing default
  • ci-test
  • master
  • remoteproc
  • am625-sk-ov5640
  • pcal6534-upstreaming
  • lps22df-upstreaming
  • msc-upstreaming
  • imx8mp
  • iio/noa1305
  • vme-next
  • vme-next-4.14-rc4
  • v4.14-rc4
  • v4.14-rc3
  • v4.14-rc2
  • v4.14-rc1
  • v4.13
  • vme-next-4.13-rc7
  • v4.13-rc7
  • v4.13-rc6
  • v4.13-rc5
  • v4.13-rc4
  • v4.13-rc3
  • v4.13-rc2
  • v4.13-rc1
  • v4.12
  • v4.12-rc7
  • v4.12-rc6
  • v4.12-rc5
  • v4.12-rc4
  • v4.12-rc3
32 results

display

  • Clone with SSH
  • Clone with HTTPS
  • user avatar
    Hans de Goede authored
    Commit 82daca29 ("drm/i915: Add "panel orientation" property to the
    panel connector, v6.") uses hardware state readback to determine if the
    GOP is rotating the image by 180 degrees to compensate for upside-down
    mounted panels.
    
    When I wrote that commit I tried to find the VBT bits the GOP used to
    decide to rotate the image, but I could not find them. Back then I only
    looked at the rotation bits in struct mipi_config and these read 0 on
    the 1 BYT device I have with an upside-down mounted panel
    (a GP-electronic T701 tablet). While working on a similar problem on a
    BYT device with an eDP panel I noticed that the new
    intel_dsi_get_panel_orientation() helper which gets used on newer
    SoCs (Apollo-Lake, etc.) checks the rotate_180 bit in the
    BDB_GENERAL_FEATURES VBT block.
    
    I've checked and this bit indeed is set on the GP-electronic T701 tablet,
    so using the generic intel_dsi_get_panel_orientation() helper there does
    the right thing without needing any extra readback of hw state.
    
    This commit removes the special handling of the panel orientation for
    DSI panels on BYT/CHT devices, bringing the handling in line with the
    handling of DSI panels on other devices.
    
    Reviewed-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
    Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20200228114110.187792-2-hdegoede@redhat.com
    1ca002ad
    History
    Name Last commit Last update
    ..