Skip to content
Snippets Groups Projects
  • jshin@chromium.org's avatar
    65127279
    Clean up third_party/cld. · 65127279
    jshin@chromium.org authored
    1. Remove files we don't use that come from toolbar
    2. Simplify the directory structure by removing the redundant
    intermediary directories bar/toolbar/cld/i18n
    
    This will bring CLD a step closer to where it can be open-sourced separately (or along with CED for encoding detection.). It's not there yet.
    
    
    In addition to the clean-up, change |LanguageCode*| return 
    'nb', 'he', 'fil' instead of 'no', 'iw', and 'tl'. 
    
    Also, use LanguageCodeWithDialects instead of LanguageCode to get 'zh-CN' 
    instead of 'zh'. This is to simplify the 3-way mapping between 
    Chrome's UI locale code, CLD's language code and what's accepted by 
    Google Translate. It's also another preparation for open-sourcing because
    we'd better use the standard code rather than the obsolete code like 'iw'
    when open-sourcing.
    
    BUG=32759, 33613
    TEST=third_party/cld builds on all platforms and pass the following tests:
    - unit_tests: Extension*.DetectTabLanguage and CompactLangDetTest.* 
    - browser_tests: ExtensionBrowserTest.Toolstrip
    
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38146 0039d316-1c4b-4281-b951-d872f2087c98
    65127279
    History
    Clean up third_party/cld.
    jshin@chromium.org authored
    1. Remove files we don't use that come from toolbar
    2. Simplify the directory structure by removing the redundant
    intermediary directories bar/toolbar/cld/i18n
    
    This will bring CLD a step closer to where it can be open-sourced separately (or along with CED for encoding detection.). It's not there yet.
    
    
    In addition to the clean-up, change |LanguageCode*| return 
    'nb', 'he', 'fil' instead of 'no', 'iw', and 'tl'. 
    
    Also, use LanguageCodeWithDialects instead of LanguageCode to get 'zh-CN' 
    instead of 'zh'. This is to simplify the 3-way mapping between 
    Chrome's UI locale code, CLD's language code and what's accepted by 
    Google Translate. It's also another preparation for open-sourcing because
    we'd better use the standard code rather than the obsolete code like 'iw'
    when open-sourcing.
    
    BUG=32759, 33613
    TEST=third_party/cld builds on all platforms and pass the following tests:
    - unit_tests: Extension*.DetectTabLanguage and CompactLangDetTest.* 
    - browser_tests: ExtensionBrowserTest.Toolstrip
    
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38146 0039d316-1c4b-4281-b951-d872f2087c98