Skip to content
Snippets Groups Projects
Commit 06bdc8d8 authored by willchan@chromium.org's avatar willchan@chromium.org
Browse files

Fix SPDY crash on race when canceling a stream that just got created.

When I fixed the code not to be re-entrant (since that caused crashes) in r61880, I created a window when the pending create callback was posted to the MessageLoop to be run on the next iteration.  In this window before it actually gets invoked, if the pending stream creation got cancelled, then the callback wasn't cancelled, so we would execute a callback on a cancelled stream creation, which can cause crashes.

The fix is to keep track of the pending callbacks.  Cancellation of pending stream creations check this pending callback map first.

BUG=63532
TEST=See bug thread for repro steps.  New unit test added as well.

Review URL: http://codereview.chromium.org/5174005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66630 0039d316-1c4b-4281-b951-d872f2087c98
parent 983b8ad8
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment