Fix and re-enable a test I broke with the find bar changes I made last night.
Remove Browser::find_bar(), make everyone use either Browser::GetFindBarController() which creates the FindBarController on demand, or a new method HasFindBarController(), which can be used to check for its existence (so as to avoid creating it unnecessarily). http://crbug.com/26231 TEST=interactive ui tests, standard find tests Review URL: http://codereview.chromium.org/348015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30507 0039d316-1c4b-4281-b951-d872f2087c98
Showing
- chrome/browser/browser.cc 5 additions, 1 deletionchrome/browser/browser.cc
- chrome/browser/browser.h 7 additions, 2 deletionschrome/browser/browser.h
- chrome/browser/cocoa/tab_strip_controller.mm 1 addition, 1 deletionchrome/browser/cocoa/tab_strip_controller.mm
- chrome/browser/gtk/browser_window_gtk.cc 1 addition, 1 deletionchrome/browser/gtk/browser_window_gtk.cc
- chrome/browser/views/find_bar_host_browsertest.cc 2 additions, 2 deletionschrome/browser/views/find_bar_host_browsertest.cc
- chrome/browser/views/find_bar_host_interactive_uitest.cc 7 additions, 6 deletionschrome/browser/views/find_bar_host_interactive_uitest.cc
- chrome/browser/views/frame/browser_view.cc 4 additions, 3 deletionschrome/browser/views/frame/browser_view.cc
Loading
Please register or sign in to comment