Skip to content
Snippets Groups Projects
Commit 42fa4c2f authored by Thomas Nguyen's avatar Thomas Nguyen Committed by Chromium LUCI CQ
Browse files

Reland "[PEPC] Snapshot permission statuses at commit navigation"

This is a reland of commit 1924a27a
Changes compared to original CL:
- A null check for the frame (when we moved stuff from AttachLayout to
InsertedInto)
- Remove conditions CHECKs when calling UnregisterClient

Original change's description:
> [PEPC] Snapshot permission statuses at commit navigation
>
> When <permission> element is added to the DOM, we'll use IPC to check
> the permission status and it'll update when the IPC callback is
> triggered. This might cause a flicker if the status changes from ASK
> to GRANTED.
>
> We propose to snapshot permission statuses and cache the statuses at
> the execution context, outlined in: https://docs.google.com/document/d/1pfuiJ7BIdX0dxMzboYIOvPV1mFKQ3HE_11VQNeBJSCc/edit?resourcekey=0-9el74tCe5opJXh3CIPyPGA&tab=t.0#heading=h.8zmwced28dbp
>
> Bug: 368238224
> Change-Id: Ib319301d0b9bedb07502a09b4f030d3e40844ea2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5905369


> Reviewed-by: default avatarThomas Nguyen <tungnh@chromium.org>
> Commit-Queue: Thomas Nguyen <tungnh@chromium.org>
> Reviewed-by: default avatarDave Tapuska <dtapuska@chromium.org>
> Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
> Reviewed-by: default avatarFrancois Pierre Doray <fdoray@chromium.org>
> Auto-Submit: Thomas Nguyen <tungnh@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1372969}

Bug: 368238224
Change-Id: Idb09359fa342393a6fa0956d057955c45e68e723
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5972695


Reviewed-by: default avatarFrancois Pierre Doray <fdoray@chromium.org>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Commit-Queue: Thomas Nguyen <tungnh@chromium.org>
Reviewed-by: default avatarAndy Paicu <andypaicu@chromium.org>
Reviewed-by: default avatarDave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1378977}
parent e2c06649
No related branches found
No related tags found
No related merge requests found
Showing
with 817 additions and 141 deletions
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment