Bookmark bar menu/folder button text is left-aligned, not centered.
Bookmark bar menu/folder maximum window width is now 1000, not 150. High cosmetic impact. BUG=36487, 17608 TEST=\ 1) Add bookmarks on the bar with small (e.g. 'x') and big titles. Make sure all looks OK (e.g. small ones are small.) 2) Add bookmarks in a folder. Make sure text is left aligned on the menus. 3) Add bookmarks in a folder with long names (e.g. 100 characters). Make sure folder/menus are now much wider. 4) Add bookmarks in a folder with mega long names (e.g. 4000 characters). Make sure menus have a maximum size of ~1000 pixes (no need to be exact but 'no limit' is fail). 5) In a folder, add a subfolder named 'x' and a bookmark with a REAL long name. Make sure the "button" (menu item) is the full width of the menu. Review URL: http://codereview.chromium.org/842005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41387 0039d316-1c4b-4281-b951-d872f2087c98
Showing
- chrome/browser/cocoa/bookmark_bar_controller.h 7 additions, 0 deletionschrome/browser/cocoa/bookmark_bar_controller.h
- chrome/browser/cocoa/bookmark_bar_folder_controller.mm 57 additions, 20 deletionschrome/browser/cocoa/bookmark_bar_folder_controller.mm
- chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm 31 additions, 3 deletions.../browser/cocoa/bookmark_bar_folder_controller_unittest.mm
- chrome/browser/cocoa/bookmark_button_cell.mm 1 addition, 1 deletionchrome/browser/cocoa/bookmark_button_cell.mm
Loading
Please register or sign in to comment