Fix bug with context menus in incognito mode.
If an extension uses "spanning" mode, the context menu items are shared between profiles. If an extension uses "split" mode, the items are separate per profile. In either case, they only appear in incognito if the extension is enabled in incognito. Also fixed a minor bug, so that tabs.create now can open extension URLs in incognito if the extension uses split mode. BUG=61147 TEST=see bug for repro steps; context menu items should work in incognito mode Review URL: http://codereview.chromium.org/4090011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64812 0039d316-1c4b-4281-b951-d872f2087c98
Showing
- chrome/browser/extensions/extension_context_menu_api.cc 14 additions, 15 deletionschrome/browser/extensions/extension_context_menu_api.cc
- chrome/browser/extensions/extension_context_menu_browsertest.cc 66 additions, 7 deletions.../browser/extensions/extension_context_menu_browsertest.cc
- chrome/browser/extensions/extension_event_router.cc 18 additions, 11 deletionschrome/browser/extensions/extension_event_router.cc
- chrome/browser/extensions/extension_event_router.h 7 additions, 0 deletionschrome/browser/extensions/extension_event_router.h
- chrome/browser/extensions/extension_menu_manager.cc 35 additions, 2 deletionschrome/browser/extensions/extension_menu_manager.cc
- chrome/browser/extensions/extension_menu_manager.h 15 additions, 4 deletionschrome/browser/extensions/extension_menu_manager.h
- chrome/browser/extensions/extension_menu_manager_unittest.cc 3 additions, 3 deletionschrome/browser/extensions/extension_menu_manager_unittest.cc
- chrome/browser/extensions/extension_tabs_module.cc 3 additions, 2 deletionschrome/browser/extensions/extension_tabs_module.cc
- chrome/browser/extensions/extension_test_message_listener.cc 1 addition, 1 deletionchrome/browser/extensions/extension_test_message_listener.cc
- chrome/browser/extensions/extension_test_message_listener.h 2 additions, 0 deletionschrome/browser/extensions/extension_test_message_listener.h
- chrome/browser/tab_contents/render_view_context_menu.cc 20 additions, 8 deletionschrome/browser/tab_contents/render_view_context_menu.cc
- chrome/browser/tab_contents/render_view_context_menu.h 1 addition, 0 deletionschrome/browser/tab_contents/render_view_context_menu.h
- chrome/test/data/extensions/context_menus/incognito/background.html 1 addition, 0 deletions...t/data/extensions/context_menus/incognito/background.html
- chrome/test/data/extensions/context_menus/incognito/manifest.json 7 additions, 0 deletions...est/data/extensions/context_menus/incognito/manifest.json
- chrome/test/data/extensions/context_menus/incognito/test.js 19 additions, 0 deletionschrome/test/data/extensions/context_menus/incognito/test.js
Loading
Please register or sign in to comment