Skip to content
Snippets Groups Projects
Commit 726a65b4 authored by pkasting@chromium.org's avatar pkasting@chromium.org
Browse files

Fix unittest to not use an invalid GURL, as the underlying bookmarks APIs...

Fix unittest to not use an invalid GURL, as the underlying bookmarks APIs expect callers to not do that (they NOTREACHED()).  This URL is more like the real cases the original patch that added this test was trying to handle.

BUG=56967
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/3439028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60740 0039d316-1c4b-4281-b951-d872f2087c98
parent 929935b8
No related branches found
No related tags found
No related merge requests found
...@@ -141,7 +141,7 @@ class BookmarksObserver : public BookmarksExportObserver { ...@@ -141,7 +141,7 @@ class BookmarksObserver : public BookmarksExportObserver {
// Tests bookmark_html_writer by populating a BookmarkModel, writing it out by // Tests bookmark_html_writer by populating a BookmarkModel, writing it out by
// way of bookmark_html_writer, then using the importer to read it back in. // way of bookmark_html_writer, then using the importer to read it back in.
TEST_F(BookmarkHTMLWriterTest, DISABLED_Test) { TEST_F(BookmarkHTMLWriterTest, Test) {
MessageLoop message_loop; MessageLoop message_loop;
ChromeThread fake_ui_thread(ChromeThread::UI, &message_loop); ChromeThread fake_ui_thread(ChromeThread::UI, &message_loop);
ChromeThread fake_file_thread(ChromeThread::FILE, &message_loop); ChromeThread fake_file_thread(ChromeThread::FILE, &message_loop);
...@@ -186,7 +186,7 @@ TEST_F(BookmarkHTMLWriterTest, DISABLED_Test) { ...@@ -186,7 +186,7 @@ TEST_F(BookmarkHTMLWriterTest, DISABLED_Test) {
GURL url1_favicon("http://url1/icon.ico"); GURL url1_favicon("http://url1/icon.ico");
GURL url2("http://url2"); GURL url2("http://url2");
GURL url3("http://url3"); GURL url3("http://url3");
GURL url4("http://\"&;\""); GURL url4("javascript:alert(\"Hello!\");");
base::Time t1(base::Time::Now()); base::Time t1(base::Time::Now());
base::Time t2(t1 + base::TimeDelta::FromHours(1)); base::Time t2(t1 + base::TimeDelta::FromHours(1));
base::Time t3(t1 + base::TimeDelta::FromHours(1)); base::Time t3(t1 + base::TimeDelta::FromHours(1));
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment