Skip to content
Snippets Groups Projects
Commit be559e44 authored by scottbyer@google.com's avatar scottbyer@google.com
Browse files

Minimum UI change for Cloud Print dialog.

Minimum change to remove the title and get the initial dialog size correct.
Still has gobs of whitespace at the top.

BUG=chromium-os:8494
TEST=none

Review URL: http://codereview.chromium.org/4146015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64807 0039d316-1c4b-4281-b951-d872f2087c98
parent 841daf1d
No related merge requests found
......@@ -425,7 +425,7 @@ bool CloudPrintHtmlDialogDelegate::IsDialogModal() const {
}
std::wstring CloudPrintHtmlDialogDelegate::GetDialogTitle() const {
return l10n_util::GetString(IDS_CLOUD_PRINT_TITLE);
return std::wstring();
}
GURL CloudPrintHtmlDialogDelegate::GetDialogContentURL() const {
......@@ -497,7 +497,7 @@ PrintDialogCloud::PrintDialogCloud(const FilePath& path_to_pdf)
// contents, and take the screen size into account.
HtmlDialogUIDelegate* dialog_delegate =
new internal_cloud_print_helpers::CloudPrintHtmlDialogDelegate(
path_to_pdf, 500, 400, std::string(), print_job_title);
path_to_pdf, 497, 354, std::string(), print_job_title);
browser_->BrowserShowHtmlDialog(dialog_delegate, NULL);
}
......
......@@ -300,7 +300,7 @@ TEST_F(CloudPrintHtmlDialogDelegateTest, BasicChecks) {
EXPECT_TRUE(delegate_->IsDialogModal());
EXPECT_THAT(delegate_->GetDialogContentURL().spec(),
StrEq(chrome::kCloudPrintResourcesURL));
EXPECT_THAT(delegate_->GetDialogTitle(), HasSubstr(L"Print"));
EXPECT_TRUE(delegate_->GetDialogTitle().empty());
bool close_dialog = false;
delegate_->OnCloseContents(NULL, &close_dialog);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment