Skip to content
Snippets Groups Projects
Commit c18215ab authored by robertshield@chromium.org's avatar robertshield@chromium.org
Browse files

Remove a DCHECK when failing to secure the shared memory used to hold the...

Remove a DCHECK when failing to secure the shared memory used to hold the current version. This may well fail on older (read non-NTFS) systems since you can't secure file mappings without a securable file system underneath.

BUG=61609
TEST=No DCHECKing at startup when running on a non-NTFS system.

Review URL: http://codereview.chromium.org/5057007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66322 0039d316-1c4b-4281-b951-d872f2087c98
parent 52d2c8e0
No related branches found
No related tags found
No related merge requests found
......@@ -148,9 +148,10 @@ bool DllRedirector::RegisterAsFirstCFModule() {
if (result) {
// We created the beacon, now we need to mutate the security attributes
// on the shared memory to allow read-only access and let low-integrity
// processes open it.
bool acls_set = SetFileMappingToReadOnly(shared_memory_->handle());
DCHECK(acls_set);
// processes open it. This will fail on FAT32 file systems.
if (!SetFileMappingToReadOnly(shared_memory_->handle())) {
DLOG(ERROR) << "Failed to set file mapping permissions.";
}
} else {
created_beacon = false;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment