[tabbed options] more work on content settings exceptions lists
- tie "edit" mode to "selected" -- selecting enters into edit mode -- blurring exits edit mode and deselects - fix up layout within rows (faux columns) - add a special "add new exception" row (this should be at the bottom of the table, but it's currently at the top) - change behavior when the user attempts to commit an invalid exception. Instead of trying to regrab focus, just revert the row to its previous state. TODO: list should be sized dynamically, i.e. no scrollbar. TODO: list should be in sub-sub dialog TODO: rows should have delete X BUG=64153 TEST=manual Review URL: http://codereview.chromium.org/5699004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69332 0039d316-1c4b-4281-b951-d872f2087c98
Showing
- chrome/app/generated_resources.grd 4 additions, 1 deletionchrome/app/generated_resources.grd
- chrome/browser/dom_ui/options/content_settings_handler.cc 2 additions, 0 deletionschrome/browser/dom_ui/options/content_settings_handler.cc
- chrome/browser/resources/options/content_settings.js 5 additions, 5 deletionschrome/browser/resources/options/content_settings.js
- chrome/browser/resources/options/content_settings_exceptions_area.css 6 additions, 4 deletions...er/resources/options/content_settings_exceptions_area.css
- chrome/browser/resources/options/content_settings_exceptions_area.js 198 additions, 118 deletions...ser/resources/options/content_settings_exceptions_area.js
- chrome/browser/resources/options/options_page.css 1 addition, 1 deletionchrome/browser/resources/options/options_page.css
- chrome/browser/resources/shared/js/cr/ui/list.js 4 additions, 2 deletionschrome/browser/resources/shared/js/cr/ui/list.js
Loading
Please register or sign in to comment