Skip to content
Snippets Groups Projects
Commit cd88b0c7 authored by eroman@chromium.org's avatar eroman@chromium.org
Browse files

Add an additional unit-test for when PAC script is missing newline.

This variation uses a statement without semi-colon, rather than a comment, as the last line.

BUG=http://crbug.com/22864

Review URL: http://codereview.chromium.org/238004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27171 0039d316-1c4b-4281-b951-d872f2087c98
parent 237a44a3
No related merge requests found
// Ends with a statement, and no terminal newline.
function FindProxyForURL(url, host) { return "PROXY success:" + x; }
x = 3
\ No newline at end of file
......@@ -420,11 +420,11 @@ TEST(ProxyResolverV8Test, LoadLog) {
LoadLog::PHASE_END);
}
// Try loading a PAC script which ends with a trailing comment (no terminal
// newline). This should not cause problems with the PAC utility functions
// that we add to the script.
// Try loading a PAC script that ends with a comment and has no terminal
// newline. This should not cause problems with the PAC utility functions
// that we add to the script's environment.
// http://crbug.com/22864
TEST(ProxyResolverV8Test, TrailingComment) {
TEST(ProxyResolverV8Test, EndsWithCommentNoNewline) {
ProxyResolverV8WithMockBindings resolver;
int result = resolver.SetPacScriptFromDisk("ends_with_comment.js");
EXPECT_EQ(OK, result);
......@@ -438,5 +438,24 @@ TEST(ProxyResolverV8Test, TrailingComment) {
EXPECT_EQ("success:80", proxy_info.proxy_server().ToURI());
}
// Try loading a PAC script that ends with a statement and has no terminal
// newline. This should not cause problems with the PAC utility functions
// that we add to the script's environment.
// http://crbug.com/22864
TEST(ProxyResolverV8Test, EndsWithStatementNoNewline) {
ProxyResolverV8WithMockBindings resolver;
int result = resolver.SetPacScriptFromDisk(
"ends_with_statement_no_semicolon.js");
EXPECT_EQ(OK, result);
ProxyInfo proxy_info;
scoped_refptr<LoadLog> log(new LoadLog);
result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, log);
EXPECT_EQ(OK, result);
EXPECT_FALSE(proxy_info.is_direct());
EXPECT_EQ("success:3", proxy_info.proxy_server().ToURI());
}
} // namespace
} // namespace net
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment