Address ExtensionApiTest.Tabs flakiness
This addresses two problems. (1) relativeUrlTabsUpdate could fail because it was depending on testTabId getting set from relativeUrlTabsCreate, which may have happened out of order. I have refactored the callback blocking so additional blocks can be created with chrome.test.callbackAdded(). (2) tabs.update({url:}) is still failing intermitantly. This changes addeds valid html files in the extension which can be navitation targets (previously, non-existent urls had been used), in the hopes that the random failures had to do with load errors. BUG=20828 Review URL: http://codereview.chromium.org/195090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26258 0039d316-1c4b-4281-b951-d872f2087c98
Showing
- chrome/browser/extensions/extension_tabs_apitest.cc 1 addition, 2 deletionschrome/browser/extensions/extension_tabs_apitest.cc
- chrome/renderer/renderer_resources.grd 1 addition, 1 deletionchrome/renderer/renderer_resources.grd
- chrome/renderer/resources/extension_apitest.js 12 additions, 13 deletionschrome/renderer/resources/extension_apitest.js
- chrome/test/data/extensions/api_test/tabs/a.html 5 additions, 0 deletionschrome/test/data/extensions/api_test/tabs/a.html
- chrome/test/data/extensions/api_test/tabs/b.html 5 additions, 0 deletionschrome/test/data/extensions/api_test/tabs/b.html
- chrome/test/data/extensions/api_test/tabs/c.html 5 additions, 0 deletionschrome/test/data/extensions/api_test/tabs/c.html
- chrome/test/data/extensions/api_test/tabs/d.html 5 additions, 0 deletionschrome/test/data/extensions/api_test/tabs/d.html
- chrome/test/data/extensions/api_test/tabs/e.html 5 additions, 0 deletionschrome/test/data/extensions/api_test/tabs/e.html
- chrome/test/data/extensions/api_test/tabs/f.html 5 additions, 0 deletionschrome/test/data/extensions/api_test/tabs/f.html
- chrome/test/data/extensions/api_test/tabs/test.js 41 additions, 33 deletionschrome/test/data/extensions/api_test/tabs/test.js
Loading
Please register or sign in to comment