Revert 68944 - Revert "Add named testing interface."
Reverting the revert of named interface CL. Followup CL which addresses Pawel's comments is up at http://codereview.chromium.org/5967003/ http://src.chromium.org/viewvc/chrome?view=rev&revision=67300 The change has been approved conditionally, i.e. if the outstanding review comments are handled in a follow-up as the top priority. Two weeks have passed, and I have not seen the follow-up. It is risky to keep this change in the tree, as it is already non-trivial to revert. Conflicts: chrome/browser/automation/automation_provider.cc chrome/test/ui/named_interface_uitest.cc ipc/ipc_channel_posix.cc TBR=nirnimesh BUG=chromium-os:8512 TEST=none Review URL: http://codereview.chromium.org/5707006 TBR=phajdan.jr@chromium.org BUG=chromium-os:8512 TEST=ui_tests --gtest_filter=NamedInterfaceTest.FLAKY_BasicNamedInterface Review URL: http://codereview.chromium.org/6012006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70089 0039d316-1c4b-4281-b951-d872f2087c98
Showing
- chrome/browser/automation/automation_provider.cc 47 additions, 14 deletionschrome/browser/automation/automation_provider.cc
- chrome/browser/automation/automation_provider.h 20 additions, 4 deletionschrome/browser/automation/automation_provider.h
- chrome/browser/automation/automation_provider_observers.cc 1 addition, 1 deletionchrome/browser/automation/automation_provider_observers.cc
- chrome/browser/ui/browser_init.cc 15 additions, 8 deletionschrome/browser/ui/browser_init.cc
- chrome/browser/ui/browser_init.h 1 addition, 1 deletionchrome/browser/ui/browser_init.h
- chrome/chrome_tests.gypi 9 additions, 0 deletionschrome/chrome_tests.gypi
- chrome/common/automation_constants.cc 8 additions, 1 deletionchrome/common/automation_constants.cc
- chrome/common/automation_constants.h 9 additions, 1 deletionchrome/common/automation_constants.h
- chrome/test/automation/automation_proxy.cc 7 additions, 7 deletionschrome/test/automation/automation_proxy.cc
- chrome/test/automation/automation_proxy.h 11 additions, 7 deletionschrome/test/automation/automation_proxy.h
- chrome/test/automation/automation_proxy_uitest.cc 32 additions, 3 deletionschrome/test/automation/automation_proxy_uitest.cc
- chrome/test/automation/automation_proxy_uitest.h 4 additions, 3 deletionschrome/test/automation/automation_proxy_uitest.h
- chrome/test/automation/proxy_launcher.cc 75 additions, 0 deletionschrome/test/automation/proxy_launcher.cc
- chrome/test/automation/proxy_launcher.h 78 additions, 0 deletionschrome/test/automation/proxy_launcher.h
- chrome/test/ui/named_interface_uitest.cc 49 additions, 0 deletionschrome/test/ui/named_interface_uitest.cc
- chrome/test/ui/ui_test.cc 39 additions, 21 deletionschrome/test/ui/ui_test.cc
- chrome/test/ui/ui_test.h 19 additions, 8 deletionschrome/test/ui/ui_test.h
- chrome_frame/chrome_frame.gyp 3 additions, 0 deletionschrome_frame/chrome_frame.gyp
- chrome_frame/chrome_frame_automation.cc 8 additions, 3 deletionschrome_frame/chrome_frame_automation.cc
- chrome_frame/chrome_frame_automation.h 1 addition, 0 deletionschrome_frame/chrome_frame_automation.h
Loading
Please register or sign in to comment