Skip to content
Snippets Groups Projects
Commit dfe0debf authored by nirnimesh@chromium.org's avatar nirnimesh@chromium.org
Browse files

Revert 68944 - Revert "Add named testing interface."

Reverting the revert of named interface CL. Followup CL which addresses Pawel's comments is up at
http://codereview.chromium.org/5967003/

http://src.chromium.org/viewvc/chrome?view=rev&revision=67300

The change has been approved conditionally,
i.e. if the outstanding review comments are handled
in a follow-up as the top priority.

Two weeks have passed, and I have not seen the follow-up.
It is risky to keep this change in the tree, as it is already
non-trivial to revert.

Conflicts:

  chrome/browser/automation/automation_provider.cc
  chrome/test/ui/named_interface_uitest.cc
  ipc/ipc_channel_posix.cc

TBR=nirnimesh

BUG=chromium-os:8512
TEST=none

Review URL: http://codereview.chromium.org/5707006

TBR=phajdan.jr@chromium.org

BUG=chromium-os:8512
TEST=ui_tests --gtest_filter=NamedInterfaceTest.FLAKY_BasicNamedInterface

Review URL: http://codereview.chromium.org/6012006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70089 0039d316-1c4b-4281-b951-d872f2087c98
parent 70ff5a3d
No related branches found
No related tags found
Loading
Showing
with 436 additions and 82 deletions
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment