- Aug 05, 2010
-
-
atwilson@chromium.org authored
TBR=pfeldman Review URL: http://codereview.chromium.org/2884065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55005 0039d316-1c4b-4281-b951-d872f2087c98
-
- Aug 04, 2010
-
-
sergeyu@chromium.org authored
TEST=heapcheck with remoting_unittest BUG=None TBR: ajwong git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55003 0039d316-1c4b-4281-b951-d872f2087c98
-
pathorn@chromium.org authored
BUG=none TEST=collada mesh with bumpUV enabled and using the lambert shader. Review URL: http://codereview.chromium.org/3063018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55001 0039d316-1c4b-4281-b951-d872f2087c98
-
alyssad@chromium.org authored
This hook allows tests to select a different "to" language from the drop-down. Review URL: http://codereview.chromium.org/3078026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55000 0039d316-1c4b-4281-b951-d872f2087c98
-
asargent@chromium.org authored
This changes the mediaType parameter values to be lowercase (eg "audio" instead of "AUDIO"), and changes mainFrameUrl to be pageUrl as the design doc had intended. BUG=49725 TEST=In onclick handlers, values for mediaType should be lowercase and there should be a pageUrl property matching the url of the page. Review URL: http://codereview.chromium.org/3017056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54999 0039d316-1c4b-4281-b951-d872f2087c98
-
bryner@chromium.org authored
The underlying cause of these errors was fixed in http://codereview.chromium.org/2873081/show . BUG=none TEST=valgrind tests pass Review URL: http://codereview.chromium.org/3033044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54997 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
This is the part 2 of this series. More two comming. Splitting this into small parts, so it is more easy to review and reduce the size of the CL. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3035050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54996 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
Suppresses leaks apparently introduced in revision 54981. http://codereview.chromium.org/3035035 BUG=51218 TEST=Valgrind should go green. Review URL: http://codereview.chromium.org/3075021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54995 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
BUG=None TEST=unittests Review URL: http://codereview.chromium.org/3087003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54991 0039d316-1c4b-4281-b951-d872f2087c98
-
pathorn@chromium.org authored
This CL adds the Matrix4Translation, Matrix4Scale and Matrix4AxisRotation, which are used by some collada meshes. BUG=none TEST=Convert and load an animated collada mesh. Review URL: http://codereview.chromium.org/3029050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54990 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
CopyDirectory fails only on windows in this case. Not sure how it passed the try bots. TBR=stuartmorgan Review URL: http://codereview.chromium.org/2856088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54989 0039d316-1c4b-4281-b951-d872f2087c98
-
gene@chromium.org authored
BUG=none TEST=Run linux Chrome with sandbox and verify internal PDF viewer displaying PDFs. Review URL: http://codereview.chromium.org/3081013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54986 0039d316-1c4b-4281-b951-d872f2087c98
-
davemoore@chromium.org authored
BUG=NONE TEST=Valgrind builders no longer show error TBR: cmasone Review URL: http://codereview.chromium.org/3020066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54984 0039d316-1c4b-4281-b951-d872f2087c98
-
hclam@chromium.org authored
BUG=44891 TEST=Can play live stream http://195.10.10.75:8800/live.webm This patch allows a live WebM stream to be played. After demuxing by FFmpeg, the duration was set to an invalid value. This makes the video pipeline to set duration to 0, and so WebKit never allows us to play because currentTime == duration all the time. This patch sets duration to an infinite value when duration is reported as invalid in FFmpeg. Review URL: http://codereview.chromium.org/3031036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54983 0039d316-1c4b-4281-b951-d872f2087c98
-
satish@chromium.org authored
Please advise if any of the code needs to be within "#if ENABLE_INPUT_SPEECH", since most of the speech input code in webkit is under "#if ENABLE(INPUT_SPEECH)" - Created renderer/SpeechInputDispatcher, implements WebKit::WebSpeechInputController which is used by WebView for invoking speech input. - Created browser/speech/SpeechInputDispatcherHost to receive IPC messages from the above SpeechInputDispatcher. Nothing done yet apart from receiving the messages. - Creates new directory chrome/browser/speech, this will be used for SpeechInputDispatcherHost, network based speech recognizer, speech audio recording/buffering code as well as speech output (Text-to-speech) code in future. BUG=none TEST=no functionality to test yet. Review URL: http://codereview.chromium.org/3035035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54981 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
signature of ASCIIToWide to no longer take a string piece. This changed the behavior for NULL handling (NULL is no longer supported). This change just doesn't do any conversion if the source is NULL. BUG=51185 TEST=none Review URL: http://codereview.chromium.org/2819090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54980 0039d316-1c4b-4281-b951-d872f2087c98
-
stoyan@chromium.org authored
Review URL: http://codereview.chromium.org/3038049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54979 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
Instead, we add a test dedicated to verifying the QPC time drift. Otherwise the assertion is being flakily hit in unrelated tests, which crashes the entire test binary. With a dedicated test, we still have necessary monitoring, but it's in one place. TEST=base_unittests, net_unittests (stop crashing) BUG=none Review URL: http://codereview.chromium.org/3082014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54978 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@google.com authored
Rearranges the autocomplete heuristics to reject malformed IP addresses before accepting them based on having a port or a username or a password. BUG=12305 TEST=AutocompleteTest.InputType Review URL: http://codereview.chromium.org/2868085 Patch from Ilya Sherman <isherman@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54977 0039d316-1c4b-4281-b951-d872f2087c98
-
xiyuan@chromium.org authored
BUG=none TEST=Verify the mock user in users options page does not has "undefined" as their names. Review URL: http://codereview.chromium.org/3076031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54976 0039d316-1c4b-4281-b951-d872f2087c98
-
jhawkins@chromium.org authored
ParseEmpty should only match against the label text. BUG=none TEST=NameFieldTest.*;AddressFieldTest.* Review URL: http://codereview.chromium.org/3067029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54974 0039d316-1c4b-4281-b951-d872f2087c98
-
albertb@chromium.org authored
BUG=48701 TEST=NigoriTest.* Review URL: http://codereview.chromium.org/3013047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54970 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
This reverts commit r54966. Meant to try it, not commit it, sorry everyone. :( git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54969 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
Review URL: http://codereview.chromium.org/3057033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54966 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
during UI tests. The layout test plugin is copied over via a build step and needed when running the layout tests. If you run the UI tests before the layout tests, the npapi layout test plugin is deleted and causes layout tests to fail. Seems like it's safe to keep the plugins even after the UI tests end. Review URL: http://codereview.chromium.org/3066033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54965 0039d316-1c4b-4281-b951-d872f2087c98
-
xiyuan@chromium.org authored
Allow local pdf file to be opened if a pdf plugin is available. BUG=chromium-os:5263 TEST=Verify local pdf file could be opened and viewed by pdf plugin. Review URL: http://codereview.chromium.org/3083015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54964 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
specific states of the state machine. This required adding two new states: STATE_INIT_STREAM STATE_INTI_STREAM_COMPLETE The http_stream_ and spdy_http_stream_ member fields have been removed, and replaced by a single stream_ member field which is initialized with either an HttpBasicStream, or SpdyHttpStream depending on the underlying connection. In the process, the NetLog no longer receives TYPE_SPDY events, only TYPE_HTTP, so spdy_network_transaction_unittest.cc needed to be modified accordingly. This seems to causing Valgrind leaks: http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20(valgrind)/builds/6887/steps/memory%20test:%20net/logs/stdio E.g.: Leak_DefinitelyLost 78,766 (888 direct, 77,878 indirect) bytes in 2 blocks are definitely lost in loss record 6,975 of 7,027 operator new(unsigned long) (mp/vg-bins/scripts/valgrind-memcheck/coregrind/m_replacemalloc/vg_replace_malloc.c:276) net::SpdySessionPool::GetSpdySessionFromSocket(std::pair<net::HostPortPair, std::basic_string<char, std::char_traits<char>, std::allocator<char> > > const&, net::HttpNetworkSession*, net::ClientSocketHandle*, net::BoundNetLog const&, int, scoped_refptr<net::SpdySession>*, bool) net::HttpNetworkTransaction::DoInitStream() net::HttpNetworkTransaction::DoLoop(int) net::HttpNetworkTransaction::OnIOComplete(int) net::ClientSocketHandle::OnIOComplete(int) net::internal::ClientSocketPoolBaseHelper::InvokeUserCallback(net::ClientSocketHandle*) RunnableMethod<net::internal::ClientSocketPoolBaseHelper, void (net::internal::ClientSocketPoolBaseHelper::*)(net::ClientSocketHandle*), Tuple1<net::ClientSocketHandle*> >::Run() MessageLoop::RunTask(Task*) MessageLoop::DeferOrRunPendingTask(MessageLoop::PendingTask const&) MessageLoop::DoWork() base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) MessageLoop::RunInternal() MessageLoop::Run() TestCompletionCallback::WaitForResult() net::SpdyNetworkTransactionTest_SocketWriteReturnsZero_Test::TestBody() testing::Test::Run() testing::internal::TestInfoImpl::Run() testing::TestCase::Run() testing::internal::UnitTestImpl::RunAllTests() TestSuite::Run() main Suppression (error hash=#-444E9002#): { <insert_a_suppression_name_here> Memcheck:Leak fun:_Znw* fun:_ZN3net15SpdySessionPool24GetSpdySessionFromSocketERKSt4pairINS_12HostPortPairESsEPNS_18HttpNetworkSessionEPNS_18ClientSocketHandleERKNS_11BoundNetLogEiP13scoped_refptrINS_11SpdySessionEEb fun:_ZN3net22HttpNetworkTransaction12DoInitStreamEv fun:_ZN3net22HttpNetworkTransaction6DoLoopEi fun:_ZN3net22HttpNetworkTransaction12OnIOCompleteEi fun:_ZN3net18ClientSocketHandle12OnIOCompleteEi fun:_ZN3net8internal26ClientSocketPoolBaseHelper18InvokeUserCallbackEPNS_18ClientSocketHandleE fun:_ZN14RunnableMethodIN3net8internal26ClientSocketPoolBaseHelperEMS2_FvPNS0_18ClientSocketHandleEE6Tuple1IS4_EE3RunEv fun:_ZN11MessageLoop7RunTaskEP4Task fun:_ZN11MessageLoop21DeferOrRunPendingTaskERKNS_11PendingTaskE fun:_ZN11MessageLoop6DoWorkEv fun:_ZN4base19MessagePumpLibevent3RunEPNS_11MessagePump8DelegateE fun:_ZN11MessageLoop11RunInternalEv } BUG=50267 TEST=none Review URL: http://codereview.chromium.org/3064033 TBR=rch@chromium.org Review URL: http://codereview.chromium.org/3038048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54963 0039d316-1c4b-4281-b951-d872f2087c98
-
atwilson@chromium.org authored
TBR=pfeldman Review URL: http://codereview.chromium.org/3014054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54962 0039d316-1c4b-4281-b951-d872f2087c98
-
dmazzoni@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/2832106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54960 0039d316-1c4b-4281-b951-d872f2087c98
-
sargrass@google.com authored
BUG=None Test=None Review URL: http://codereview.chromium.org/3061049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54959 0039d316-1c4b-4281-b951-d872f2087c98
-
ajwong@chromium.org authored
BUG=50248 TEST=connects locally. TBR=hclam Review URL: http://codereview.chromium.org/2808104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54958 0039d316-1c4b-4281-b951-d872f2087c98
-
tommi@chromium.org authored
TBR=amit TEST=n/a BUG=none Review URL: http://codereview.chromium.org/3061051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54957 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=50682 TEST=load make_page_red, you can see the badge; dragging still works, clicking still works, removing icons still works Review URL: http://codereview.chromium.org/3064039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54954 0039d316-1c4b-4281-b951-d872f2087c98
-
davemoore@chromium.org authored
To effectively test some parts of chrome for cros on the linux desktop, we need a way to start chrome logged in. The login UI requires the WM to display, so I added command line options to do this. But we needed the full functionality of login, which doesn't work when libcros can't be loaded. I created stubs for all the cros api. I then took both stubs and the real implementations and put them entirely inside the .cc files (no separate declaration of the implementations in the .h files). Review URL: http://codereview.chromium.org/3076029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54950 0039d316-1c4b-4281-b951-d872f2087c98
-
michaeln@chromium.org authored
AppCache: Provide a way to override the default quota for an origin. The intent is to use this to support the 'unlimited_storage' privilege of Chrome Applications. BUG=49993 TEST=AppCacheStorageImplTest.FailStoreGroup Review URL: http://codereview.chromium.org/3083014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54949 0039d316-1c4b-4281-b951-d872f2087c98
-
michaeln@chromium.org authored
BUG=45230 TEST=manual Review URL: http://codereview.chromium.org/3023038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54948 0039d316-1c4b-4281-b951-d872f2087c98
-
suzhe@chromium.org authored
This CL removes the accelerator handling logic in accelerator_handler_gtk.cc and implements a much simpler solution in WidgetGtk. The new approach always sends a key event to the focused View and native GtkWidget first and only sends it to the focus manager if it's not handled by any View or native GtkWidget. BUG=23383 AcceleratorHandler on Windows should not dispatch the KEYUP messages eaten by the FocusManager BUG=40966 BrowserKeyEventsTest.AccessKeys is crashy BUG=49701 [Linux Views]Some Emacs keybindings are broken in omnibox and find in page box. TEST=Press Alt key in different place (web page, omnibox, find bar, etc.) to see if menu bar can be focused correctly. Press alt-F to popup wrench menu and Escape to close it, then try alt key again. Review URL: http://codereview.chromium.org/3046041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54947 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
BUG=23581 Review URL: http://codereview.chromium.org/3044043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54946 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
Review URL: http://codereview.chromium.org/3043055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54945 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
Also do some drive-by wstring/wchar_t -> string/char changes (in addition to the necessary ones). BUG=none TEST=builds and tests pass Review URL: http://codereview.chromium.org/3091005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54944 0039d316-1c4b-4281-b951-d872f2087c98
-