- Nov 03, 2010
-
-
ctguil@chromium.org authored
BUG=59890 TEST=Manual. Inspect32. Review URL: http://codereview.chromium.org/4292001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64943 0039d316-1c4b-4281-b951-d872f2087c98
-
- Oct 08, 2010
-
-
dmazzoni@chromium.org authored
character, word, line, sentence, or paragraph within a text field. These methods are needed by SAToGo. BUG=36217 TEST=Added new unit test. Review URL: http://codereview.chromium.org/3550017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61979 0039d316-1c4b-4281-b951-d872f2087c98
-
- Oct 07, 2010
-
-
ctguil@chromium.org authored
1. Move common logic and fields from BrowserAccessibilityMangerWin to BrowserAccessibilityManager. 2. Move common logic and fields from BrowserAccessibilityWin to BrowserAccessibility. BUG=55264 TEST=interactive_ui_tests:AccessibilityWinBrowserTest.* TEST=unit_tests:BrowserAccessibilityTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61740 Review URL: http://codereview.chromium.org/3551015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61765 0039d316-1c4b-4281-b951-d872f2087c98
-
ctguil@chromium.org authored
1. Move common logic and fields from BrowserAccessibilityMangerWin to BrowserAccessibilityManager. 2. Move common logic and fields from BrowserAccessibilityWin to BrowserAccessibility. Linux errors. BUG=55264 TEST=interactive_ui_tests:AccessibilityWinBrowserTest.* TEST=unit_tests:BrowserAccessibilityTest.* Review URL: http://codereview.chromium.org/3551015 TBR=ctguil@chromium.org Review URL: http://codereview.chromium.org/3562011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61749 0039d316-1c4b-4281-b951-d872f2087c98
-
- Oct 06, 2010
-
-
ctguil@chromium.org authored
1. Move common logic and fields from BrowserAccessibilityMangerWin to BrowserAccessibilityManager. 2. Move common logic and fields from BrowserAccessibilityWin to BrowserAccessibility. BUG=55264 TEST=interactive_ui_tests:AccessibilityWinBrowserTest.* TEST=unit_tests:BrowserAccessibilityTest.* Review URL: http://codereview.chromium.org/3551015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61740 0039d316-1c4b-4281-b951-d872f2087c98
-
ctguil@chromium.org authored
BUG=55264 TEST=none Review URL: http://codereview.chromium.org/3551015 TBR=ctguil@chromium.org Review URL: http://codereview.chromium.org/3582015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61707 0039d316-1c4b-4281-b951-d872f2087c98
-
ctguil@chromium.org authored
BUG=55264 TEST=none Review URL: http://codereview.chromium.org/3551015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61704 0039d316-1c4b-4281-b951-d872f2087c98
-
- Oct 01, 2010
-
-
ctguil@chromium.org authored
1. Move windows browser accessibility source and headers into chrome\browser\accessibility 2. Rename BrowserAccessibilityManager to BrowserAccessibilityManagerWin and BrowserAccessibility to BrowserAccessibilityWin 3. Add base classes that will eventually contain common browser accessibility code. BUG=55264 TEST=interactive_ui_tests:AccessibilityWinBrowserTest.* TEST=unit_tests:BrowserAccessibilityTest.* Review URL: http://codereview.chromium.org/3591003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61253 0039d316-1c4b-4281-b951-d872f2087c98
-
dmazzoni@chromium.org authored
accessible, implement IAccessibleText methods to retrieve this info, and post a notification when the cursor moves within a text field. BUG=none TEST=Added new test to renderer_accessibility_browsertest Review URL: http://codereview.chromium.org/3389037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61216 0039d316-1c4b-4281-b951-d872f2087c98
-
- Sep 25, 2010
-
-
ctguil@chromium.org authored
1. Update WebAccessibility::ConvertState to function similarly to WebCore's AccessibleBase::get_accState. 2. Use WebKit's load complete notification to send the renderer's tree to the browser. We enable accessibility on the renderer now instead of requesting a tree. 3. Use WebKit's focused ui element notification to send renderer focus events to the browser. BUG=13291 BUG=38106 TEST=interactive_ui_tests:AccessibilityWinBrowserTest.TestNotificationActiveDescendantChanged TEST=interactive_ui_tests:AccessibilityWinBrowserTest.TestNotificationFocusChanged Review URL: http://codereview.chromium.org/3380017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60569 0039d316-1c4b-4281-b951-d872f2087c98
-
- Sep 23, 2010
-
-
ctguil@chromium.org authored
BUG=47493 TEST=NVDA reads out heading levels. Review URL: http://codereview.chromium.org/3402025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60260 0039d316-1c4b-4281-b951-d872f2087c98
-
ctguil@chromium.org authored
This is similar to the behavior of firefox. BUG=none TEST=browser_tests:RendererAccessibilityBrowserTest.TestCrossPlatformAccessibilityTree TEST=interactive_ui_tests:AccessibilityWinBrowserTest.* Review URL: http://codereview.chromium.org/3435019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60259 0039d316-1c4b-4281-b951-d872f2087c98
-
- Sep 16, 2010
-
-
ctguil@chromium.org authored
BUG=none TEST=interactive_iu_tests:AccessibilityWinBrowserTest.TestRendererAccessibilityTree Review URL: http://codereview.chromium.org/3415008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59693 0039d316-1c4b-4281-b951-d872f2087c98
-
- Sep 08, 2010
-
-
ctguil@chromium.org authored
a few IAccessible2 functions with some of the new attributes that are available now. BUG=48185 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58491 Review URL: http://codereview.chromium.org/3219009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58776 0039d316-1c4b-4281-b951-d872f2087c98
-
- Sep 03, 2010
-
-
dmazzoni@chromium.org authored
a few IAccessible2 functions with some of the new attributes that are available now. BUG=48185 TEST=None Review URL: http://codereview.chromium.org/3219009 TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/3324006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58499 0039d316-1c4b-4281-b951-d872f2087c98
-
dmazzoni@chromium.org authored
a few IAccessible2 functions with some of the new attributes that are available now. BUG=48185 TEST=None Review URL: http://codereview.chromium.org/3219009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58491 0039d316-1c4b-4281-b951-d872f2087c98
-
- Sep 01, 2010
-
-
ctguil@chromium.org authored
BUG=13291 TEST=interactive_ui_tests AccessibilityWinBrowserTest.TestDynamicAccessibilityTree R=dmazzoni Review URL: http://codereview.chromium.org/3250014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58194 0039d316-1c4b-4281-b951-d872f2087c98
-
- Aug 31, 2010
-
-
ctguil@chromium.org authored
WebKit sister patch: http://trac.webkit.org/changeset/66305 BUG=13291 TEST=interactive_ui_tests --gtest_filter=AccessibilityWinBrowserTest.TestDynamicAccessibilityTree TEST=unit_tests --gtest_filter=BrowserAccessibilityTest.TestChildrenChange TEST=unit_tests --gtest_filter=BrowserAccessibilityTest.TestChildrenChangeNoLeaks Review URL: http://codereview.chromium.org/3117036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57983 0039d316-1c4b-4281-b951-d872f2087c98
-
- Jun 16, 2010
-
-
dmazzoni@chromium.org authored
browser_accessibility_manager, to make it more clear that these are Windows-only source files. BUG=none TEST=none Review URL: http://codereview.chromium.org/2830005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49947 0039d316-1c4b-4281-b951-d872f2087c98
-
- May 21, 2010
-
-
dmazzoni@chromium.org authored
browser and then converted to MSAA roles - this is both because the logic needs to be more complicated, and so we can support Mac accessibility, too. 2. The serializable object used to pass accessibility info from the renderer to the browser now uses a map for uncommon attributes, rather than having a bunch of fields that are almost always empty. 3. Handles the accSelect method with TAKE_FOCUS, allowing assistive technology to set focus to a particular control. 4. Implements several other IAccessible2 interfaces. BUG=25564 BUG=13291 TEST=None Review URL: http://codereview.chromium.org/2121004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47922 0039d316-1c4b-4281-b951-d872f2087c98
-
- May 11, 2010
-
-
dmazzoni@chromium.org authored
accessibility tree in the browser process. Adds new RPCs for a browser tab to request accessibility info from a renderer; the renderer responds with a complete tree of accessibility metadata for the entire DOM, which is then cached in the RenderWidgetHostView. This part is cross-platform and will help with accessibility on both Windows and Mac OS X. For Windows, MSAA support for web content has been rewritten to use this new cache. Tested in JAWS and NVDA screen readers. Using Chrome with a screen reader is now fast and stable, unlike the previous implementation. However, note that most advanced functionality is still not supported, and much work remains to make Chrome work well with a screen reader. This is a necessary step to improve stability first. BUG=25564 BUG=13291 TEST=See http://codereview.chromium.org/1806001 Review URL: http://codereview.chromium.org/1637018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46916 0039d316-1c4b-4281-b951-d872f2087c98
-
- May 10, 2010
-
-
dmazzoni@chromium.org authored
accessibility tree in the browser process. Adds new RPCs for a browser tab to request accessibility info from a renderer; the renderer responds with a complete tree of accessibility metadata for the entire DOM, which is then cached in the RenderWidgetHostView. This part is crossplatform and will help with accessibility on both Windows and Mac OS X. For Windows, MSAA support for web content has been rewritten to use this new cache. Tested in JAWS and NVDA screen readers. Using Chrome with a screen reader is now fast and stable, unlike the previous implementation. However, note that most advanced functionality is still not supported, and much work remains to make Chrome work well with a screen reader. This is a necessary step to improve stability first. BUG=25564 BUG=13291 TEST=See http://codereview.chromium.org/1806001 Review URL: http://codereview.chromium.org/1637018 TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/1989009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46847 0039d316-1c4b-4281-b951-d872f2087c98
-
dmazzoni@chromium.org authored
accessibility tree in the browser process. Adds new RPCs for a browser tab to request accessibility info from a renderer; the renderer responds with a complete tree of accessibility metadata for the entire DOM, which is then cached in the RenderWidgetHostView. This part is cross-platform and will help with accessibility on both Windows and Mac OS X. For Windows, MSAA support for web content has been rewritten to use this new cache. Tested in JAWS and NVDA screen readers. Using Chrome with a screen reader is now fast and stable, unlike the previous implementation. However, note that most advanced functionality is still not supported, and much work remains to make Chrome work well with a screen reader. This is a necessary step to improve stability first. BUG=25564 BUG=13291 TEST=See http://codereview.chromium.org/1806001 Review URL: http://codereview.chromium.org/1637018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46842 0039d316-1c4b-4281-b951-d872f2087c98
-
- May 07, 2010
-
-
zork@chromium.org authored
accessibility tree in the browser process. Adds new RPCs for a browser tab to request accessibility info from a renderer; the renderer responds with a complete tree of accessibility metadata for the entire DOM, which is then cached in the RenderWidgetHostView. This part is crossplatform and will help with accessibility on both Windows and Mac OS X. For Windows, MSAA support for web content has been rewritten to use this new cache. Tested in JAWS and NVDA screen readers. Using Chrome with a screen reader is now fast and stable, unlike the previous implementation. However, note that most advanced functionality is still not supported, and much work remains to make Chrome work well with a screen reader. This is a necessary step to improve stability first. BUG=25564 BUG=13291 TEST=See http://codereview.chromium.org/1806001 Review URL: http://codereview.chromium.org/1637018 TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/2031004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46642 0039d316-1c4b-4281-b951-d872f2087c98
-
- May 06, 2010
-
-
dmazzoni@chromium.org authored
accessibility tree in the browser process. Adds new RPCs for a browser tab to request accessibility info from a renderer; the renderer responds with a complete tree of accessibility metadata for the entire DOM, which is then cached in the RenderWidgetHostView. This part is cross-platform and will help with accessibility on both Windows and Mac OS X. For Windows, MSAA support for web content has been rewritten to use this new cache. Tested in JAWS and NVDA screen readers. Using Chrome with a screen reader is now fast and stable, unlike the previous implementation. However, note that most advanced functionality is still not supported, and much work remains to make Chrome work well with a screen reader. This is a necessary step to improve stability first. BUG=25564 BUG=13291 TEST=See http://codereview.chromium.org/1806001 Review URL: http://codereview.chromium.org/1637018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46567 0039d316-1c4b-4281-b951-d872f2087c98
-
- Feb 24, 2010
-
-
jcampan@chromium.org authored
See original review at: http://codereview.chromium.org/626014/show BUG=None TEST=None Review URL: http://codereview.chromium.org/657020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39828 0039d316-1c4b-4281-b951-d872f2087c98
-
- Sep 10, 2009
-
-
jhawkins@chromium.org authored
BUG=5027 TEST=none Review URL: http://codereview.chromium.org/200045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25879 0039d316-1c4b-4281-b951-d872f2087c98
-
- Aug 27, 2009
-
-
klink@chromium.org authored
BUG=19982 TEST=Assign @role option on a child element to either menu or listbox. It will be exposed as either menuitem or listitem, respectively. Review URL: http://codereview.chromium.org/173488 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24662 0039d316-1c4b-4281-b951-d872f2087c98
-
- Aug 25, 2009
-
-
klink@chromium.org authored
Adds support for WAI-ARIA roles application, document, radiogroup, region, separator, status and tooltip. BUG=19982 TEST=Assign @role application, document, radiogroup, region, separator, status or tooltip to any dom element, and use Inspect32 (or similar tool) to see it exposed correctly. Review URL: http://codereview.chromium.org/174382 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24262 0039d316-1c4b-4281-b951-d872f2087c98
-
- Aug 22, 2009
-
-
klink@chromium.org authored
Adds support and exposure of additional accessibility roles. Includes naming of the LocationBar, and correctly exposing MSAA/ARIA roles for Documents, Graphics, Menubars and Toolbars. BUG=13291,19982 TEST=Assign @role menubar or toolbar to any dom element, and use Inspect32 (or similar tool) to see it exposed correctly. In the same way, <html> tag is exposed as role document. Review URL: http://codereview.chromium.org/174252 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24049 0039d316-1c4b-4281-b951-d872f2087c98
-
- Jul 07, 2009
-
-
klink@chromium.org authored
Adds support for an initial set of WAI-ARIA roles, needed to support screen readers in AJAX web applications (e.g. Gmail). BUG=None TEST=None Review URL: http://codereview.chromium.org/149265 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20094 0039d316-1c4b-4281-b951-d872f2087c98
-
- Jun 05, 2009
-
-
klink@chromium.org authored
Fixes an issue where the MSAA information was not reported back correctly to the AT, upon the HWND containing the web content first receiving focus. Note that this is not a full fix for the bug below, but one more piece to resolving it.BUG=13291TEST=none Review URL: http://codereview.chromium.org/118206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17778 0039d316-1c4b-4281-b951-d872f2087c98
-
- May 20, 2009
-
-
klink@chromium.org authored
Adds propagation and handling of render-side focus events, for the benefit of assistive technologies (accessibility). Also cleans up the handling of WM_GETOBJECT in RenderWidgetHostViewWin and WidgetWin, as well as in BrowserAccessibilityManager. Review URL: http://codereview.chromium.org/115374 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16449 0039d316-1c4b-4281-b951-d872f2087c98
-
- Mar 20, 2009
-
-
klink@chromium.org authored
Removes all use of COM and dependencies on Windows-specific classes (including the use of AccessibleBase and AccessibleDocument) in the glue accessibility implementation.Introduces the GlueAccessibilityObject, which serves as a platform-independent wrapper directly around WebKit's AccessibilityObject (also platoform-independent).Updates naming/comments to reflect the independence of IAccessible both in glue and (where appropriate) in the browser-side accessibility. Review URL: http://codereview.chromium.org/46013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12207 0039d316-1c4b-4281-b951-d872f2087c98
-
- Mar 10, 2009
-
-
deanm@chromium.org authored
Normalize end of file newlines in chrome/. All files end in a single newline. Review URL: http://codereview.chromium.org/42015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11331 0039d316-1c4b-4281-b951-d872f2087c98
-
- Feb 05, 2009
-
-
jam@chromium.org authored
Review URL: http://codereview.chromium.org/20072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9209 0039d316-1c4b-4281-b951-d872f2087c98
-
- Feb 04, 2009
-
-
jam@chromium.org authored
Commiting the changes from my previous cl that are specific to not including render_messages.h/plugin_message.h unless necessary. TBR=mpcomplete Review URL: http://codereview.chromium.org/20059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9189 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Revert my change to get the tree green. Not sure why the tests became flaky. I'll try to check them in again but in smaller chunks tomorrow. TBR=mpcomplete Review URL: http://codereview.chromium.org/21039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9132 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Make it easier/less work/less error-prone to create new IPC channel types (i.e. renderer/plugin).Instead of having each message file include the internal one several times with different ifdefs, move that logic to ipc_message_macros.h. Also make the message class starting IDs come from an enum to ensure we don't use a value twice. I simplified the logging code a bit so we don't need X_messages.cc files.Clean up places that we were doing manual packing/unpacking. Most of this was in the automation code. I added a few new template functions to make it convenient to read the parameters from a message, and updated the code to use them.I also removed unnecessary includes of render/plugin_messages.h from headers to speed up compiling.I moved the traits of IPC structs beside the struct definition to make it more apparent what's going on, so we avoid people modifying the struct and forgetting to update the traits.Amit: please look at chrome/test/automation/tab_proxy.ccMarc-Antoine: chrome/browser/printing/*Matt: the rest Review URL: http://codereview.chromium.org/20015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9123 0039d316-1c4b-4281-b951-d872f2087c98
-
- Oct 09, 2008
-
-
klink@chromium.org authored
Fixes crash in BrowserAccessibilityManager destructor (see CPBrowsingContextManager for example of this type of fix). Also fixes small style issue, to be consistent with other Singleton implementations. Review URL: http://codereview.chromium.org/6282 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3078 0039d316-1c4b-4281-b951-d872f2087c98
-