- Jun 15, 2009
-
-
sidchat@google.com authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/122007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18445 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
Review URL: http://codereview.chromium.org/125145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18444 0039d316-1c4b-4281-b951-d872f2087c98
-
dglazkov@google.com authored
BUG=http://crbug.com/10301 BUG=http://crbug.com/10433 BUG=http://crbug.com/10435 BUG=http://crbug.com/8404 R=eroman TEST=watch the build bot. Review URL: http://codereview.chromium.org/125140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18443 0039d316-1c4b-4281-b951-d872f2087c98
-
jcampan@chromium.org authored
TBR=stoyan BUG=http://crbug.com/14132 Review URL: http://codereview.chromium.org/125153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18442 0039d316-1c4b-4281-b951-d872f2087c98
-
sgk@google.com authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/126152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18441 0039d316-1c4b-4281-b951-d872f2087c98
-
hclam@chromium.org authored
More flaky tests appear to be flaky. TBR=scherkus Review URL: http://codereview.chromium.org/125150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18440 0039d316-1c4b-4281-b951-d872f2087c98
-
ericu@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18437 0039d316-1c4b-4281-b951-d872f2087c98
-
willchan@chromium.org authored
This reverts r18414. Broke reliability bot. Review URL: http://codereview.chromium.org/128001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18436 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
BUG=none TEST=none R=nirnimesh Review URL: http://codereview.chromium.org/125146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18435 0039d316-1c4b-4281-b951-d872f2087c98
-
ericroman@google.com authored
Add a regression test for 14056. This verifies that HttpNetworkTransaction sets the "referrer" field expected by the DNS prefetch observer. BUG=14056 Review URL: http://codereview.chromium.org/126112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18434 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
object-embed-plugin-scripting changed upstream in r44674. nth-child-dynamic is a new test. TBR=levin Review URL: http://codereview.chromium.org/126155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18433 0039d316-1c4b-4281-b951-d872f2087c98
-
hclam@chromium.org authored
Defines enums for kParentEntry and kChildEntry in MemEntryImpl. Also has code in MemBackendImpl to create a slave entry. Parent entries are non-sparse entries until sparse API are called on them, and they would start to keep a list of child entries. Child entries hold partial content and are not susposed to be accessible from the public and are managed by the parent entry that created it. Child entries are registered in the backend's ranking list to allow individual eviction. More details about how child entries are to be used are in the comments. TEST=DiskCacheEntryTest.MemoryOnlyEnumerationWithSlaveEntries Review URL: http://codereview.chromium.org/120004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18432 0039d316-1c4b-4281-b951-d872f2087c98
-
hclam@chromium.org authored
Some tests appear to be flaky in build bot, adjust their expectations. TBR=scherkus Review URL: http://codereview.chromium.org/126142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18431 0039d316-1c4b-4281-b951-d872f2087c98
-
mpcomplete@google.com authored
all threads. BUG=13914 TEST=install an extension an make sure the install dialog window shows up in front of the Chrome window. Review URL: http://codereview.chromium.org/125077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18430 0039d316-1c4b-4281-b951-d872f2087c98
-
mpcomplete@google.com authored
BUG=12128 TEST=Create a bunch of tabs (40+) and make sure New Tab pages are always grouped in a process with other chrome internal pages, extensions are always grouped together, and regular web pages are never in a process with extensions or New Tab pages. Review URL: http://codereview.chromium.org/126002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18428 0039d316-1c4b-4281-b951-d872f2087c98
-
erikkay@google.com authored
BUG=none TEST=browser_tests.exe --gtest_filter=ExtensionViewTest.Incognito Review URL: http://codereview.chromium.org/126151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18427 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/126078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18426 0039d316-1c4b-4281-b951-d872f2087c98
-
http://crbug.com/13971jeremy@chromium.org authored
Provide a custom field editor for the location bar that overrides cut/copy to only write plain text to the clipboard. BUG=13971 TEST=Type a URL in the Omnibox, select all and copy url, open Textedit and paste the url into it. Expected results: url should be unstyled previous behavior: styled text (as it appeared in the Omnibox was pasted) Review URL: http://codereview.chromium.org/126075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18425 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18424 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/125092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18423 0039d316-1c4b-4281-b951-d872f2087c98
-
willchan@chromium.org authored
BUG=http://crbug.com/10737 Review URL: http://codereview.chromium.org/118491 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18422 0039d316-1c4b-4281-b951-d872f2087c98
-
tc@google.com authored
Fix a the compile by renaming JSONObject to InspectorJSONObject (upstream r44682) and add a test expection for a new test. The windows expectation is just a copy of the linux one, I need to rebaseline it on windows. Review URL: http://codereview.chromium.org/126148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18421 0039d316-1c4b-4281-b951-d872f2087c98
-
mark@chromium.org authored
Review URL: http://codereview.chromium.org/126150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18420 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
http://codereview.chromium.org/126149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18419 0039d316-1c4b-4281-b951-d872f2087c98
-
thomasvl@chromium.org authored
Block some memory checks with #if defined(win) to get things compiling. Switch some things over to file paths. Test doesn't work yet, but this atleast gets it compiling/linking now. TEST=none BUG=14098 Review URL: http://codereview.chromium.org/125124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18418 0039d316-1c4b-4281-b951-d872f2087c98
-
mark@chromium.org authored
on the screen again. Regressed in r18363. Review URL: http://codereview.chromium.org/126140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18415 0039d316-1c4b-4281-b951-d872f2087c98
-
willchan@chromium.org authored
Re-enable the disabled URLRequest tests. BUG=http://crbug.com/13952 TEST=covered by existing tests Review URL: http://codereview.chromium.org/126065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18414 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
(These were a merge artifact from r18405 which additionally broke the build on GCC 4.4). git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18413 0039d316-1c4b-4281-b951-d872f2087c98
-
finnur@chromium.org authored
Converting the RSS subscription page to use a background page, as opposed to a toolstrip (since it has no toolstrip UI). BUG=None TEST=The RSS page action should work as before and should not take up any real estate in the toolstrip. Review URL: http://codereview.chromium.org/126143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18412 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
I had a typo in r18405 which meant that italic text wasn't actually italic. This broke, ah, 'several' layout tests. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18411 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
with "http://" if they didn't have one. This proves problematic as for the google search url we don't have http:// and don't want it. The fix is to only add http:// if the url field is editable. If the url field isn't editable, we know the user hasn't editted it and don't need to try and fix it up. BUG=13282 TEST=see bug, but also make sure you don't run into any other problems with the keyword editor. Review URL: http://codereview.chromium.org/126052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18410 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Review URL: http://codereview.chromium.org/126086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18409 0039d316-1c4b-4281-b951-d872f2087c98
-
pinkerton@chromium.org authored
Make tooltips work correctly, allowing for multiple tooltips w/out the mouse leaving the view (which is all NSView can handle by itself). Adds some Camino code to do so. BUG=13995 TEST=tooltips in web pages, pages with multiple tooltips, expose and spaces. Review URL: http://codereview.chromium.org/125133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18408 0039d316-1c4b-4281-b951-d872f2087c98
-
japhet@chromium.org authored
Review URL: http://codereview.chromium.org/118329 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18407 0039d316-1c4b-4281-b951-d872f2087c98
-
hclam@chromium.org authored
The CodecContext passed into FFmpegAudioDecoder by the FFmpegDemuxer says the output samples are 16bits. So we tell the audio renderer to create a 16bits audio output stream. But after the decoder is allocated by avcodec_find_codec, the sample bits information in |codec_context_| is changed to 8bit! So we are feeding 16bits output stream with 8bits data. The decoder should knows more about the actual output format. So query the sample bits information after the decoder is allocated. Review URL: http://codereview.chromium.org/125027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18406 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
http://code.google.com/p/chromium/wiki/LinuxSandboxIPC Without filesystem access from the renderers, we need another way of dealing with fontconfig and font loading. This add support for: * An "SBX_D" environment variable in the renderers which is used to signal the end of dynamic linking so that the chroot can be enforced. * A sandbox_host process, running outside the sandbox, to deal with fontconfig requests from the renderers. See the wiki page for the reasoning behind making it a separate process. * A new, custom SkFontHost for Skia. Because this is Chrome specific, it will live outside the upstream Skia tree. This FontHost can be configured either to drive fontconfig directly (for the browser process and for any unsandboxed renderers) or to use an IPC system. Since the same SkFontHost has to be linked into both the browser and renderer (they are the same binary), this switch has to be made at run time. Sandbox IPC calls are rare (a couple of dozen at page load time) and add about 50us of overhead for each call. (Reland of r17575 which was reverted in r17577) http://codereview.chromium.org/112074 BUG=8081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18405 0039d316-1c4b-4281-b951-d872f2087c98
-
tc@google.com authored
The input param gets clobbered so we need to make a copy before using it. TEST=Run chrome via valgrind and move the mouse over the content area. There should be no errors. Review URL: http://codereview.chromium.org/126081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18404 0039d316-1c4b-4281-b951-d872f2087c98
-
hclam@chromium.org authored
Since we are not using the YUV->RGB code to perform fast flipping and mirroring. Use FastPaint to handle flipping and mirroring was wrong. There's no plan to support fast flipping and mirroring in the short future so fall back to SlowPaint for this case. Review URL: http://codereview.chromium.org/126093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18403 0039d316-1c4b-4281-b951-d872f2087c98
-
yutak@chromium.org authored
This change makes traversal order of focus cycle consistent between forward and backward traversal. This is a partial fix for issue 6785. BUG=http://crbug.com/6785 TEST=Move the focus to the find bar, and push [Shift]+[Tab]. The focus should not cycle inside the find bar, but go out to the omnibox (or somewhere outside the find bar). Review URL: http://codereview.chromium.org/125130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18402 0039d316-1c4b-4281-b951-d872f2087c98
-
xji@chromium.org authored
There are the following 3 issues: 1. the tab image in gray box is wrong in RTL locale. This is fixed by flipping canvas in RTL locale when draw those images. 2. dropped tab was not rendered in the correct position when gray box appears but the tab was not dropped inside the gray box. This is fixed by adjusting x coordinate of the dropped tab when there is dock information available in RTL in CompleteDrag(). 3. when chrome is maximized, drag/drop a tab to left/right window, then drag the tab through original main browser tabstrip and drop it anywhere else, dropped tab was not rendered in the right position. This is fixed by initialize window create point based on source_tabstrip_, not attached_tabstrip_, and move the initialization function from Attach() (since the position is no longer related to attached_tabstrip_) to CaptureDragInfo() where the mouse_offset_ is set. BUG=http://crbug.com/6223 TEST= 1. Open Hebrew Chrome, 2. drag a tab to the right of the screen till the gray box showed up, the tab image showed in the gray box should be similar to the tab image in Hebrew Chrome (not that in English Chrome), 3. drop the tab outside of the gray box while gray box is showing, the dropped tab should be rendered using the mouse click as the top-right corner (not top-left corner). 4. maximize chrome and open at least 2 tabs in it. 5. drag a tab out to left screen till the "left-half of screen" gray box showed up and drop it inside the gray box so that the tab was in the left-half of the screen and the original chrome browser is still maximized. 6. drag this tab back to the title of chrome (as if to re-insert it back to the maximized chrome's tabstrip) but do not release mouse, continue drag it back to somewhere on the screen and drop it. The dropped tab should be rendered using the mouse click as a point in its tabstrip (not rendered far away from the mouse click). Review URL: http://codereview.chromium.org/126006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18401 0039d316-1c4b-4281-b951-d872f2087c98
-