Brings in a fix to some brittle dependencies.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/661189

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40230 0039d316-1c4b-4281-b951-d872f2087c98

The scons generator currently does not correctly handle the case in which you
have a target with no sources (for instance all the mock targets used for the
bots). So far this has not been an issue because these mock targets were only
used for Windows and Mac. jiesun's recent addition of a chromeos_builder target
caused this issue to manifest itself.

BUG=None
TEST=None
TBR=jiesuN

Review URL: http://codereview.chromium.org/661249

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40229 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dumi
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/661250

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40228 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dglazkov


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40227 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dumi
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/660246

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40226 0039d316-1c4b-4281-b951-d872f2087c98

Original review: http://codereview.chromium.org/661247
TBR=loislo

Review URL: http://codereview.chromium.org/661248

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40225 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/661178

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40224 0039d316-1c4b-4281-b951-d872f2087c98

because the chrome's flaky ass tests that break
random builds

TEST=flaky
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40221 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40219 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
TBR=gman@chromium.org


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40217 0039d316-1c4b-4281-b951-d872f2087c98

It sure would be nice if the trybots caught these issues :-(

TBR=apatrick@chromium.org
TEST=none
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40216 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/660238

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40212 0039d316-1c4b-4281-b951-d872f2087c98

BUG=36964
TBR=huanr

Review URL: http://codereview.chromium.org/661243

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40211 0039d316-1c4b-4281-b951-d872f2087c98

Make sure SafeBrowsingResourceHandler overrides ResourceHandler::OnRequestClosed() so it doesn't inherit the default (unfortunately the base class doesn't define it as pure virtual).

BUG=36964
TBR=rvargas

Review URL: http://codereview.chromium.org/660240

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40208 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/658001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40206 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/660236

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40205 0039d316-1c4b-4281-b951-d872f2087c98

TBR=apatrick@google.com
TEST=none
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40204 0039d316-1c4b-4281-b951-d872f2087c98

for sxs install.

BUG=35574
TEST="setup.exe --chrome-sxs"

Review URL: http://codereview.chromium.org/660168

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40203 0039d316-1c4b-4281-b951-d872f2087c98

xib changes: Change ^IDS_CLOSE to ^IDS_DONE.

BUG=36959
TEST=Open bookmark bubble. Button should read "Done". Go to popuptest.com, click "popups blocked" icon. Button in bubble should read "Done".

Review URL: http://codereview.chromium.org/661235

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40202 0039d316-1c4b-4281-b951-d872f2087c98

R=eroman
BUG=none
TEST=No compilation errors.
Review URL: http://codereview.chromium.org/660223

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40201 0039d316-1c4b-4281-b951-d872f2087c98

BUG=36964
TEST=none

Review URL: http://codereview.chromium.org/660234

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40200 0039d316-1c4b-4281-b951-d872f2087c98

"/b/slave/chromium-rel-linux/build/src/gpu/command_buffer/client/gles2_demo_cc.cc:50:warning: 'length' may be used uninitialized in this function"

Revert 40193 - Added support for glGetString, glGetShaderSource,
glGetProgramInfoLog and glGetShaderInfoLog

This turned up lots of issues.

* glGetShaderiv needed to be wrapped so it 
  returns the size of the shader the user passed
  in. Not the munged shader sent to GL.

* Another issue that came up is that client
  side validation is needed to ensure that
  the client side GLES2Implementation does not
  generate bad commands.  For example, calling
  glUniform1iv with a negative count would
  generate a bad command. The service side
  would see that and think the program was
  malicious and stop processing commands.

  So, that means I had to add some client side
  validation and wrap glGetError on the client 
  side so I can synthisize GL errors there.

TEST=lots of unit tests.
BUG=none

Review URL: http://codereview.chromium.org/661220

TBR=gman@chromium.org
Review URL: http://codereview.chromium.org/660229

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40198 0039d316-1c4b-4281-b951-d872f2087c98

Check that we report that we wrote no more than we requested to write.
Remove some debugging.

BUG=27870
TEST=none

Review URL: http://codereview.chromium.org/660194

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40197 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/660190

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40195 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/660191

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40194 0039d316-1c4b-4281-b951-d872f2087c98

glGetProgramInfoLog and glGetShaderInfoLog

This turned up lots of issues.

* glGetShaderiv needed to be wrapped so it 
  returns the size of the shader the user passed
  in. Not the munged shader sent to GL.

* Another issue that came up is that client
  side validation is needed to ensure that
  the client side GLES2Implementation does not
  generate bad commands.  For example, calling
  glUniform1iv with a negative count would
  generate a bad command. The service side
  would see that and think the program was
  malicious and stop processing commands.

  So, that means I had to add some client side
  validation and wrap glGetError on the client 
  side so I can synthisize GL errors there.

TEST=lots of unit tests.
BUG=none

Review URL: http://codereview.chromium.org/661220

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40193 0039d316-1c4b-4281-b951-d872f2087c98

SSL secure renegotiation.

R=abarth
BUG=none
TEST=Run Chrome witl logging enabled.  Visit https://www.google.com/.
An informational message like
  [1812:8012:351987676:INFO:ssl_client_socket_nss.cc(651)]
  The server www.google.com does not support SSL secure renegotiation.
should be logged.  Then visit https://ssltls.de/.  No such informational
message should be logged.
Review URL: http://codereview.chromium.org/660144

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40192 0039d316-1c4b-4281-b951-d872f2087c98

(http://codereview.chromium.org/652016).

Review URL: http://codereview.chromium.org/661232

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40191 0039d316-1c4b-4281-b951-d872f2087c98

unlimited_quota permission that extensions can use to request
unlimited quota.

TEST=ExtensionsServiceTest.StorageQuota
BUG=27688


Review URL: http://codereview.chromium.org/660113

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40190 0039d316-1c4b-4281-b951-d872f2087c98

The flow control in media::DecoderBase was incorrect because it reads too
aggressively to the demuxer stream and failed some DCHECKs when asynchronous
decoding like OpenMAX is used.

An example of a failing case is:
Action    Pending Read    Pending Decode   Read Request
Read           1                0               1
Read           2                0               2
ReadComplete   1                1               2
ReadComplete   0                2               2
DecodeComplete 1                1               1
DecodeComplete 1                0               0

Because of the aggressive read in OnDecodeComplete in DecoderBase. Even
if all the read requests are fulfiled there is still on pending read issued
to the demuxer stream. This mismatch is fixed in this patch.

BUG=32947
TEST=media_unittests

Review URL: http://codereview.chromium.org/660170

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40189 0039d316-1c4b-4281-b951-d872f2087c98

TEST=None
BUG=1698
Review URL: http://codereview.chromium.org/661230

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40188 0039d316-1c4b-4281-b951-d872f2087c98

Read/write the data in the style of fread/fwrite, rather than doing
I/O element by element.  This lays the groundwork for adding
checksumming.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39619

Review URL: http://codereview.chromium.org/650113

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40186 0039d316-1c4b-4281-b951-d872f2087c98

Changes from std::vector<> to std::set<> because set_difference()
works on sorted inputs.

The loop is broken into two parts.  The outer loop continues
while progress is being made.  The inner loop spins the event
loop while:
 - no progress has been made; and
   - it hasn't spun enough times; or
   - it hasn't spun for long enough

The odd timeout calculation is because some sequences need the
event loop spun after a timeout, not until a timeout (difference
between taking the time at the start and at the end).

As long as I was changing comments, I (hopefully) removed the
royal "We" in appeasement of The Mentovai.

BUG=36677
TEST=tests continue to work, even under valgrind

Review URL: http://codereview.chromium.org/660213

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40185 0039d316-1c4b-4281-b951-d872f2087c98

Most notably, don't start the request until the URL has been verified.

The previous behavior was to overlap the retrieval of the request's headers with the URL check.
This meant that cookies from blocked pages got applied, and also that the renderer received the headers for blocked pages, and other awkwardness.

Blocking before the request has started also has the advantage of protecting against malware URLs that might exploit bugs in the HTTP stack itself (as the request is never started).

In terms of performance, overlapping had the benefit that the request gets a head start while the URL is being verified.
In practice I don't think this is actually significant, since we rely on low bloom filter false positives to avoid these extended checks in the first place. Hence optimizing for the uncommon case of extended checks isn't fruitful, especially when it comes at the cost of complexity.

I don't have unit-tests for this yet since there wasn't an existing framework to put them in (apparantly there are no safe browsing unit tests for ResourceDispatcherHost?).
I will follow up with another CL that does the necessary surgery to add such tests in resource_dispatcher_host_unittest.cc.

BUG=33572,36046
TEST=see bugs.
Review URL: http://codereview.chromium.org/661072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40184 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/660205

TBR=dumi@chromium.org
Review URL: http://codereview.chromium.org/661228

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40183 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=existing unit tests

Review URL: http://codereview.chromium.org/661194

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40182 0039d316-1c4b-4281-b951-d872f2087c98

Teach the cookie tree view and model about appcaches. Not hooked up to real data yet, but the view and model pieces are in place for windows and gtk (not yet done for the mac).

Also adds a 'name' attribute to database details pane, cleans up the layout of the detail panes on windows.

BUG=25977
TEST=manual

Review URL: http://codereview.chromium.org/650110

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40181 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/660209

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40179 0039d316-1c4b-4281-b951-d872f2087c98

Eliminated the old Mozilla implementation and used an ICU-based implementation.

BUG=2759
TEST=base_unittests --gtest_filter=StringUtilTest.IsStringUTF8 

Review URL: http://codereview.chromium.org/661205

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40178 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/660205

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40177 0039d316-1c4b-4281-b951-d872f2087c98