TBR=tony
TEST=none
BUG=none



git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67980 0039d316-1c4b-4281-b951-d872f2087c98

This change just adds a virtual destructor to TestRenderViewHost to see we can delete the objects created in its constructor.

BUG=64726
TEST=make the "Chromium Mac (valgrind)" bot green.
Review URL: http://codereview.chromium.org/5273011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67977 0039d316-1c4b-4281-b951-d872f2087c98

It seems scoped_refptr<MessageLoopProxy>::~scoped_refptr() cannot call MessageLoopProxyImpl::~MessageLoopProxyImpl() because it is not a virtual destructor. This change just changes it to a virtual one.

BUG=64463
TEST=make the valgrind bots green.
Review URL: http://codereview.chromium.org/5321012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67976 0039d316-1c4b-4281-b951-d872f2087c98

The bloom filter seems to be hitting the max size sometimes, which is
(apparently) driving up SB2.GetHash204 results.  Increase the size a
bit to see if that's really the problem.

BUG=64995
TEST=none

Review URL: http://codereview.chromium.org/5513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67975 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5538001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67974 0039d316-1c4b-4281-b951-d872f2087c98

- Move GetNumActiveInputMethods call from input_method_menu_button.cc to input_method_library.cc so that the IBus function is called only once even when multiple Chrome windows are available.
- Improved InputMethodMenu::InputMethodChanged so that only the first input method button would update Preferences.
- Remove ImePropertiesChanged callback. It's obsolete.

BUG=chromium-os:8553
TEST=manually.

Review URL: http://codereview.chromium.org/4162002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67973 0039d316-1c4b-4281-b951-d872f2087c98

BUG=63774
TEST=Visit http://vescam.com/select_crasher.html and try all the selects
     in that page.

Review URL: http://codereview.chromium.org/5302009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67969 0039d316-1c4b-4281-b951-d872f2087c98

BUG=61609
TEST=No change right now (multi-install related).

Review URL: http://codereview.chromium.org/5429002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67968 0039d316-1c4b-4281-b951-d872f2087c98

The code was originally added to fix crosbug.com/1560, but this is
no longer necessary.

TEST=confirmed that the issue did not reproduce.
BUG=chromium-os:1560

Review URL: http://codereview.chromium.org/5554001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67963 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:6268
TEST=manually on the netbook

Review URL: http://codereview.chromium.org/5440001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67962 0039d316-1c4b-4281-b951-d872f2087c98

windows.getCurrent(), to Firefox's CEEE.

Cloned from issue http://codereview.chromium.org/5277004/ by rogerta@chromium.org.

BUG=64979
TEST=see integration tests

Review URL: http://codereview.chromium.org/5512001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67961 0039d316-1c4b-4281-b951-d872f2087c98

BUG=64854
TEST=ie_unittests.exe

Review URL: http://codereview.chromium.org/5271011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67960 0039d316-1c4b-4281-b951-d872f2087c98

UpdateCandidates() was not efficient as it was always updating candidates.
We don't have to update candidates if the user is just moving the cursor
in the same page in the candidate window.

BUG=chromium-os:6509
TEST=confirmed that the candidate window worked as before and rendering is faster by the following steps:
1. start a youtube video to add loads
2. start typing with mozc
3. type a
4. hold the space key for a while.

Review URL: http://codereview.chromium.org/5444001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67956 0039d316-1c4b-4281-b951-d872f2087c98

BUG=64340
TEST=see bug

Review URL: http://codereview.chromium.org/5339014

TBR=estade@chromium.org
Review URL: http://codereview.chromium.org/5560001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67955 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=clang waterfall stays green

Review URL: http://codereview.chromium.org/5520002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67954 0039d316-1c4b-4281-b951-d872f2087c98

When we hit the max socket limit, we close an idle socket in order to make space for the new preconnecting socket.  It's possible for the selected socket to belong to the same connection group as the one we're preconnecting a socket for.  This is obviously broken.  The bug currently results in us potentially deleting the ClientSocketPoolHelper::Group associated with that connection group, so the |Group* group| local variable in RequestSocketInternal() is now invalid.  Any access to that variable later on in the function results in badness.

This was safe before because we would never try to close an idle socket in the connection group we're request a socket for, because the first condition in RequestSocketInternal() checks to see if we can reuse an idle socket.  In the preconnect case, since we want to warm up the number of sockets in the connection group, we bypass idle sockets.

The solution is to create a new function: CloseOneIdleSocketExceptInGroup(const Group*).  This way we avoid this problem.  I provide a return value so that the caller can tell whether or not an idle socket was closed.  If it was not closed (it's possible that the connection group we're requesting a socket for is the only one with idle sockets), then the caller can tell, so it can pass up the failure so RequestSockets() knows that we've hit the max socket limit and there's no point in trying to preconnect more sockets.

BUG=64940
TEST=New unittest.

Review URL: http://codereview.chromium.org/5549001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67953 0039d316-1c4b-4281-b951-d872f2087c98

TBR=vitalyr
TEST=none
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67952 0039d316-1c4b-4281-b951-d872f2087c98

BUG=64340
TEST=see bug

Review URL: http://codereview.chromium.org/5339014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67949 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67948 0039d316-1c4b-4281-b951-d872f2087c98

The test now starts HTTPd along with the WebSocket server. Running both servers
has become required because WebKit moved WebSocket tests under
LayoutTests/http/ directory.

BUG=49381
TEST=Run "ui_tests --gtest_filter=WorkerTest.WorkerWebSocketLayoutTests".

Review URL: http://codereview.chromium.org/5432002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67946 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67945 0039d316-1c4b-4281-b951-d872f2087c98

It's caused by an invalid read that sometimes leads to an invalid write that causes a CHECK failure.

BUG=64985
TEST=New unit test added, fails under valgrind without the fix.

Review URL: http://codereview.chromium.org/5523001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67942 0039d316-1c4b-4281-b951-d872f2087c98

BUG=n57345
TEST=manually with VoiceOver.	
Review URL: http://codereview.chromium.org/5310009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67941 0039d316-1c4b-4281-b951-d872f2087c98

TEST=try
BUG=none

Review URL: http://codereview.chromium.org/5260006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67940 0039d316-1c4b-4281-b951-d872f2087c98

The sandbox config allows everything for now; I will put in restrictions in a follow-up CL (which should be small).

This CL should have no visible effect (other than changing a few LOG(WARNING) to LOG(ERROR)).

BUG=48607
TEST=GPU process still works

Review URL: http://codereview.chromium.org/5491001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67939 0039d316-1c4b-4281-b951-d872f2087c98

Per UI mocks.

BUG=63814
TEST=Basic prefs should come first on all platforms

Review URL: http://codereview.chromium.org/5519001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67938 0039d316-1c4b-4281-b951-d872f2087c98

Prevents writing to buffer out of range.

TEST=try
BUG=none

Review URL: http://codereview.chromium.org/5525001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67937 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/5503001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67934 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5430003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67931 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:9623
TEST=Verify fix for chromium-os:9623.

Review URL: http://codereview.chromium.org/5524002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67929 0039d316-1c4b-4281-b951-d872f2087c98

Code re-factoring and cleanup.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/5258006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67928 0039d316-1c4b-4281-b951-d872f2087c98

BUG=19991
TEST=lock cert database with "certutil -d sql:.pki/nssdb -W", try to export a cert.

Review URL: http://codereview.chromium.org/5509001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67927 0039d316-1c4b-4281-b951-d872f2087c98

functions from different threads.

BUG=64844
TEST=Run integration tests.

Review URL: http://codereview.chromium.org/5290011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67926 0039d316-1c4b-4281-b951-d872f2087c98

to allow the dump including the heap memory.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/5262011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67925 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/5520001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67924 0039d316-1c4b-4281-b951-d872f2087c98

BUG=61771
Review URL: http://codereview.chromium.org/5334003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67923 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67922 0039d316-1c4b-4281-b951-d872f2087c98

BUG=62865
TEST=none

Review URL: http://codereview.chromium.org/5406004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67920 0039d316-1c4b-4281-b951-d872f2087c98

TEST=None
BUG=None

Review URL: http://codereview.chromium.org/5310011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67918 0039d316-1c4b-4281-b951-d872f2087c98

BUG=64850

TEST=Verify that associated crash goes away in Canary

Review URL: http://codereview.chromium.org/5490001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67917 0039d316-1c4b-4281-b951-d872f2087c98