- Dec 14, 2010
-
-
xiyuan@chromium.org authored
Change '\w+' to [A-Za-z0-9]{2,63} in email address regexp. This allows hypen to be used in domain name part of an email and sets a 2-63 chars length limit. Use the same email alias pattern for format3 as in format1 and format2. BUG=chromium-os:10250 TEST=Verify fix for chromim-os:10250. Review URL: http://codereview.chromium.org/5812004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69153 0039d316-1c4b-4281-b951-d872f2087c98
-
jknotten@chromium.org authored
BUG=None TEST=None Review URL: http://codereview.chromium.org/5744005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69152 0039d316-1c4b-4281-b951-d872f2087c98
-
kkania@chromium.org authored
BUG=59131 TEST=none Review URL: http://codereview.chromium.org/5698009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69151 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
Followup to http://codereview.chromium.org/5730004/. Need to cover memcheck suppressions too. BUG=61409 TEST=Memory bots. Review URL: http://codereview.chromium.org/5761002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69150 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
TBR=pfeldman Review URL: http://codereview.chromium.org/5814002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69149 0039d316-1c4b-4281-b951-d872f2087c98
-
cbentzel@chromium.org authored
BUG=66702 TEST=none Contributed by: asanka@google.com Review URL: http://codereview.chromium.org/5716004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69148 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
And a few places that it touches. BUG=23581 Review URL: http://codereview.chromium.org/5729005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69147 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
See https://bugs.webkit.org/show_bug.cgi?id=49764 for the WebKit side of this change. R=michaeln BUG=none TEST=none Review URL: http://codereview.chromium.org/5139005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69146 0039d316-1c4b-4281-b951-d872f2087c98
-
hans@chromium.org authored
To print the character code, we should cast the wchar_t to an int. The code currently happens to work because we don't compile with -fshort-wchars, and thus wchar_t is four bytes, which coincides with what %d in the snprintf format string expects. However, it's not portable, and Clang complains about this. BUG=none TEST=browser_tests --gtest_filter=RenderViewTest.OnHandleKeyboardEvent Review URL: http://codereview.chromium.org/5755005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69145 0039d316-1c4b-4281-b951-d872f2087c98
-
bryeung@google.com authored
BUG=none TEST=focusing a text field shows the placeholder keyboard Review URL: http://codereview.chromium.org/5747001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69142 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
BUG=64321 TEST=adhoc (visit http://www/~eisinger/redirect.html) Review URL: http://codereview.chromium.org/5382006 Patch from James Simonsen <simonjam@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69141 0039d316-1c4b-4281-b951-d872f2087c98
-
dmaclach@chromium.org authored
BUG=37026 TEST=NONE Review URL: http://codereview.chromium.org/5804004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69138 0039d316-1c4b-4281-b951-d872f2087c98
-
jknotten@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69137 0039d316-1c4b-4281-b951-d872f2087c98
-
bryeung@google.com authored
Build broken by gspencer@chromium.org: use of ResultCodes without including chrome/common/result_codes.h. TBR=sky@chromium.org BUG=touchui buildbot failure TEST=none Review URL: http://codereview.chromium.org/5791003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69136 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
BUG=none TEST=chrome receives touch events after logging in on chromeos Review URL: http://codereview.chromium.org/5726006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69135 0039d316-1c4b-4281-b951-d872f2087c98
-
bryeung@google.com authored
This fix makes GestureManager conform to the new way of doing Singletons. As per satish@'s email Tue, Dec 14, 2010. "Changes to Singleton<T> pattern usage" This affects the touchui build only. Original CL is http://codereview.chromium.org/3192002 BUG= TEST= Review URL: http://codereview.chromium.org/5696005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69133 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
BUG=none TEST=none http://codereview.chromium.org/5803003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69132 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
BUG=66453 TEST=none Review URL: http://codereview.chromium.org/5762002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69131 0039d316-1c4b-4281-b951-d872f2087c98
-
dmazzoni@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/5816001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69130 0039d316-1c4b-4281-b951-d872f2087c98
-
satish@chromium.org authored
BUG=65298 TEST=none Review URL: http://codereview.chromium.org/5753006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69129 0039d316-1c4b-4281-b951-d872f2087c98
-
joth@chromium.org authored
- in STL vector<> has no data() member. BUG=None TEST=Builds. base_unittest --gtest_filter=*Sym* Review URL: http://codereview.chromium.org/5705006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69128 0039d316-1c4b-4281-b951-d872f2087c98
-
ricow@chromium.org authored
Review URL: http://codereview.chromium.org/5719005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69127 0039d316-1c4b-4281-b951-d872f2087c98
-
danno@chromium.org authored
BUG=none TEST=change linux policy and check that it's refreshed Review URL: http://codereview.chromium.org/5732002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69126 0039d316-1c4b-4281-b951-d872f2087c98
-
nkostylev@chromium.org authored
BUG=chromium-os:9959 TEST=Manual. Review URL: http://codereview.chromium.org/5713006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69125 0039d316-1c4b-4281-b951-d872f2087c98
-
nkostylev@chromium.org authored
BUG=chromium-os:8282 TEST=manual Review URL: http://codereview.chromium.org/4134013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69124 0039d316-1c4b-4281-b951-d872f2087c98
-
joth@chromium.org authored
BUG=65298 TEST=Builds Review URL: http://codereview.chromium.org/5767005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69123 0039d316-1c4b-4281-b951-d872f2087c98
-
altimofeev@chromium.org authored
Also CL contains changes which unify communication between |UserController| and corresponding controls view (UserInput interface). BUG=chromium-os:9770 TEST=Play with login. Notice appearing spinners. Review URL: http://codereview.chromium.org/5709001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69122 0039d316-1c4b-4281-b951-d872f2087c98
-
ricow@chromium.org authored
This includes temporary test_expectations, will push a fix to webkit later today. Review URL: http://codereview.chromium.org/5805003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69121 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome://settingsdilmah@chromium.org authored
Set correct parent window for proxy settings: "under the hood", not "network settings". Remove close button when invoked at OOBE screen because there already exists another close button. BUG=chromium-os:10035 TEST=Manual Review URL: http://codereview.chromium.org/5790001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69118 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=61409 TEST=trybots Review URL: http://codereview.chromium.org/5730004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69117 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69115 0039d316-1c4b-4281-b951-d872f2087c98
-
achuith@chromium.org authored
BUG=chromium-os:3412,chromium-os:3292 TEST=On a ChromeOS device, file://media should now be accessible. Review URL: http://codereview.chromium.org/5785002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69113 0039d316-1c4b-4281-b951-d872f2087c98
-
finnur@chromium.org authored
at the same time. I am removing traces from two tests since I think the problem with those tests have been fixed. By suppressing the crash server window on the try servers and ensuring Chrome is in the foreground it looks like the test now works. I went back in time through pages of try server logs and it seems to work. I am also enabling my other test that was disabled at the same time, since I think that test will probably work now. I moved the window caption check to that file, so we can see if we still have the same problem when it fails. BUG=62936, 62937 TEST=This CL is all about tests. Review URL: http://codereview.chromium.org/5769003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69112 0039d316-1c4b-4281-b951-d872f2087c98
-
hans@chromium.org authored
Explicitly cast the returned value into the void. Clang complains about this unused return value otherwise. BUG=none TEST=flip_in_mem_edsm_server Review URL: http://codereview.chromium.org/5727003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69111 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
Suppress remoting_ Valgrind leaks; s/21ResourceMessageFilter/19RenderMessageFilter to fix the massive memory waterfall redness after r69076 TBR=glider TEST=./tools/valgrind/waterfall.sh BUG=66808 Review URL: http://codereview.chromium.org/5777003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69110 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
BUG=66808 TBR=glider TEST=heapchecker bot should go greener Review URL: http://codereview.chromium.org/5748007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69109 0039d316-1c4b-4281-b951-d872f2087c98
-
satish@chromium.org authored
TBR=thakis git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69108 0039d316-1c4b-4281-b951-d872f2087c98
-
satish@chromium.org authored
Make members of Singleton<T> private and only visible to the singleton type. This enforces that the Singleton<T> pattern can only be used within classes which want singleton-ness. As part of this CL I have also fixed up files which got missed in my previous CLs to use a GetInstance() method and use Singleton<T> from the source file. There are a small number of places where I have also switched to LazyInstance as that was more appropriate for types used in a single source file. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5682008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69107 0039d316-1c4b-4281-b951-d872f2087c98
-
willchan@chromium.org authored
I tried to repro this bug and could not. Seems to work. BUG=58553,28083 TEST=python chrome/test/functional/cookies.py cookies.CookiesTest.testCookiesFile Review URL: http://codereview.chromium.org/5721007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69106 0039d316-1c4b-4281-b951-d872f2087c98
-
csilv@chromium.org authored
- Shorten the signature for the crash in bug 66741. TBR=thestig@chromium.org BUG=66795 TEST=none Review URL: http://codereview.chromium.org/5697009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69105 0039d316-1c4b-4281-b951-d872f2087c98
-