- Nov 03, 2009
-
-
rohitrao@chromium.org authored
[Mac] Adds a new view that will allow us to animate the height property of views. This class will be the base class for any view that needs to be animated. BUG=None TEST=No visible impact. New unittests should pass. Review URL: http://codereview.chromium.org/350002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30852 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
We set -fPIC just on the layout test plugins and only in 64-bit mode. This fixes 44 plugin layout tests on 64-bit. BUG=18337,24271 Review URL: http://codereview.chromium.org/353022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30851 0039d316-1c4b-4281-b951-d872f2087c98
-
johnnyg@chromium.org authored
being rebaselined. TBR=jorlow BUG=none TEST=none Review URL: http://codereview.chromium.org/356005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30850 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
BUG=http://crbug.com/26457 TEST=as in bug Review URL: http://codereview.chromium.org/342103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30849 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
The regex didn't work for GCC = 4.4. Review URL: http://codereview.chromium.org/341085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30847 0039d316-1c4b-4281-b951-d872f2087c98
-
jshin@chromium.org authored
BUG=24733 TEST=go to http://jbbs.livedoor.jp/bbs/read.cgi/sports/30749/1255270799, open a history tab and type a search term. Chrome does not crash TBR=cevans Original Review: http://codereview.chromium.org/339090/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30846 0039d316-1c4b-4281-b951-d872f2087c98
-
jschuh@chromium.org authored
BUG=20469 TEST=None Review URL: http://codereview.chromium.org/326012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30845 0039d316-1c4b-4281-b951-d872f2087c98
-
ojan@chromium.org authored
1. Add support for V8-latest canaries. 2. Show actual results for the latest run of each bot. Review URL: http://codereview.chromium.org/340073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30844 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
comment in the code mentions that a vbox would cause a split screen, but looking at the code, it seems like that's not possible because we hide the old TCVG before adding new ones. These days the vbox contains all TCVGs and only shows one at a time (I think in the past we tried to remove them, but we don't have that problem now). This simplifies the code by not having to use our own size-allocate handler. Review URL: http://codereview.chromium.org/354018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30843 0039d316-1c4b-4281-b951-d872f2087c98
-
mnaganov@chromium.org authored
TBR=pfeldman@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/348062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30842 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/341074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30841 0039d316-1c4b-4281-b951-d872f2087c98
-
jamesr@chromium.org authored
The problem was that the ExtensionDevtoolsBridge maintained explicit knowledge of the RenderViewHost is was monitoring. This would be invalidated on page navigations where the inspected RVH would be swapped out from underneath it. This patch removes knowledge of RenderViewHost from the ExtensionDevToolsBridge and makes sure it appropriately unregisters itself. Patch by: Jaime Yap (jaimeyap@google.com) TEST=none BUG=none Review URL: http://codereview.chromium.org/348042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30840 0039d316-1c4b-4281-b951-d872f2087c98
-
fbarchard@chromium.org authored
BUG=26559 TEST=build ffmpeg. It should be smaller than before but still work. Review URL: http://codereview.chromium.org/351022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30839 0039d316-1c4b-4281-b951-d872f2087c98
-
gman@google.com authored
o3djs files and build / selenium to use compiled o3djs libs. Review URL: http://codereview.chromium.org/353017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30838 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
BUG=20111,26582 Review URL: http://codereview.chromium.org/346039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30837 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
(1) Clicking on the Text Encoding menu item should display the submenu, not try to execute a nonexistent command. (2) The Text Encoding menu item shouldn't be disabled, but instead the submenu's contents (so that the submenu is always visible). See Apple's HIG: <http://developer.apple.com/mac/library/DOCUMENTATION/UserExperience/Conceptual/AppleHIGuidelines/XHIGMenus/XHIGMenus.html#//apple_ref/doc/uid/TP30000356-TPXREF122>. Changes to MainMenu.xib: disconnected |-commandDispatch:| from the Text Encoding menu item. BUG=25957,26593 TEST=Check that the Text Encoding submenu is always available, with its contents disabled on the NTP (for example) and enabled (and working) on a normal web page. Check that clicking (and releasing) on the Text Encoding menu item itself shows the submenu. Review URL: http://codereview.chromium.org/345050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30836 0039d316-1c4b-4281-b951-d872f2087c98
-
rafaelw@chromium.org authored
BUG=26540 Review URL: http://codereview.chromium.org/341078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30835 0039d316-1c4b-4281-b951-d872f2087c98
-
thomasvl@chromium.org authored
TEST=the reset to defaults button is the right size in all languages. BUG=20538 Review URL: http://codereview.chromium.org/345049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30834 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
This CL decouples the implementation of WebDevToolsAgent from the implementation of WebViewImpl. While this allows me to postpone the uplift of glue/devtools into webkit/api/src, I think it also has the advantage of simplifying dependencies. WebDevToolsAgentPrivate is introduced for the method calls made by the FrameLoaderClientImpl to the WebDevToolsAgentImpl. R=dglazkov BUG=none TEST=none Review URL: http://codereview.chromium.org/342092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30833 0039d316-1c4b-4281-b951-d872f2087c98
-
apavlov@chromium.org authored
BUG=none TEST=none TBR=pfeldman Review URL: http://codereview.chromium.org/345041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30832 0039d316-1c4b-4281-b951-d872f2087c98
-
rafaelw@chromium.org authored
TBR=mad,twiz BUG=26599 Review URL: http://codereview.chromium.org/353021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30831 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
First, made it possible to navigate to "invalid" hostnames in a number of additional cases, including when the user types an explicit scheme or when we have a valid TLD and no spaces. The default action for these kinds of inputs is still search, but we'll pull up an accidental search infobar if need be now. Second, made the HistoryURLProvider show a What You Typed match for UNKNOWN inputs when the user explicitly typed "http:" or "https:" at the front, since these have the highest probability of being navigational inputs. BUG=26341 TEST=Type "http://foo bar baz.com" and verify you are given a (non-default) entry in the dropdown to navigate. Review URL: http://codereview.chromium.org/353010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30830 0039d316-1c4b-4281-b951-d872f2087c98
-
mnaganov@chromium.org authored
TBR=pfeldman@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/355012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30829 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
BUG=25962 TEST=Type in "google.com." and verify you can navigate. Review URL: http://codereview.chromium.org/340070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30828 0039d316-1c4b-4281-b951-d872f2087c98
-
thomasvl@chromium.org authored
BUG=none TEST=a shade of grey now. Review URL: http://codereview.chromium.org/348059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30827 0039d316-1c4b-4281-b951-d872f2087c98
-
kathyw@google.com authored
later, with the new overview.html file. TEST=none BUG=26164 Review URL: http://codereview.chromium.org/348058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30826 0039d316-1c4b-4281-b951-d872f2087c98
-
thomasvl@chromium.org authored
- Make all the controls/labels wrap to the width they get. - Make the content vertically shift as it is made to fit its strings. - Add more spacing for the sections as listed in bugs. - Consistent indents for the sections/subsections. - Update the code to use constant naming (was was "under the hood" and some was "advanced" (just so it is clear they are talking about one thing, and not two). - DEPS roll for GTM to pick up support for NSPathControl. TEST=Under the hood content should fit in all languages. BUG=20538 BUG=25595 BUG=25597 Review URL: http://codereview.chromium.org/355011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30825 0039d316-1c4b-4281-b951-d872f2087c98
-
craig.schlenter@chromium.org authored
This runs g++ -dumpversion (or $CXX) to establish the compiler version and set the gyp gcc_version variable automatically. BUG=25209 Review URL: http://codereview.chromium.org/339046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30824 0039d316-1c4b-4281-b951-d872f2087c98
-
fbarchard@chromium.org authored
BUG=22307,26548 TEST=start with clean machine that has no bzip2 and build chrome without it. Review URL: http://codereview.chromium.org/348052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30823 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
BUG=http://crbug.com/26591 TEST=go to "under the hood" in prefs; see correct grammar Review URL: http://codereview.chromium.org/356001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30822 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
Fix autofill popups not closing when there are no suggestions. We have to call through on an empty suggestion array so that the popup is told to close. BUG=http://crbug.com/25559 TEST=as in bug Review URL: http://codereview.chromium.org/353009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30821 0039d316-1c4b-4281-b951-d872f2087c98
-
mark@chromium.org authored
BUG=zero TEST=no Review URL: http://codereview.chromium.org/341083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30820 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
does not implement the actual opening of the files (currently the chain ends in resource_message_filter.cc), I will do that separately with some additional security review. This current patch just gets the synchronous request to the browser and returns a NULL result. TEST=none BUG=none Review URL: http://codereview.chromium.org/340050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30819 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
Bookmarks for pages without a favicon should display a generic "blank page" icon (this also helps avoid a blank button if the bookmark also doesn't have a title). Also, folders within folders also need to display the folder icon. BUG=23558 TEST=See above; be sure to test things on the bar and in folders, and make sure that pages with favicons are still displayed correctly. Review URL: http://codereview.chromium.org/339087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30818 0039d316-1c4b-4281-b951-d872f2087c98
-
senorblanco@chromium.org authored
BUG=26291 TEST=green is good TBR=hclam Review URL: http://codereview.chromium.org/342098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30817 0039d316-1c4b-4281-b951-d872f2087c98
-
mirandac@chromium.org authored
BUG= http://crbug.com/19282 TEST= Use report bug dialog on Mac OSX. Review URL: http://codereview.chromium.org/340039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30815 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/340069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30813 0039d316-1c4b-4281-b951-d872f2087c98
-
plesner@chromium.org authored
Review URL: http://codereview.chromium.org/341080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30812 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-bot@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30811 0039d316-1c4b-4281-b951-d872f2087c98
-
yurys@google.com authored
Create an empty object template for the utility context global object instead of using ShadowObjectTemplate. The shadow object overrides some of the window properties(top, location,...) that led to a failure when accessing these properties since the template was not configured correctly(all its internal fields were undefined). In fact, we don't need the utility context global object to be a shadow object as long as inspected window global object is proto of the utility context global object. BUG=26058 Review URL: http://codereview.chromium.org/342093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30810 0039d316-1c4b-4281-b951-d872f2087c98
-